Fix to [#21938] File Browser: Not showing folders with spaces #21952

New Issue

Ignacio Fernández · 2010-04-08T12:34:19+02:00

2010-04-08 12:34:19 +02:00

%%%This allows navigating through Reparse Points in windows Vista and 7. I'm not a c hard coder so the code may not be "clean" or it may not be totally multi-platform aware (I had a look to other code and used #ifdef WIN32 for the WIN32 platform but it may be wrong).

Also It may not work for Xp due to the use of GetFinalPathNameByHandle. Please check.

For the blender file browser to behave as the windows one the "real" folders should be masked (i.e. you only see "Usuarios" and not "Users" folder in spanish) but that may be done in other patch.

Regards,

Ignacio%%%

%%%This allows navigating through Reparse Points in windows Vista and 7. I'm not a c hard coder so the code may not be "clean" or it may not be totally multi-platform aware (I had a look to other code and used #ifdef WIN32 for the WIN32 platform but it may be wrong). Also It may not work for Xp due to the use of GetFinalPathNameByHandle. Please check. For the blender file browser to behave as the windows one the "real" folders should be masked (i.e. you only see "Usuarios" and not "Users" folder in spanish) but that may be done in other patch. Regards, Ignacio%%%

Ignacio Fernández commented

2010-04-08 12:34:19 +02:00

Changed status to: 'Open'

Andrea Weikert commented

2010-04-14 22:51:49 +02:00

%%%Thanks for the patch I tried it here on Windows Vista and it works fine.

Unfortunately it doesn't work on Windows XP, so we have to find a way to make this available in newer versions of Windows only without having to create separate executables and installations.
%%%

%%%Thanks for the patch I tried it here on Windows Vista and it works fine. Unfortunately it doesn't work on Windows XP, so we have to find a way to make this available in newer versions of Windows only without having to create separate executables and installations. %%%

Richard Sanger commented

2010-04-15 04:38:39 +02:00

%%%Have a look at this article on MSDN Obtaining a File Name From a File Handle http://msdn.microsoft.com/en-us/library/aa366789%28v=VS.85%29.aspx.%%%

Richard Sanger commented

2010-04-15 04:56:24 +02:00

%%%If you cannot use that to make it work on XP, use

OSVERSIONINFOW OSVersion;
ZeroMemory(&OSVersion, sizeof(OSVERSIONINFO));
OSVersion.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
GetVersionEx(&OSVersion);

If(OSVersion.dwMajorVersion >= 6)//its vista or higher

See MSDN article http://msdn.microsoft.com/en-us/library/ms724832%28v=VS.85%29.aspx%%%

%%%If you cannot use that to make it work on XP, use OSVERSIONINFOW OSVersion; ZeroMemory(&OSVersion, sizeof(OSVERSIONINFO)); OSVersion.dwOSVersionInfoSize = sizeof(OSVERSIONINFO); GetVersionEx(&OSVersion); If(OSVersion.dwMajorVersion >= 6)//its vista or higher See MSDN article http://msdn.microsoft.com/en-us/library/ms724832%28v=VS.85%29.aspx%%%

Ignacio Fernández commented

2010-04-15 09:57:45 +02:00

%%%Thanks for the code, Richard. Unfortunately i can't compile Blender now due to the pthreads.h error so i can't try it until i fix that. Can you add it to the patch and test?%%%

Ignacio Fernández commented

2010-04-20 09:39:50 +02:00

%%%New patch (patch_vista.txt). Added function to check if the Windows version is one given or later so now the new code should not run for Xp and earlier (can't try so please check).%%%

Richard Sanger commented

2010-04-22 12:09:30 +02:00

%%%Hi Ignacio,
Turns out that still doesn't work on XP because blender is trying to load GetFinalPathNameByHandle() from the dll when it starts(Which doesn't exist in the XP dll so it causes a error and crash). Other than that its fine. However I did find this Tutorial http://www.dreamincode.net/forums/topic/118076-dlls-explicit-linking , I'll try it out and see if I can get it to load this way.%%%

%%%Hi Ignacio, Turns out that still doesn't work on XP because blender is trying to load GetFinalPathNameByHandle() from the dll when it starts(Which doesn't exist in the XP dll so it causes a error and crash). Other than that its fine. However I did find this Tutorial http://www.dreamincode.net/forums/topic/118076-dlls-explicit-linking , I'll try it out and see if I can get it to load this way.%%%

Ignacio Fernández commented

2010-04-22 12:28:16 +02:00

%%%Hi Richard,

Didn't think of that. Let me know if you find something but if there is no way to skip that load two separate builds will be needed or a way to get the reparse point addres without using that function.

Maybe there is a way to fake that function when is not present in xp and earlier as it won't be used anyway, but i don't know how to do that.%%%

%%%Hi Richard, Didn't think of that. Let me know if you find something but if there is no way to skip that load two separate builds will be needed or a way to get the reparse point addres without using that function. Maybe there is a way to fake that function when is not present in xp and earlier as it won't be used anyway, but i don't know how to do that.%%%

Richard Sanger commented

2010-04-23 15:24:56 +02:00

%%%Hi Ignacio,

Managed to get this working on Vista and not crashing on XP see updated patch here http://docs.google.com/View?id=dd299srs_31g3g7km4j. I've added in

ifdef MINGW32
define _WIN32_WINNT 0x0500

endif

so it will build on minGW(as well as visual studio), but I doubt this is how this should be done. Other than that there aren't any other problems that I've found.%%%

%%%Hi Ignacio, Managed to get this working on Vista and not crashing on XP see updated patch here http://docs.google.com/View?id=dd299srs_31g3g7km4j. I've added in - ifdef __MINGW32__ - define _WIN32_WINNT 0x0500 # endif so it will build on minGW(as well as visual studio), but I doubt this is how this should be done. Other than that there aren't any other problems that I've found.%%%

Andrea Weikert commented

2011-01-04 16:47:54 +01:00

%%%Hi Ignacio, Hi Richard,

I've got a bit of time on my hand in the next days or so and would like to attempt to fix this issue. Unfortunately I can't get to the updated patch on docs.google.com anymore - could you attach the latest patch here on the tracker? (I know it's been a long time...)

Cheers,
Andrea
%%%

%%%Hi Ignacio, Hi Richard, I've got a bit of time on my hand in the next days or so and would like to attempt to fix this issue. Unfortunately I can't get to the updated patch on docs.google.com anymore - could you attach the latest patch here on the tracker? (I know it's been a long time...) Cheers, Andrea %%%

Bastien Montagne commented

2014-08-04 13:54:05 +02:00

Changed status from 'Open' to: 'Archived'

Bastien Montagne closed this issue

2014-08-04 13:54:05 +02:00

Bastien Montagne commented

2014-08-04 13:54:05 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2014-08-04 13:54:05 +02:00

Seems time to archive this one, org report has been closed since ages too…

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix to [#21938] File Browser: Not showing folders with spaces #21952

endif