Texture image reload sometimes crashes #25999

New Issue

Georg Acher · 2011-02-09T20:35:29+01:00

Georg Acher commented

2011-02-09 20:35:29 +01:00

%%%Ubuntu 10.04, 32Bit, own Kernel 2.6.35.7, i7-860, 4GB RAM
Blender svn r34744 (but happened also in December, AFAIR also in official 2.55)
gcc 4.4.3, blender compiled with Flags -O3 -g
Nvidia GT218, driver 260.19.12

The attached file contains a simple plane with a image texture. When clicking the image-reload button fast and often, blender crashes after some time. But it can take 20 to 100 clicks. It seems more likely to happen for larger images.

The backtrace shows:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xaf700b70 (LWP 23573)]
imb_onehalf_no_alloc (ibuf2=0xa832d20, ibuf1=0xb15b17d8) at /home/acher/src/blender/source/blender/imbuf/intern/scaling.c:312
312 dest- [x] = (p1- [x] + p2- [x] + p1- [x] + p2- [x]) >> 2;
(gdb) p p1
$2 = (uchar *) 0xb0a53da0 <Address 0xb0a53da0 out of bounds>
(gdb) bt

0 imb_onehalf_no_alloc (ibuf2=0xa832d20, ibuf1=0xb15b17d8) at /home/acher/src/blender/source/blender/imbuf/intern/scaling.c:312
1 0x0889171a in IMB_onehalf (ibuf1=0xb15b17d8) at /home/acher/src/blender/source/blender/imbuf/intern/scaling.c:352
2 0x0888af55 in IMB_makemipmap (ibuf=0xb15b17d8, use_filter=0) at /home/acher/src/blender/source/blender/imbuf/intern/filter.c:429
3 0x085a39c3 in image_mipmap_test (tex=0xfd, ibuf=0xb0a53da0) at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:980

4 0x085a5812 in imagewraposa_aniso (tex=0xb15e1800, ima=0xb1505f20, ibuf=0xb15b17d8, texvec=0xaf6eb688, DXT=0xaf6eb67c, DYT=0xaf6eb670, texres=0xaf6eb60c)

  at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:1025

5 imagewraposa (tex=0xb15e1800, ima=0xb1505f20, ibuf=0xb15b17d8, texvec=0xaf6eb688, DXT=0xaf6eb67c, DYT=0xaf6eb670, texres=0xaf6eb60c)

  at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:1388

6 0x085cce93 in multitex (tex=0xb15e1800, texvec=0xb0a562a8, dxt=0xaf6eb67c, dyt=0xaf6eb670, osatex=512, texres=0xaf6eb60c, thread=1, which_output=0)

  at /home/acher/src/blender/source/blender/render/intern/source/render_texture.c:1201

7 0x085d4926 in do_material_tex (shi=0xaf6f95e0) at /home/acher/src/blender/source/blender/render/intern/source/render_texture.c:2278
8 0x085eb7e0 in shade_lamp_loop (shi=0xaf6f95e0, shr=0xaf6fe8a8) at /home/acher/src/blender/source/blender/render/intern/source/shadeoutput.c:1600
9 0x085e22a9 in shade_material_loop (shi=0xaf6f95e0, shr=0xaf6fe7e0) at /home/acher/src/blender/source/blender/render/intern/source/shadeinput.c:105
10 0x085e2584 in shade_input_do_shade (shi=0xaf6f95e0, shr=0xaf6fe7e0) at /home/acher/src/blender/source/blender/render/intern/source/shadeinput.c:176

11 0x085fefb9 in shade_tra_samples (ssamp=, cache=, x=65, y=60, row=0xaf6ebadc, addpassflag=0)

  at /home/acher/src/blender/source/blender/render/intern/source/zbuf.c:3818

12 0x08607127 in zbuffer_transp_shade (pa=0xa8596b8, rl=0xa4d28a8, pass=0xaa58d90, psmlist=0xaf700278) at /home/acher/src/blender/source/blender/render/intern/source/zbuf.c:4152
13 0x085c9c64 in zbufshadeDA_tile (pa=0xa8596b8) at /home/acher/src/blender/source/blender/render/intern/source/rendercore.c:1207
14 0x085b7072 in do_part_thread (pa_v=0xa8596b8) at /home/acher/src/blender/source/blender/render/intern/source/pipeline.c:1468
15 0x08872ae2 in tslot_thread_start (tslot_p=0xa4998e0) at /home/acher/src/blender/source/blender/blenlib/intern/threads.c:213
16 0xb7e0f96e in start_thread (arg=0xaf700b70) at pthread_create.c:300
17 0xb6990a4e in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:130

Less likely it crashes also here:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xad6fab70 (LWP 25668)]
IMB_makemipmap (ibuf=0xb1a93bd0, use_filter=0) at /home/acher/src/blender/source/blender/imbuf/intern/filter.c:435
435 if(!hbuf || (hbuf->x == 1 && hbuf->y == 1))
(gdb) p hbuf
$1 = (ImBuf *) 0x0

0 IMB_makemipmap (ibuf=0xb1a93bd0, use_filter=0) at /home/acher/src/blender/source/blender/imbuf/intern/filter.c:435
1 0x085a39c3 in image_mipmap_test (tex=0x0, ibuf=0x0) at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:980

2 0x085a5812 in imagewraposa_aniso (tex=0xa5ca428, ima=0xa5bd5c0, ibuf=0xb1a93bd0, texvec=0xad6e5688, DXT=0xad6e567c, DYT=0xad6e5670, texres=0xad6e560c)

  at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:1025

...

Especially the hbuf-crash (now zero, but not zero before) smells like a race, the machine has 8 cores (4 real, twice with HT). I've attached also the full thread backtrace for the last case. A lot of threads are waiting in image_mipmap_test for a lock, maybe one other section in that area is still unprotected.

BTW: Maybe related are huge memory leaks while scrubbing over image-sequenced textures/background image sequences. Also render errors appear on such sequence textures when playing with the GUI while rendering (some render threads don't "see" the texture). But reproducing them is a hard task...%%%

%%%Ubuntu 10.04, 32Bit, own Kernel 2.6.35.7, i7-860, 4GB RAM Blender svn r34744 (but happened also in December, AFAIR also in official 2.55) gcc 4.4.3, blender compiled with Flags -O3 -g Nvidia GT218, driver 260.19.12 The attached file contains a simple plane with a image texture. When clicking the image-reload button fast and often, blender crashes after some time. But it can take 20 to 100 clicks. It seems more likely to happen for larger images. The backtrace shows: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xaf700b70 (LWP 23573)] imb_onehalf_no_alloc (ibuf2=0xa832d20, ibuf1=0xb15b17d8) at /home/acher/src/blender/source/blender/imbuf/intern/scaling.c:312 312 dest- [x] = (p1- [x] + p2- [x] + p1- [x] + p2- [x]) >> 2; (gdb) p p1 $2 = (uchar *) 0xb0a53da0 <Address 0xb0a53da0 out of bounds> (gdb) bt - 0 imb_onehalf_no_alloc (ibuf2=0xa832d20, ibuf1=0xb15b17d8) at /home/acher/src/blender/source/blender/imbuf/intern/scaling.c:312 - 1 0x0889171a in IMB_onehalf (ibuf1=0xb15b17d8) at /home/acher/src/blender/source/blender/imbuf/intern/scaling.c:352 - 2 0x0888af55 in IMB_makemipmap (ibuf=0xb15b17d8, use_filter=0) at /home/acher/src/blender/source/blender/imbuf/intern/filter.c:429 - 3 0x085a39c3 in image_mipmap_test (tex=0xfd, ibuf=0xb0a53da0) at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:980 # 4 0x085a5812 in imagewraposa_aniso (tex=0xb15e1800, ima=0xb1505f20, ibuf=0xb15b17d8, texvec=0xaf6eb688, DXT=0xaf6eb67c, DYT=0xaf6eb670, texres=0xaf6eb60c) ``` at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:1025 ``` # 5 imagewraposa (tex=0xb15e1800, ima=0xb1505f20, ibuf=0xb15b17d8, texvec=0xaf6eb688, DXT=0xaf6eb67c, DYT=0xaf6eb670, texres=0xaf6eb60c) ``` at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:1388 ``` # 6 0x085cce93 in multitex (tex=0xb15e1800, texvec=0xb0a562a8, dxt=0xaf6eb67c, dyt=0xaf6eb670, osatex=512, texres=0xaf6eb60c, thread=1, which_output=0) ``` at /home/acher/src/blender/source/blender/render/intern/source/render_texture.c:1201 ``` - 7 0x085d4926 in do_material_tex (shi=0xaf6f95e0) at /home/acher/src/blender/source/blender/render/intern/source/render_texture.c:2278 - 8 0x085eb7e0 in shade_lamp_loop (shi=0xaf6f95e0, shr=0xaf6fe8a8) at /home/acher/src/blender/source/blender/render/intern/source/shadeoutput.c:1600 - 9 0x085e22a9 in shade_material_loop (shi=0xaf6f95e0, shr=0xaf6fe7e0) at /home/acher/src/blender/source/blender/render/intern/source/shadeinput.c:105 - 10 0x085e2584 in shade_input_do_shade (shi=0xaf6f95e0, shr=0xaf6fe7e0) at /home/acher/src/blender/source/blender/render/intern/source/shadeinput.c:176 # 11 0x085fefb9 in shade_tra_samples (ssamp=<value optimized out>, cache=<value optimized out>, x=65, y=60, row=0xaf6ebadc, addpassflag=0) ``` at /home/acher/src/blender/source/blender/render/intern/source/zbuf.c:3818 ``` - 12 0x08607127 in zbuffer_transp_shade (pa=0xa8596b8, rl=0xa4d28a8, pass=0xaa58d90, psmlist=0xaf700278) at /home/acher/src/blender/source/blender/render/intern/source/zbuf.c:4152 - 13 0x085c9c64 in zbufshadeDA_tile (pa=0xa8596b8) at /home/acher/src/blender/source/blender/render/intern/source/rendercore.c:1207 - 14 0x085b7072 in do_part_thread (pa_v=0xa8596b8) at /home/acher/src/blender/source/blender/render/intern/source/pipeline.c:1468 - 15 0x08872ae2 in tslot_thread_start (tslot_p=0xa4998e0) at /home/acher/src/blender/source/blender/blenlib/intern/threads.c:213 - 16 0xb7e0f96e in start_thread (arg=0xaf700b70) at pthread_create.c:300 - 17 0xb6990a4e in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:130 Less likely it crashes also here: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xad6fab70 (LWP 25668)] IMB_makemipmap (ibuf=0xb1a93bd0, use_filter=0) at /home/acher/src/blender/source/blender/imbuf/intern/filter.c:435 435 if(!hbuf || (hbuf->x == 1 && hbuf->y == 1)) (gdb) p hbuf $1 = (ImBuf *) 0x0 - 0 IMB_makemipmap (ibuf=0xb1a93bd0, use_filter=0) at /home/acher/src/blender/source/blender/imbuf/intern/filter.c:435 - 1 0x085a39c3 in image_mipmap_test (tex=0x0, ibuf=0x0) at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:980 # 2 0x085a5812 in imagewraposa_aniso (tex=0xa5ca428, ima=0xa5bd5c0, ibuf=0xb1a93bd0, texvec=0xad6e5688, DXT=0xad6e567c, DYT=0xad6e5670, texres=0xad6e560c) ``` at /home/acher/src/blender/source/blender/render/intern/source/imagetexture.c:1025 ``` ... Especially the hbuf-crash (now zero, but not zero before) smells like a race, the machine has 8 cores (4 real, twice with HT). I've attached also the full thread backtrace for the last case. A lot of threads are waiting in image_mipmap_test for a lock, maybe one other section in that area is still unprotected. BTW: Maybe related are huge memory leaks while scrubbing over image-sequenced textures/background image sequences. Also render errors appear on such sequence textures when playing with the GUI while rendering (some render threads don't "see" the texture). But reproducing them is a hard task...%%%

Georg Acher commented

2011-02-09 20:35:29 +01:00

Changed status to: 'Open'

Campbell Barton commented

2011-02-10 05:55:57 +01:00

%%%confirmed, assigning to Ton.%%%

Ton Roosendaal commented

2011-02-10 17:24:20 +01:00

%%%Second report today related to render code making mipmaps while UI is freeing it.

The cause is the preview render btw, if you let it finish before pressing reload all goes fine. The issue is well known, and on the todo list already for months.
For clarity I've added it prominently in wiki too:
http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Tools#Rendering

Will use your example to verify the new code as well. But it's getting moved to our todo. Thanks!%%%

%%%Second report today related to render code making mipmaps while UI is freeing it. The cause is the preview render btw, if you let it finish before pressing reload all goes fine. The issue is well known, and on the todo list already for months. For clarity I've added it prominently in wiki too: http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Tools#Rendering Will use your example to verify the new code as well. But it's getting moved to our todo. Thanks!%%%

Ton Roosendaal commented

2011-02-10 17:24:20 +01:00

Changed status from 'Open' to: 'Archived'

Ton Roosendaal closed this issue

2011-02-10 17:24:20 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Texture image reload sometimes crashes #25999

4 0x085a5812 in imagewraposa_aniso (tex=0xb15e1800, ima=0xb1505f20, ibuf=0xb15b17d8, texvec=0xaf6eb688, DXT=0xaf6eb67c, DYT=0xaf6eb670, texres=0xaf6eb60c)

5 imagewraposa (tex=0xb15e1800, ima=0xb1505f20, ibuf=0xb15b17d8, texvec=0xaf6eb688, DXT=0xaf6eb67c, DYT=0xaf6eb670, texres=0xaf6eb60c)

6 0x085cce93 in multitex (tex=0xb15e1800, texvec=0xb0a562a8, dxt=0xaf6eb67c, dyt=0xaf6eb670, osatex=512, texres=0xaf6eb60c, thread=1, which_output=0)

11 0x085fefb9 in shade_tra_samples (ssamp=, cache=, x=65, y=60, row=0xaf6ebadc, addpassflag=0)

2 0x085a5812 in imagewraposa_aniso (tex=0xa5ca428, ima=0xa5bd5c0, ibuf=0xb1a93bd0, texvec=0xad6e5688, DXT=0xad6e567c, DYT=0xad6e5670, texres=0xad6e560c)