Add fast linear light -> srgb conversion path #29309

New Issue

David M · 2011-11-17T17:49:18+01:00

David M commented

2011-11-17 17:49:18 +01:00

%%%Hi,

Rendering in the interface is currently slowed down quiet a lot by conversions
from linear to srgb (if color management is enabled).

The attached patch implements a LUT to speed it up.

Rendering the default cube in 4096x2048 took 8.4sec before the patch
and 3.3sec afterwards.

till then, David.
%%%

%%%Hi, Rendering in the interface is currently slowed down quiet a lot by conversions from linear to srgb (if color management is enabled). The attached patch implements a LUT to speed it up. Rendering the default cube in 4096x2048 took 8.4sec before the patch and 3.3sec afterwards. till then, David. %%%

David M commented

2011-11-17 17:49:18 +01:00

Changed status to: 'Open'

David M commented

2011-11-18 19:13:17 +01:00

%%%Updated patch moves dithering logic into math_color.c

This simplifies render_internal.c, while exposing more
conversion functions in math_color.h.%%%

%%%Updated patch moves dithering logic into math_color.c This simplifies render_internal.c, while exposing more conversion functions in math_color.h.%%%

Troy Sobotka commented

2011-12-19 19:21:43 +01:00

%%%I think this is fantastic. However, given the migration path to OCIO I'd love to see this done without the hard coded sRGB LUT.

Is it possible you have the ability to contribute to the OCIO migration David? Xavier was working on a branch at GitHub. Most of the infrastructure is in place already.

https://github.com/thmxv/blender-ocio%%%

%%%I think this is fantastic. However, given the migration path to OCIO I'd love to see this done without the hard coded sRGB LUT. Is it possible you have the ability to contribute to the OCIO migration David? Xavier was working on a branch at GitHub. Most of the infrastructure is in place already. https://github.com/thmxv/blender-ocio%%%

David M commented

2011-12-22 17:09:26 +01:00

%%%When/If OCIO is integrated all this would need to be replaced anyway. I agree, that would be nice but I also feel that it would be a
much larger project. This patch, as it stands, is rather simple and I think would be of great value for the meantime.

I haven't yet taken a closer look at that branch, so I might be overestimating the complexity of integrating OCIO.
I will look at it soon to see if I can help out in some way.
%%%

%%%When/If OCIO is integrated all this would need to be replaced anyway. I agree, that would be nice but I also feel that it would be a much larger project. This patch, as it stands, is rather simple and I think would be of great value for the meantime. I haven't yet taken a closer look at that branch, so I might be overestimating the complexity of integrating OCIO. I will look at it soon to see if I can help out in some way. %%%

David M commented

2012-01-06 22:51:33 +01:00

%%%Attached updated patch for current trunk.%%%

Troy Sobotka commented

2012-01-06 23:00:07 +01:00

%%%I am wondering if it might be possible to use a real LUT here to control chromacity in addition to simply gamma. It would allow one to use a properly calibrated display at D65 and get correct white at D50.%%%

%%%I am wondering if it might be possible to use a real LUT here to control chromacity in addition to simply gamma. It would allow one to use a properly calibrated display at [D65](https://archive.blender.org/developer/D65) and get correct white at [D50](https://archive.blender.org/developer/D50).%%%

Brecht Van Lommel commented

2012-01-08 14:57:37 +01:00

%%%Patch committed, thanks!

Did some minor code style changes, and fixed one issue with variable "initialized" not being initialized to 0.%%%

%%%Patch committed, thanks! Did some minor code style changes, and fixed one issue with variable "initialized" not being initialized to 0.%%%

Brecht Van Lommel commented

2012-01-08 14:57:39 +01:00

Changed status from 'Open' to: 'Archived'

Brecht Van Lommel closed this issue

2012-01-08 14:57:39 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Add fast linear light -> srgb conversion path #29309