Undo bug between shape keys *AFTER 2.67* #35170

New Issue

God Luna · 2013-05-01T09:54:16+02:00

God Luna commented

2013-05-01 09:54:16 +02:00

- Operating System, Graphics card ---

Win 7, Nvidia.

- Blender version with error, and version that worked ---

Bug found in the last vesrion (2.66a)

- Short description of error ---

Any change done in the Basis mesh, and later compiled in another shape key, get duplicated when undo it in the basis shape again.

- Steps for others to reproduce the error (preferably based on attached .blend file) ---

In the basic scene:
Create a shape key for the basic cube.
Move the cube 5 units to the right, in the basis shape.
Go to the new shape, the change was done here too. Normal behavior until there.
Back to the basis shape, undo the transformation. The cube move then 5 units to the left (back to the original position).
Now, in the new shape key, the cube has moved 5 units to the left over the original position, resulting in a inverse transformation to the left. The data of all shape keys will do the same.

NOTE: @ideasman42 I found these steps a bit ambiguous, listed more explicit steps below.

Default cube in default scene.
Add 2x shape keys.
In Shape Keys panel, Select "Basis" shape.
Enter edit-mode.
Press G, X, 5, Enter.
In Shape Keys panel, Click on "Key 1" shape (note that it has also been moved).
In Shape Keys panel, Click on "Basis" shape.
Undo to the point before transforming (Ctrl-Z, 3 times).
In Shape Keys panel, Click on "Key 1".
Notice the mesh has now moved 5x to the left.

- Operating System, Graphics card --- Win 7, Nvidia. - Blender version with error, and version that worked --- Bug found in the last vesrion (2.66a) - Short description of error --- Any change done in the Basis mesh, and later compiled in another shape key, get duplicated when undo it in the basis shape again. - Steps for others to reproduce the error (preferably based on attached .blend file) --- In the basic scene: Create a shape key for the basic cube. Move the cube 5 units to the right, in the basis shape. Go to the new shape, the change was done here too. Normal behavior until there. Back to the basis shape, undo the transformation. The cube move then 5 units to the left (back to the original position). Now, in the new shape key, the cube has moved 5 units to the left over the original position, resulting in a inverse transformation to the left. The data of all shape keys will do the same. ---- NOTE: @ideasman42 I found these steps a bit ambiguous, listed more explicit steps below. - Default cube in default scene. - Add 2x shape keys. - In Shape Keys panel, Select "Basis" shape. - Enter edit-mode. - Press G, X, 5, Enter. - In Shape Keys panel, Click on "Key 1" shape (note that it has also been moved). - In Shape Keys panel, Click on "Basis" shape. - Undo to the point before transforming (Ctrl-Z, 3 times). - In Shape Keys panel, Click on "Key 1". - Notice the mesh has now moved 5x to the left.

God Luna commented

2013-05-01 09:54:16 +02:00

Changed status to: 'Open'

God Luna commented

2013-05-01 09:56:58 +02:00

%%%Update: Sorry... the bug ocurrs when you move a face(s) in edit mode, no moving all the cube.%%%

God Luna commented

2013-05-01 10:09:30 +02:00

%%%Update 2: I have found that this only occurs when you create the base shape, create the new shape, THEN select the basis key and go then to edit mode. Move any face, change to the new shape (it's like the base vertex position of the shape is set then) and go back to the basis shape. Undo, back to the new shape and then the transform should be done twice.%%%

Sergey Sharybin commented

2013-05-01 15:10:45 +02:00

%%%Developer's note:
Root of the issue seems to be going to the fact undoMesh only stores-restored bmesh, but leaves mesh untouched. So when we're changing key block and hitting undo this happens:

When changing key block from and back to Basis, me->mvert corresponds to deformed cube (which is in our case 5 units away from the origin)
When hitting Undo, we're loading bmesh with non-deformed mesh, which is on the scene origin. This makes bmesh be 5 units away from me->mvert
When changing key block again or going out of edit node, offset propagation happens to the keyblocks. And at this point offset is 5 units in negative X direction, because of undo restored bmesh coords, but not mesh coords.

At least that's how i got it.

Undo after changing key block never was implemented in pre-bmesh blender, so perhaps for 2.67 safer change would be to free local mesh stack when changing key block, and full support of undo could either go to TODO or be solved after (supporting it would be nice, but there's also such limitation on curves/lattices..).

Campbell, your thoughts here?%%%

%%%Developer's note: Root of the issue seems to be going to the fact undoMesh only stores-restored bmesh, but leaves mesh untouched. So when we're changing key block and hitting undo this happens: - When changing key block from and back to Basis, me->mvert corresponds to deformed cube (which is in our case 5 units away from the origin) - When hitting Undo, we're loading bmesh with non-deformed mesh, which is on the scene origin. This makes bmesh be 5 units away from me->mvert - When changing key block again or going out of edit node, offset propagation happens to the keyblocks. And at this point offset is 5 units in negative X direction, because of undo restored bmesh coords, but not mesh coords. At least that's how i got it. Undo after changing key block never was implemented in pre-bmesh blender, so perhaps for 2.67 safer change would be to free local mesh stack when changing key block, and full support of undo could either go to TODO or be solved after (supporting it would be nice, but there's also such limitation on curves/lattices..). Campbell, your thoughts here?%%%

Thomas Dinges commented

2013-06-24 01:41:59 +02:00

%%%Any updates here? %%%

God Luna commented

2013-07-04 13:16:49 +02:00

%%%We NEED a update surely... It's a real butthache when i'm editing shape keys.... Is almost impossible to use the undo function when I have a lot of shape keys already created. Only a missclick, and all the shape keys get distorted, messed and un-sync with the basis.%%%

Bastien Montagne commented

2014-08-26 16:55:50 +02:00

Added subscriber: @mont29

Campbell Barton was unassigned by Bastien Montagne

2014-10-19 20:21:14 +02:00

Bastien Montagne self-assigned this 2014-10-19 20:21:14 +02:00

blender-admin commented

2014-11-17 11:19:54 +01:00

This issue was referenced by dab0bd9de6

This issue was referenced by dab0bd9de65a9be5e8ababba0e2799f994d5d12f

Bastien Montagne commented

2014-11-17 11:21:40 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2014-11-17 11:21:40 +01:00

Bastien Montagne commented

2014-11-17 11:21:40 +01:00

Closed by commit dab0bd9de6.

Closed by commit dab0bd9de6.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Undo bug between shape keys *AFTER 2.67* #35170

Undo bug between shape keys AFTER 2.67 #35170