Move default theme and keymap to python preset files #37585

New Issue

Brecht Van Lommel · 2013-11-22T19:37:05+01:00

Brecht Van Lommel commented

2013-11-22 19:37:05 +01:00

If other developers agree, this would make it quite a bit easier to change the defaults and keep the various themes and keymaps in sync when making changes, otherwise changes get made in one place but not the other.

It is a fairly big change so would like to get some feedback from other developers on this. Some notes:

If you add any operator with shortcut key, you now have to edit a python file (kind of already the case for menus anyway)
Some things like timers are in keymap as well now and are critical to Blender function. We can leave those either in C or move them out of keymaps, where they do not really belong in my opinion.
I need to look into how this affects startup performance.

If other developers agree, this would make it quite a bit easier to change the defaults and keep the various themes and keymaps in sync when making changes, otherwise changes get made in one place but not the other. It is a fairly big change so would like to get some feedback from other developers on this. Some notes: * If you add any operator with shortcut key, you now have to edit a python file (kind of already the case for menus anyway) * Some things like timers are in keymap as well now and are critical to Blender function. We can leave those either in C or move them out of keymaps, where they do not really belong in my opinion. * I need to look into how this affects startup performance.

Brecht Van Lommel commented

2013-11-22 19:37:05 +01:00

Changed status to: 'Open'

Brecht Van Lommel self-assigned this 2013-11-22 19:37:05 +01:00

Brecht Van Lommel commented

2013-11-22 19:37:05 +01:00

Added subscriber: @brecht

Jonathan Williamson commented

2013-11-22 19:39:56 +01:00

Added subscriber: @JonathanWilliamson

Jonathan Williamson commented

2013-11-24 20:12:36 +01:00

I'm going to wait on committing changes for #37419 until this one is completed or determined.

Scott Petrovic commented

2013-12-08 14:35:06 +01:00

Added subscriber: @scottyp

Scott Petrovic commented

2013-12-08 14:35:06 +01:00

This is a good idea. I didn't even know this information was stored twice.

Joshua Leung commented

2013-12-11 00:48:52 +01:00

Added subscriber: @JoshuaLeung

Joshua Leung commented

2013-12-11 00:48:52 +01:00

A few questions:

How will this affect things like version patching for theme files?
Will these keymap changes affect the "builtin" keymaps (i.e. those like ED_KEYMAP_FRAMES, ED_KEYMAP_UI, etc.)?
Does this cover other user preferences as well?
I'm curious what the startup performance impacts are :)

A few questions: 1) How will this affect things like version patching for theme files? 2) Will these keymap changes affect the "builtin" keymaps (i.e. those like ED_KEYMAP_FRAMES, ED_KEYMAP_UI, etc.)? 3) Does this cover other user preferences as well? 4) I'm curious what the startup performance impacts are :)

Brecht Van Lommel commented

2013-12-11 01:17:30 +01:00

How will this affect things like version patching for theme files?

You'd still need to do version patching when adding new theme colors.

Will these keymap changes affect the "builtin" keymaps (i.e. those like ED_KEYMAP_FRAMES, ED_KEYMAP_UI, etc.)?

I think so, as far as I know ED_KEYMAP_FRAMES and others are just convenient flags to add a named keymap like "Frames", and the flags can stay. I don't see a reason to give these special treatment.

Does this cover other user preferences as well?

No.

> How will this affect things like version patching for theme files? You'd still need to do version patching when adding new theme colors. > Will these keymap changes affect the "builtin" keymaps (i.e. those like ED_KEYMAP_FRAMES, ED_KEYMAP_UI, etc.)? I think so, as far as I know ED_KEYMAP_FRAMES and others are just convenient flags to add a named keymap like "Frames", and the flags can stay. I don't see a reason to give these special treatment. > Does this cover other user preferences as well? No.

DataDay commented

2013-12-13 21:54:05 +01:00

Added subscriber: @DataDay