In text editor, tabbing/untabbing affects an excess line #37613

New Issue

Konstantins Visnevskis · 2013-11-25T11:49:14+01:00

2013-11-25 11:49:14 +01:00

In text editor, when inserting tabs for multi-line selection, tab is added to last selected line even if there is no character selected on it.
Which is counter-intuitive, because every other action (delete, replace) works with selected lines only and breaks mnemonics of using every other text editor.

In text editor, when inserting tabs for multi-line selection, tab is added to last selected line even if there is no character selected on it. Which is counter-intuitive, because every other action (delete, replace) works with selected lines only and breaks mnemonics of using every other text editor.

Konstantins Visnevskis commented

2013-11-25 11:49:14 +01:00

Changed status to: 'Open'

Konstantins Visnevskis commented

2013-11-25 11:49:14 +01:00

Added subscriber: @KonstantinsVisnevskis

Dalai Felinto commented

2013-11-25 13:41:03 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2013-11-25 13:41:03 +01:00

Confirmed. Not only to the last line, but to all the empty or not lines

Konstantins Visnevskis commented

2013-11-25 13:52:37 +01:00

Empty newlines should be affected if they are inside selection, otherwise such tabbing will break python indentation flow.
Last line of selection on the other hand, if has no selected characters, usually is viewed as not selected (for good reasons).

Empty newlines should be affected if they are inside selection, otherwise such tabbing will break python indentation flow. Last line of selection on the other hand, if has no selected characters, usually is viewed as not selected (for good reasons).

Dalai Felinto commented

2013-11-25 14:09:08 +01:00

@kvig, not necessarily. I'm used to text editors that do not touch blank lines. Can you test the patch to see if it fixes it (and if it break or not python flow when there are blank lines inside the selection)

Konstantins Visnevskis commented

2013-11-25 14:32:18 +01:00

I'd be happy to test the patch if I'd know how to get a working version with it :)
You are right - non indented empty lines do not break Python flow. Still I'm sure most people would prefer to have those tabs in empty lines, not to have to put them manually when they decide to add code to that line. But that's a matter of preference rather than a bug, so I guess it's not for me to say :)

I'd be happy to test the patch if I'd know how to get a working version with it :) You are right - non indented empty lines do not break Python flow. Still I'm sure most people would prefer to have those tabs in empty lines, not to have to put them manually when they decide to add code to that line. But that's a matter of preference rather than a bug, so I guess it's not for me to say :)

Dalai Felinto commented

2013-11-25 14:35:05 +01:00

@KonstantinsVisnevskis the instructions are in the patch itself, see the D42 link above.
The easy way of applying the patch is with : arc patch D42

@KonstantinsVisnevskis the instructions are in the patch itself, see the [D42](https://archive.blender.org/developer/D42) link above. The easy way of applying the patch is with : arc patch [D42](https://archive.blender.org/developer/D42)

blender-admin commented

2013-11-26 07:51:06 +01:00

This issue was referenced by blender/blender-addons-contrib@a03aec3178

This issue was referenced by blender/blender-addons-contrib@a03aec3178ecf17c06a684e8ebd495364d74d23f

blender-admin commented

2013-11-26 07:51:06 +01:00

This issue was referenced by a03aec3178

This issue was referenced by a03aec3178ecf17c06a684e8ebd495364d74d23f

Dalai Felinto commented

2013-11-26 07:55:19 +01:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue