Hard crash when pressing backspace while mouse hovers over Editor-type button. #37795

New Issue

Andrew · 2013-12-12T20:58:11+01:00

Andrew commented

2013-12-12 20:58:11 +01:00

System Information
Ubuntu 12.04.3
Core i5 3320-m
HD4000
Nvidia NVS 5200m

Blender Version
Broken: Blender 2.68.0 r58536
Worked: unknown

Short description of error
Blender hard crashes in Scripting view when mouse is hovering over Editor-Type button and hitting backspace.

Exact steps for others to reproduce the error

Open Blender, reset to factory settings if necessary.
Change to Scripting view using "Choose Scene Layout" button
Move mouse cursor to "Editor type" button and hover.
- This bug doesn't appear in the 3d-view window, but seems to happen for others
Hit backspace while mouse is hovering over button. Blender hard-crashes.

This bug appears whether I use the Nvidia card (with optirun) or with the HD4000 graphics.

cat /tmp/blender.crash.txt

Blender 2.68 (sub 0), Revision: 58536

backtrace

blender() [0xf6ccd7]
blender() [0xf6cf15]
/lib/x86_64-linux-gnu/libc.so.6(+0x364a0) [0x7fdf4490f4a0]
blender(ED_render_scene_update+0xe1) [0x10be5d1]
blender(DAG_ids_check_recalc+0x6a) [0x15056ca]
blender(BKE_scene_update_tagged+0xb6) [0x149bdd6]
blender(wm_event_do_notifiers+0x494) [0xf86c04]
blender(WM_main+0x20) [0xf743e0]
blender(main+0x368) [0xf6f2c4]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed) [0x7fdf448fa76d]
blender() [0xeabf25]

**System Information** Ubuntu 12.04.3 Core i5 3320-m HD4000 Nvidia NVS 5200m **Blender Version** Broken: Blender 2.68.0 r58536 Worked: unknown **Short description of error** Blender hard crashes in Scripting view when mouse is hovering over Editor-Type button and hitting backspace. **Exact steps for others to reproduce the error** - Open Blender, reset to factory settings if necessary. - Change to Scripting view using "Choose Scene Layout" button - Move mouse cursor to "Editor type" button and hover. - This bug doesn't appear in the 3d-view window, but seems to happen for others - Hit backspace while mouse is hovering over button. Blender hard-crashes. This bug appears whether I use the Nvidia card (with optirun) or with the HD4000 graphics. > cat /tmp/blender.crash.txt # Blender 2.68 (sub 0), Revision: 58536 # backtrace blender() [0xf6ccd7] blender() [0xf6cf15] /lib/x86_64-linux-gnu/libc.so.6(+0x364a0) [0x7fdf4490f4a0] blender(ED_render_scene_update+0xe1) [0x10be5d1] blender(DAG_ids_check_recalc+0x6a) [0x15056ca] blender(BKE_scene_update_tagged+0xb6) [0x149bdd6] blender(wm_event_do_notifiers+0x494) [0xf86c04] blender(WM_main+0x20) [0xf743e0] blender(main+0x368) [0xf6f2c4] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed) [0x7fdf448fa76d] blender() [0xeabf25]

Andrew commented

2013-12-12 20:58:11 +01:00

Changed status to: 'Open'

Andrew commented

2013-12-12 20:58:11 +01:00

Added subscriber: @everyday

Bastien Montagne self-assigned this 2013-12-12 22:40:41 +01:00

Bastien Montagne commented

2013-12-12 23:02:29 +01:00

Added subscribers: @ideasman42, @brecht

Bastien Montagne commented

2013-12-12 23:02:30 +01:00

@brecht or @ideasman42 can you please validate this one-liner fix? tmp.diff

Issue is that in some rare cases, like that TypeEditor button, the region stored in but->active data after value has been reset is no more valid (does not always crash, but sanitizer always yells at interface_handler.c:5818). And I don’t think we need the redraw call here anyway, in all tests I made refresh happened without it (RNA handles this I guess)…

@brecht or @ideasman42 can you please validate this one-liner fix? [tmp.diff](https://archive.blender.org/developer/F39148/tmp.diff) Issue is that in some rare cases, like that TypeEditor button, the region stored in but->active data after value has been reset is no more valid (does not always crash, but sanitizer always yells at interface_handler.c:5818). And I don’t think we need the redraw call here anyway, in all tests I made refresh happened without it (RNA handles this I guess)…

Brecht Van Lommel commented

2013-12-12 23:16:59 +01:00

I don't think it can be assumed in general that the RNA callback is there to redraw the region, usually it would be but I'm not sure. For this particular case you can move ED_region_tag_redraw above ui_set_but_default and it should stop the crash.

Bastien Montagne commented

2013-12-12 23:17:56 +01:00

Ah, good hint, thx! :)

Bastien Montagne was unassigned by Campbell Barton

2013-12-13 08:07:12 +01:00

Campbell Barton self-assigned this 2013-12-13 08:07:12 +01:00

Campbell Barton commented

2013-12-13 08:07:12 +01:00

Added subscriber: @mont29

Campbell Barton commented

2013-12-13 08:07:12 +01:00

This is a tricky one, don't think a small change will work, the button is freed too and accessed later (the other crash is in code I added), so claiming this one, will see if freeing a button can be better supported.

Bastien Montagne commented

2013-12-13 18:14:47 +01:00

Yep, realized that later yesterday, that’s why I did not commit the fix…

Maybe we should try to use something similar to ui_apply_but_func() (comment here says: "these functions [i.e. apply funcs of the button] are postponed and only executed after all other handling is done, i.e. menus are closed, in order to avoid conflicts with these functions removing the buttons we are working with", seems pretty similar to that issue?).

Yep, realized that later yesterday, that’s why I did not commit the fix… Maybe we should try to use something similar to ui_apply_but_func() (comment here says: "these functions [i.e. apply funcs of the button] are postponed and only executed after all other handling is done, i.e. menus are closed, in order to avoid conflicts with these functions removing the buttons we are working with", seems pretty similar to that issue?).

Campbell Barton commented

2013-12-14 02:58:01 +01:00

The way most operator buttons work is to apply as an after-func. This button runs an operator immediately though.

I was thinking a fix could be to make the operator call happen after handling the event (but without having to make the button into an operator-button).

The way most operator buttons work is to apply as an after-func. This button runs an operator immediately though. I was thinking a fix could be to make the operator call happen after handling the event (but without having to make the button into an operator-button).

blender-admin commented

2013-12-19 15:07:09 +01:00

This issue was referenced by blender/blender-addons-contrib@aab587817c

This issue was referenced by blender/blender-addons-contrib@aab587817c55f5c53672efe3b1fc4a0e953cb97e

blender-admin commented

2013-12-19 15:07:09 +01:00

This issue was referenced by aab587817c

This issue was referenced by aab587817c55f5c53672efe3b1fc4a0e953cb97e

Campbell Barton commented

2013-12-19 15:07:58 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue