Missing checks for m_physicsController #37964

New Issue

Angus Hollands · 2013-12-27T17:31:13+01:00

Angus Hollands commented

2013-12-27 17:31:13 +01:00

I don't see the need for system information as the case of the bug is quite evident.

Some changes to the physics code in KX_GameObject missed the reason for defining SuspendDynamics and RestoreDynamics on the KX_GameObject. One must check that one has a physics controller before calling these methods.

I cannot easily provide a patch because I'm using a heavily modified distribution of Blender.
Assigning to Moguri.

I don't see the need for system information as the case of the bug is quite evident. Some changes to the physics code in KX_GameObject missed the reason for defining SuspendDynamics and RestoreDynamics on the KX_GameObject. One must check that one has a physics controller *before* calling these methods. I cannot easily provide a patch because I'm using a heavily modified distribution of Blender. Assigning to Moguri.

Angus Hollands commented

2013-12-27 17:31:13 +01:00

Changed status to: 'Open'

Mitchell Stokes was assigned by Angus Hollands

2013-12-27 17:31:13 +01:00

Angus Hollands commented

2013-12-27 17:31:13 +01:00

Added subscriber: @AngusHollands-4

Mitchell Stokes commented

2014-01-21 20:09:30 +01:00

Could you at least state which functions are missing checks?

Angus Hollands commented

2014-01-21 20:12:18 +01:00

It is the stated functions in the game object source file. They used to call suspend on the object which checked for a physics controller and then suspended the object

Angus Hollands commented

2014-01-21 20:13:24 +01:00

It is the stated functions in the game object source file. They used to call suspend on the object which checked for a physics controller and then suspended the object

Mitchell Stokes commented

2014-01-21 21:09:44 +01:00

It looks like PySuspendDynamics() and PyRestoreDynamics() in KX_GameObject are the only ones not performing a check. All other uses of PHY_IPhysicsController::Restore/SuspendDynamics() appear to be properly guarded.

It looks like PySuspend/RestoreDynamics() should instead call KX_GameObject::Resume/Suspend(). Does this line up with your findings?

It looks like PySuspendDynamics() and PyRestoreDynamics() in KX_GameObject are the only ones not performing a check. All other uses of PHY_IPhysicsController::Restore/SuspendDynamics() appear to be properly guarded. It looks like PySuspend/RestoreDynamics() should instead call KX_GameObject::Resume/Suspend(). Does this line up with your findings?

blender-admin commented

2014-02-14 22:17:51 +01:00

This issue was referenced by blender/blender-addons-contrib@f3c7cb02b2

This issue was referenced by blender/blender-addons-contrib@f3c7cb02b2a5e7b7ee780b598a73b08bf39dae76

blender-admin commented

2014-02-14 22:17:51 +01:00

This issue was referenced by f3c7cb02b2

This issue was referenced by f3c7cb02b2a5e7b7ee780b598a73b08bf39dae76

Mitchell Stokes commented

2014-02-14 22:18:48 +01:00

Changed status from 'Open' to: 'Resolved'

Mitchell Stokes closed this issue