Crash on transforming UVs #38109

Closed
opened 2014-01-07 22:19:08 +01:00 by Daniel Salazar · 18 comments
Member

System Information

openSUSE 12.3 64bits
NVIDIA 480GTX SC

Blender Version

Broken: Blender 2.69.7 e369a5c

Short description of error

Crash on transforming UVs

Exact steps for others to reproduce the error

  • Open CrashUVs.blend
  • Go to UV editor
  • Press S and move mouse a bit
  • If it doesn't crash right away press R and move mouse a bit
**System Information** openSUSE 12.3 64bits NVIDIA 480GTX SC **Blender Version** Broken: Blender 2.69.7 e369a5c **Short description of error** Crash on transforming UVs **Exact steps for others to reproduce the error** * Open [CrashUVs.blend](https://archive.blender.org/developer/F63522/CrashUVs.blend) * Go to UV editor * Press S and move mouse a bit * If it doesn't crash right away press R and move mouse a bit
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscriber: @zanqdo

Added subscriber: @zanqdo

Added subscriber: @brecht

Added subscriber: @brecht

I couldn't reproduce this crash, with latest Git or e369a5c on OS X.

I couldn't reproduce this crash, with latest Git or e369a5c on OS X.
Author
Member

I was kinda expecting that. It sometimes takes some effort. Anyway gonna do a debug build

I was kinda expecting that. It sometimes takes some effort. Anyway gonna do a debug build
Author
Member

Here's the backtrace: http://www.pasteall.org/48555

Here's the backtrace: http://www.pasteall.org/48555

Added subscriber: @Sergey

Added subscriber: @Sergey

Might be related to threaded updates, maybe @Sergey has a clue from this backtrace, I don't see an obvious cause. Valgrind or hellgrind might be able to find an error here as well.

Might be related to threaded updates, maybe @Sergey has a clue from this backtrace, I don't see an obvious cause. Valgrind or hellgrind might be able to find an error here as well.
Author
Member

@brecht ok maybe you can help me get a valgrind bt on irc?

@brecht ok maybe you can help me get a valgrind bt on irc?

You just run valgrind ./blender and it prints error messages. It may be that some tweaks are needed if it prints too many false positives, but I don't know the commands off hand, would need to boot into linux but then I can run valgrind myself anyway.

You just run `valgrind ./blender` and it prints error messages. It may be that some tweaks are needed if it prints too many false positives, but I don't know the commands off hand, would need to boot into linux but then I can run valgrind myself anyway.
Author
Member

Valgrind is impossible here.. takes minutes to open startup file with hundreds of errors, and then It just freezes opening the file :(

Valgrind is impossible here.. takes minutes to open startup file with hundreds of errors, and then It just freezes opening the file :(

Added subscriber: @mont29

Added subscriber: @mont29

Here is a session with asan (both asan output and some gdb investigations): tmp.txt. Looks like there is some weird stuff happening at alloc time (the origindex_edge is only two ints-length), so smells indeed threading issue…

Here is a session with asan (both asan output and some gdb investigations): [tmp.txt](https://archive.blender.org/developer/F68858/tmp.txt). Looks like there is some weird stuff happening at alloc time (the origindex_edge is only two ints-length), so smells indeed threading issue…
Sergey Sharybin self-assigned this 2014-01-15 14:08:50 +01:00

Added subscriber: @ideasman42

Added subscriber: @ideasman42

This is indeed a threading issue caused by some modifiers modifying original mesh's MVerts by assigning ME_VERT_TMP_TAG. Working on this atm, but would need to talk to @ideasman42 about way to go with this.

This is indeed a threading issue caused by some modifiers modifying original mesh's MVerts by assigning ME_VERT_TMP_TAG. Working on this atm, but would need to talk to @ideasman42 about way to go with this.

Correction, only solidify uses this tag, which is not so bad. Here's the quick fix for the issue: http://www.pasteall.org/48745/diff

It adds extra array alloction, but on the one hand it's not so bad perhaps since there're some more arrays being allocated there. Possible ways to improve:

  • Keep the same array allocation, but pack tags into bits. Would make allocation 8x smaller
  • Try somehow re-using old_vert_arr array by storing tag there as well using some magic constant value (-1 i.e.)

@ideasman42, your call.

Correction, only solidify uses this tag, which is not so bad. Here's the quick fix for the issue: http://www.pasteall.org/48745/diff It adds extra array alloction, but on the one hand it's not so bad perhaps since there're some more arrays being allocated there. Possible ways to improve: * Keep the same array allocation, but pack tags into bits. Would make allocation 8x smaller * Try somehow re-using `old_vert_arr` array by storing tag there as well using some magic constant value (-1 i.e.) @ideasman42, your call.

Changed status from 'Open' to: 'Duplicate'

Changed status from 'Open' to: 'Duplicate'

✘ Merged into #38116.

✘ Merged into #38116.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#38109
No description provided.