Undo/Redo don't work properly with Text Insert Mode in Text Editor #38264

New Issue

Paulo José Oliveira Amaro · 2014-01-17T14:43:01+01:00

2014-01-17 14:43:01 +01:00

System Information
Ubuntu 13.10 32-bit
Intel Ironlake Mobile x86/MMX/SSE

Blender Version
Broken: 2.69.8 8aaf4aa

Short description of error
In Text Editor, the actions of undo or redo a previous text created with Text Insert Mode enabled (key INS), don't work properly, letting the text unrecoverable.

Exact steps for others to reproduce the error
lease, see this video. Look how each redo or undo action is immediately undone by the following one, making impossible to recover or redo the text properly.
bug-text-editor.avi

**System Information** Ubuntu 13.10 32-bit Intel Ironlake Mobile x86/MMX/SSE **Blender Version** Broken: 2.69.8 8aaf4aa **Short description of error** In Text Editor, the actions of undo or redo a previous text created with Text Insert Mode enabled (key INS), don't work properly, letting the text unrecoverable. **Exact steps for others to reproduce the error** lease, see this video. Look how each redo or undo action is immediately undone by the following one, making impossible to recover or redo the text properly. [bug-text-editor.avi](https://archive.blender.org/developer/F69678/bug-text-editor.avi)

Paulo José Oliveira Amaro commented

2014-01-17 14:43:01 +01:00

Changed status to: 'Open'

Paulo José Oliveira Amaro commented

2014-01-17 14:43:01 +01:00

Added subscriber: @PauloJoseOliveiraAmaro

Brecht Van Lommel commented

2014-01-20 19:16:56 +01:00

Added subscribers: @dail, @ideasman42, @brecht

Brecht Van Lommel commented

2014-01-20 19:16:56 +01:00

I had a quick look at this but don't understand the code here well. @ideasman42 or @dail, do either of you want to take this one?

Personally I wouldn't mind if we just removed this insert key functionality entirely, it seems such an outdated thing, but maybe some people still use it.

I had a quick look at this but don't understand the code here well. @ideasman42 or @dail, do either of you want to take this one? Personally I wouldn't mind if we just removed this insert key functionality entirely, it seems such an outdated thing, but maybe some people still use it.

Justin Dailey commented

2014-01-20 21:58:29 +01:00

Hi @brecht,

Here is fix for this. I know I have commit access to the repo but haven't looked into setting up arc or dealing with keys yet. So feel free to commit this. Thanks! :)

Hi @brecht, Here is fix for this. I know I have commit access to the repo but haven't looked into setting up arc or dealing with keys yet. So feel free to commit this. Thanks! :)

blender-admin commented

2014-01-20 22:13:42 +01:00

This issue was referenced by blender/blender-addons-contrib@7c6f60572b

This issue was referenced by blender/blender-addons-contrib@7c6f60572b24ef80abc6a64932791eba8d21ba2a

blender-admin commented

2014-01-20 22:13:42 +01:00

This issue was referenced by 7c6f60572b

This issue was referenced by 7c6f60572b24ef80abc6a64932791eba8d21ba2a

Justin Dailey commented

2014-01-20 22:15:11 +01:00

Changed status from 'Open' to: 'Resolved'

Justin Dailey closed this issue

2014-01-20 22:15:11 +01:00

Justin Dailey commented

2014-01-20 22:15:11 +01:00

Closed by commit 7c6f60572b.

Closed by commit 7c6f60572b.

Brecht Van Lommel commented

2014-01-20 22:15:30 +01:00

Thanks, committed now.

You don't need arc to commit by the way, it's just a more convenient way to do code reviews, but you would need to set up SSH keys for git.

Thanks, committed now. You don't need arc to commit by the way, it's just a more convenient way to do code reviews, but you would need to set up SSH keys for git.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Undo/Redo don't work properly with Text Insert Mode in Text Editor #38264