Animation playback is not synchronized when Screen Layout changes #38467

New Issue

Paulo José Oliveira Amaro · 2014-02-03T23:07:52+01:00

2014-02-03 23:07:52 +01:00

System Information
Ubuntu 13.10 32-bit
Intel Ironlake Mobile x86/MMX/SSE

Blender Version
2.69.10 f70d966

Short description of error
The UI don't update correctly when animation is playing and the Screen Layout is changed. The UI animation indicators are not correct and the animation controls don't work properly.

Exact steps for others to reproduce the error
Very easy to reproduce:

Start new file and play animation with button or CTRL+A;
Change the Screen Layout to "Animation". The interface is not updated and CTRL+A or interface buttons don't stop the animation.

Another way to check this:

Add a sound strip to Video Sequencer.
Then change the layout while playing animation and try to stop the animation. The sound will continue to play until you try to stop the animation again.

A last note: If you start to play animation in two layouts at the same time, the same problem will happen if you try to stop the animation in one of then. In the another layout it will keep to playing incorrectly.

**System Information** Ubuntu 13.10 32-bit Intel Ironlake Mobile x86/MMX/SSE **Blender Version** 2.69.10 f70d966 **Short description of error** The UI don't update correctly when animation is playing and the Screen Layout is changed. The UI animation indicators are not correct and the animation controls don't work properly. **Exact steps for others to reproduce the error** Very easy to reproduce: 1. Start new file and play animation with button or CTRL+A; 2. Change the Screen Layout to "Animation". The interface is not updated and CTRL+A or interface buttons don't stop the animation. Another way to check this: 1. Add a sound strip to Video Sequencer. 2. Then change the layout while playing animation and try to stop the animation. The sound will continue to play until you try to stop the animation again. A last note: If you start to play animation in two layouts at the same time, the same problem will happen if you try to stop the animation in one of then. In the another layout it will keep to playing incorrectly.

Paulo José Oliveira Amaro commented

2014-02-03 23:07:52 +01:00

Changed status to: 'Open'

Paulo José Oliveira Amaro commented

2014-02-03 23:07:52 +01:00

Added subscriber: @PauloJoseOliveiraAmaro

Thomas Dinges commented

2014-02-06 22:46:27 +01:00

Added subscriber: @ThomasDinges

Thomas Dinges commented

2014-02-06 22:46:27 +01:00

I observer something else here on Mac OS, after switching to the "animation" screen layout, the playback stops. Pressing ALT+A again and it starts to playback again,

Joshua Leung commented

2014-02-07 10:58:45 +01:00

Added subscriber: @JoshuaLeung

Joshua Leung commented

2014-02-07 10:58:45 +01:00

IIRC, the temporary data for animation playback - settings + timer - are actually stored on a per-screen basis. While this is perhaps related to Ton's dream/plan to make it possible to have different windows playing back independently of each other at some point, it can lead to various weird situations like the one described here.

Perhaps we should move to storing this stuff in wmWindowManager instead of bScreen. I'm not sure it's such a great idea to mix this sort of thing in with the windowmanager module (since it's kindof lower-level than the Screens/UI elements stuff). Then again, wm_event_do_handlers() already has to have special handling for sound playback and performing depsgraph+eval system updates...

IIRC, the temporary data for animation playback - settings + timer - are actually stored on a per-screen basis. While this is perhaps related to Ton's dream/plan to make it possible to have different windows playing back independently of each other at some point, it can lead to various weird situations like the one described here. Perhaps we should move to storing this stuff in wmWindowManager instead of bScreen. I'm not sure it's such a great idea to mix this sort of thing in with the windowmanager module (since it's kindof lower-level than the Screens/UI elements stuff). Then again, wm_event_do_handlers() already has to have special handling for sound playback and performing depsgraph+eval system updates...

Sergey Sharybin commented

2014-02-17 09:25:20 +01:00

Added subscribers: @brecht, @Sergey

Sergey Sharybin commented

2014-02-17 09:25:20 +01:00

I wouldn't want this to be moved. We're actually moving towards separate states for windows and such a change would be a step backwards actually. But perhaps user feedback could be improved here.

@brecht, any thoughts here?

I wouldn't want this to be moved. We're actually moving towards separate states for windows and such a change would be a step backwards actually. But perhaps user feedback could be improved here. @brecht, any thoughts here?

Brecht Van Lommel commented

2014-02-17 12:29:30 +01:00

We can keep it in the screen for later, but need to ensure only one screen s playing at a time, and stopping (or transferring) playback when switching screens.

Bastien Montagne commented

2014-02-27 22:14:16 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2014-02-27 22:14:16 +01:00

This simple patch seems to work as expected... Not quite sure a mere copy of animtimer between screens is a correct way to do it, though!

P17: source/blender/editors/screen/screen_edit.c

diff --git a/source/blender/editors/screen/screen_edit.c b/source/blender/editors/screen/screen_edit.c
index 86e7839..66fa578 100644
--- a/source/blender/editors/screen/screen_edit.c
+++ b/source/blender/editors/screen/screen_edit.c
@@ -1518,8 +1518,17 @@ void ED_screen_set(bContext *C, bScreen *sc)
                        WM_event_timer_sleep(wm, win, wt, true);
                
                ED_screen_exit(C, win, oldscreen);
-               oldscreen->animtimer = wt;
-               
+
+               /* Same scene, "transfer" playback to new screen. */
+               if (oldscene == sc->scene) {
+                       sc->animtimer = wt;
+               }
+               /* Else, stop playback. */
+               else {
+                       oldscreen->animtimer = wt;
+                       ED_screen_animation_play(C, 0, 0);
+               }
+
                win->screen = sc;
                CTX_wm_window_set(C, win);  // stores C->wm.screen... hrmf

This simple patch **seems** to work as expected... Not quite sure a mere copy of animtimer between screens is a correct way to do it, though! [P17: source/blender/editors/screen/screen_edit.c](https://archive.blender.org/developer/P17.txt) ``` diff --git a/source/blender/editors/screen/screen_edit.c b/source/blender/editors/screen/screen_edit.c index 86e7839..66fa578 100644 --- a/source/blender/editors/screen/screen_edit.c +++ b/source/blender/editors/screen/screen_edit.c @@ -1518,8 +1518,17 @@ void ED_screen_set(bContext *C, bScreen *sc) WM_event_timer_sleep(wm, win, wt, true); ED_screen_exit(C, win, oldscreen); - oldscreen->animtimer = wt; - + + /* Same scene, "transfer" playback to new screen. */ + if (oldscene == sc->scene) { + sc->animtimer = wt; + } + /* Else, stop playback. */ + else { + oldscreen->animtimer = wt; + ED_screen_animation_play(C, 0, 0); + } + win->screen = sc; CTX_wm_window_set(C, win); // stores C->wm.screen... hrmf ```

Brecht Van Lommel commented

2014-02-27 22:23:21 +01:00

Looks good to me.

I can't see anything in wmTimer that binds it to any screen specifically, only to the window which stays the same. And animtimer seems to be the only variable in bScreen affected by animation playback, so that seems ok too.

Looks good to me. I can't see anything in wmTimer that binds it to any screen specifically, only to the window which stays the same. And animtimer seems to be the only variable in bScreen affected by animation playback, so that seems ok too.

Bastien Montagne self-assigned this 2014-02-28 10:02:21 +01:00

blender-admin commented

2014-02-28 10:04:57 +01:00

This issue was referenced by blender/blender-addons-contrib@d2a5ea04ed

This issue was referenced by blender/blender-addons-contrib@d2a5ea04ed8448865b4daa21c0010727eee118ba

blender-admin commented

2014-02-28 10:04:57 +01:00

This issue was referenced by d2a5ea04ed

This issue was referenced by d2a5ea04ed8448865b4daa21c0010727eee118ba

Bastien Montagne commented

2014-02-28 10:06:42 +01:00

Changed status from 'Open' to: 'Resolved'