Opening an image with 'relative path' selected, gets absolute path. #38808

New Issue

Jasper van Nieuwenhuizen · 2014-02-24T14:25:49+01:00

Jasper van Nieuwenhuizen commented

2014-02-24 14:25:49 +01:00

System Information
OS X 10.8.5 (12F45)
NVIDIA GeForce GT 650M 1024 MB

Blender Version
8d023c1
Broken: 2.69.11 8d023c1
Worked: 2.69.0 r60991

Short description of error
If you open an image and check the option 'relative path' it returns the absolute path.

Exact steps for others to reproduce the error

Open Blender.
Save the file.
Open an image (as texture, in the UV/Image Editor, in the Compositor, it doesn't seem to matter) and check the option 'relative path'.
The path of the image is absolute, not relative.

It seems like the error is in 'bpy.ops.image.open()'. If you have opened an image in the UV/Image Editor and after that use the browse button under 'source' ('bpy.ops.buttons.file_browse()') it does return the relative path.

**System Information** OS X 10.8.5 (12F45) NVIDIA GeForce GT 650M 1024 MB **Blender Version** 8d023c1 Broken: 2.69.11 8d023c1 Worked: 2.69.0 r60991 **Short description of error** If you open an image and check the option 'relative path' it returns the absolute path. **Exact steps for others to reproduce the error** 1. Open Blender. 2. Save the file. 3. Open an image (as texture, in the UV/Image Editor, in the Compositor, it doesn't seem to matter) and check the option 'relative path'. 4. The path of the image is absolute, not relative. It seems like the error is in 'bpy.ops.image.open()'. If you have opened an image in the UV/Image Editor and after that use the browse button under 'source' ('bpy.ops.buttons.file_browse()') it does return the relative path.

Jasper van Nieuwenhuizen commented

2014-02-24 14:25:49 +01:00

Changed status to: 'Open'

Jasper van Nieuwenhuizen commented

2014-02-24 14:25:49 +01:00

Added subscriber: @jasperge-2

Campbell Barton self-assigned this 2014-02-24 14:46:13 +01:00

Dalai Felinto commented

2014-02-24 23:37:40 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2014-02-24 23:37:40 +01:00

confirmed on OSX

Dalai Felinto commented

2014-02-25 00:09:47 +01:00

It seems that even in 2.69 opening an image via script would always set the path to be absolute.
For example:

bpy.ops.image.open(filepath="/Users/dfelinto/blender/bugs/grid.tif", relative_path=True)
print bpy.data.images['grid.tif'].filepath.startswith("//"))

It seems that even in 2.69 opening an image via script would always set the path to be absolute. For example: ``` bpy.ops.image.open(filepath="/Users/dfelinto/blender/bugs/grid.tif", relative_path=True) print bpy.data.images['grid.tif'].filepath.startswith("//")) ```

blender-admin commented

2014-02-25 01:09:08 +01:00

This issue was referenced by blender/blender-addons-contrib@b6bb6d1b2c

This issue was referenced by blender/blender-addons-contrib@b6bb6d1b2c6f16c3c325242d15ef6d65d40f1a74

blender-admin commented

2014-02-25 01:09:08 +01:00

This issue was referenced by b6bb6d1b2c

This issue was referenced by b6bb6d1b2c6f16c3c325242d15ef6d65d40f1a74

Dalai Felinto commented

2014-02-25 01:09:29 +01:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2014-02-25 01:09:29 +01:00

Dalai Felinto commented

2014-02-25 01:09:29 +01:00

Closed by commit b6bb6d1b2c.

Closed by commit b6bb6d1b2c.

Sebastian Koenig commented

2015-02-17 10:17:09 +01:00

Added subscriber: @sebastian_k

Sebastian Koenig commented

2015-02-17 10:17:09 +01:00

It seems this error came back somehow.
I am getting the exact same broken behavior in 2.73.8 (86a2e9d).
Here's a sample folder with image and blendfile. Notice the image is loaded with relative path. However, if i open the same image with alt+o or the open image button, it gets an absolut path, even though the relative path checkbox is activated.
rel_path.zip

It seems this error came back somehow. I am getting the exact same broken behavior in 2.73.8 (86a2e9d). Here's a sample folder with image and blendfile. Notice the image is loaded with relative path. However, if i open the same image with alt+o or the open image button, it gets an absolut path, even though the relative path checkbox is activated. [rel_path.zip](https://archive.blender.org/developer/F144144/rel_path.zip)

Sebastian Koenig commented

2015-02-17 10:18:42 +01:00

Changed status from 'Resolved' to: 'Open'

Sebastian Koenig reopened this issue

2015-02-17 10:18:42 +01:00

Jasper van Nieuwenhuizen commented

2015-02-17 10:30:44 +01:00

Hmm, it seems there are some strange things going on. If I open your test file, I indeed have the error. But if I open another image, it does have a relative path. Also with other files. If I completely remove the image (shift + click on the X), save the file and re-open, I can also open the image with relative path.

Blender version 2.73.8 (cdc1dab)

Hmm, it seems there are some strange things going on. If I open your test file, I indeed have the error. But if I open another image, it *does* have a relative path. Also with other files. If I completely remove the image (shift + click on the X), save the file and re-open, I can also open the image with relative path. Blender version 2.73.8 (cdc1dab)

jens verwiebe commented

2015-02-17 13:28:05 +01:00

Added subscriber: @jensverwiebe

jens verwiebe commented

2015-02-17 13:28:05 +01:00

I found it.
The cause of the problem is in image_ops.c line 1090:

	/* only image path after save, never ibuf */
	if (is_relative_path) {
		if (!exists) {
			BLI_path_rel(ima->name, bmain->name);
		}
	}

Either the !exist must be changesd or we need an extra test. But this way the path for
an existing file would never be changed, a new file will !

I think we can/should remove the "!exists" test.

Cambo ?

Jens

I found it. The cause of the problem is in image_ops.c line 1090: ``` /* only image path after save, never ibuf */ if (is_relative_path) { if (!exists) { BLI_path_rel(ima->name, bmain->name); } } ``` Either the !exist must be changesd or we need an extra test. But this way the path for an existing file would never be changed, a new file will ! I think we can/should remove the "!exists" test. Cambo ? Jens

Campbell Barton commented

2015-02-17 20:19:36 +01:00

The logic for exists is:

If you have an image loaded, use the existing image
If you have an existing image, don't manipulate its path. (assume this is already set as the user desired).

This came from the observation that dragging and dropping an image, could modify its path.

However as @sebastian_k noticed, re-opening same image makes path absolute, fixing.

The logic for `exists` is: - If you have an image loaded, use the existing image - If you have an existing image, don't manipulate its path. (assume this is already set as the user desired). This came from the observation that dragging and dropping an image, could modify its path. ---- However as @sebastian_k noticed, re-opening same image makes path absolute, fixing.

blender-admin commented

2015-02-17 20:39:28 +01:00

This issue was referenced by 5115e86246

This issue was referenced by 5115e862460203c5e31bb5d62acc3fda2b0cc2bd

Campbell Barton commented

2015-02-17 20:40:24 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2015-02-17 20:40:24 +01:00

Campbell Barton commented

2015-02-17 20:40:24 +01:00

Closed by commit 5115e86246.

Closed by commit 5115e86246.

Sebastian Koenig commented

2015-02-18 12:05:39 +01:00

I still find this a bit fuzzy.
The checkbox for relative/absolute is available still, so as a user I would expect that it works. Especially because in all image related buttons in Cycles the textbox to change the source path is not available, only from inside the image editor.

I still find this a bit fuzzy. The checkbox for relative/absolute is available still, so as a user I would expect that it works. Especially because in all image related buttons in Cycles the textbox to change the source path is not available, only from inside the image editor.

Campbell Barton commented

2015-02-19 03:34:50 +01:00

@sebastian_k, it is awkward.

The issue with using existing data its already used elsewhere & IMHO opening an image really shouldn't modify existing loaded data.

We could have a notification when loading an image "Info: Using existing image", Then at least the user know whats going on, it could even notify that the existing image has different relative setting.

If they want to change paths then - they can select the image and change the paths.

@sebastian_k, it is awkward. The issue with using existing data its already used elsewhere & IMHO opening an image really shouldn't modify existing loaded data. We could have a notification when loading an image *"Info: Using existing image"*, Then at least the user know whats going on, it could even notify that the existing image has different relative setting. If they want to change paths then - they can select the image and change the paths.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Opening an image with 'relative path' selected, gets absolute path. #38808