Add Vector tests for bl_pyapi_mathutils.py #39451

New Issue

Campbell Barton · 2014-03-27T05:22:48+01:00

Campbell Barton commented

2014-03-27 05:22:48 +01:00

Blender has a tests file for the mathutils module.

Execute this from Blenders source code directory:

 blender --background -noaudio --python source/tests/bl_pyapi_mathutils.py

This is a simple example of testing in Python and currently all tests pass,

BUT: We miss tests for mathutils.Vector

See: http://www.blender.org/documentation/blender_python_api_2_70_release/mathutils.html#mathutils.Vector

Possible tests..

Vector.project()
Vector.reflect()
Vector.angle()
Vector.angle_signed()
Vector.rotation_difference()

As well as testing for success, its useful to test that zero length vectors give correct exceptions with angle measurement and incomparable args fail properly.,

Vectors sized 4+ are now supported but not used by many functions which rely on 2d or 3d vectors only, so ensuring large vectors dont fail is important too.

This is more of a beginner testing task since you can use existing tests as a reference.

Note, for extra points, heres a crash that could have been found with testing.
06b6cd8345 Vector.cross on vectors sized >4

Blender has a tests file for the `mathutils` module. Execute this from Blenders source code directory: ``` blender --background -noaudio --python source/tests/bl_pyapi_mathutils.py ``` This is a simple example of testing in Python and currently **all tests pass**, BUT: We miss tests for `mathutils.Vector` See: http://www.blender.org/documentation/blender_python_api_2_70_release/mathutils.html#mathutils.Vector Possible tests.. - Vector.project() - Vector.reflect() - Vector.angle() - Vector.angle_signed() - Vector.rotation_difference() As well as testing for success, its useful to test that zero length vectors give correct exceptions with angle measurement and incomparable args fail properly., Vectors sized 4+ are now supported but not used by many functions which rely on 2d or 3d vectors only, so ensuring large vectors dont fail is important too. This is more of a beginner testing task since you can use existing tests as a reference. ---- Note, for extra points, heres a crash that could have been found with testing. 06b6cd8345 `Vector.cross` on vectors sized >4

Campbell Barton commented

2014-03-27 05:22:48 +01:00

Changed status to: 'Open'

Campbell Barton commented

2014-03-27 05:22:48 +01:00

Added subscriber: @ideasman42

Patrice Bertrand commented

2014-03-27 09:28:46 +01:00

Added subscriber: @PatriceBertrand

Patrice Bertrand commented

2014-03-27 09:28:46 +01:00

I'll take this one.

Campbell Barton commented

2014-03-27 22:44:16 +01:00

@PatriceBertrand, great, there was a crash in Vector.cross - details linked above, would be nice to make sure new tests would find a crash like this.

@PatriceBertrand, great, there was a crash in `Vector.cross` - details linked above, would be nice to make sure new tests would find a crash like this.

Patrice Bertrand commented

2014-03-28 09:55:18 +01:00

Hello,
I created diff D433 with 20 something tests for Vector functions.

A few comments and questions:

I use the console to find out the expected results. I do not check whether the result is actually correct, it will just be "same as in 2.70".
Could easily add another 20 on these functions, if these are going in the right direction.
Question: should we inspect the actual BLI_math.c so as to determine relevant use cases, such as a special branch if vector is zero ?

Hello, I created diff [D433](https://archive.blender.org/developer/D433) with 20 something tests for Vector functions. A few comments and questions: - I use the console to find out the expected results. I do not check whether the result is actually correct, it will just be "same as in 2.70". - Could easily add another 20 on these functions, if these are going in the right direction. - Question: should we inspect the actual BLI_math.c so as to determine relevant use cases, such as a special branch if vector is zero ?

Campbell Barton commented

2014-03-28 12:13:48 +01:00

@PatriceBertrand - thanks for the diff,

For each function we could try have 3 functions...

regular case
irregular/degenerate case
error case (in fact we could have more then one error case. but to begin with...)

However I wouldn't do this for all functions right now. maybe focus on say, 6 or so (the ones I proposed in the initial list), get this reviewed and approved, then do the others after.

@PatriceBertrand - thanks for the diff, For each function we could try have 3 functions... - regular case - irregular/degenerate case - error case (in fact we could have more then one error case. but to begin with...) However I **wouldn't** do this for all functions right now. maybe focus on say, 6 or so (the ones I proposed in the initial list), get this reviewed and approved, then do the others after.

Bastien Montagne commented

2014-04-11 18:07:43 +02:00

Added subscriber: @mont29

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Add Vector tests for bl_pyapi_mathutils.py #39451