Simplify subprocess calls an remove deprecated uses of os.popen #40415

New Issue

Lawrence D'Oliveiro · 2014-05-29T03:48:52+02:00

2014-05-29 03:48:52 +02:00

This patch replaces calls to os.popen, which is now deprecated, with uses of the subprocess module. It also uses the check_output and check_call functions, which are simpler and will automatically raise error exceptions, in place of various more long-winded calls to subprocess.Popen. This does necessitate explicit checking for CalledProcessError in one place; let me know if this can occur in other places.

subprocess-checks.patch

This patch replaces calls to os.popen, which is now deprecated, with uses of the subprocess module. It also uses the check_output and check_call functions, which are simpler and will automatically raise error exceptions, in place of various more long-winded calls to subprocess.Popen. This does necessitate explicit checking for CalledProcessError in one place; let me know if this can occur in other places. [subprocess-checks.patch](https://archive.blender.org/developer/F91787/subprocess-checks.patch)

Lawrence D'Oliveiro commented

2014-05-29 03:48:52 +02:00

Changed status to: 'Open'

Lawrence D'Oliveiro commented

2014-05-29 03:48:52 +02:00

Added subscriber: @ldo

Bastien Montagne self-assigned this 2014-05-29 10:32:00 +02:00

Bastien Montagne commented

2014-05-29 10:32:00 +02:00

Would wait for after 2.71 release for this patch, more risky than hypot one imho. ;)

Bastien Montagne commented

2014-06-16 15:27:26 +02:00

Added subscriber: @ideasman42

Bastien Montagne commented

2014-06-16 15:27:26 +02:00

Campbell, I’d rather have your advice on this patch before I commit it, since it affects mostly our scons build system (which I do not use)… Changes look OK to me, and scons did build OK, though. :)

Reattaching updated patch, changes in man part are no more needed. subprocess-checks_2.patch

Campbell, I’d rather have your advice on this patch before I commit it, since it affects mostly our scons build system (which I do not use)… Changes look OK to me, and scons did build OK, though. :) Reattaching updated patch, changes in man part are no more needed. [subprocess-checks_2.patch](https://archive.blender.org/developer/F94448/subprocess-checks_2.patch)

Campbell Barton commented

2014-06-19 18:16:46 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2014-06-19 18:16:46 +02:00

Campbell Barton commented

2014-06-19 18:16:46 +02:00

Committed 2dce13d213

Committed 2dce13d213

Campbell Barton commented

2014-06-20 07:10:55 +02:00

Note, there was an issue with wm.py exceptional handling, (was checking OSError), otherwise the patch was fine.