mesh normals in cycles.xml and embedded (texture) files #40773

New Issue

Patrick Rosendahl · 2014-06-23T15:06:45+02:00

Patrick Rosendahl commented

2014-06-23 15:06:45 +02:00

Hi,
this patch adds vertex-normals to the polymesh and an option to embed files. Embedded_files will be hex-decoded and written to disk (if not already there), so they are available as textures. This enables users to create monolithic render files.
Rgds,
Patrick
mesh_normals_embedded_file.txt

Hi, this patch adds vertex-normals to the polymesh and an option to embed files. Embedded_files will be hex-decoded and written to disk (if not already there), so they are available as textures. This enables users to create monolithic render files. Rgds, Patrick [mesh_normals_embedded_file.txt](https://archive.blender.org/developer/F95353/mesh_normals_embedded_file.txt)

Patrick Rosendahl commented

2014-06-23 15:06:45 +02:00

Changed status to: 'Open'

Patrick Rosendahl commented

2014-06-23 15:06:45 +02:00

Added subscriber: @PRosendahl

Bastien Montagne commented

2014-06-23 15:46:50 +02:00

Added subscribers: @ThomasDinges, @Sergey, @brecht, @mont29

Fábio Santos commented

2014-07-07 23:37:30 +02:00

Added subscriber: @fabio-1

Fábio Santos commented

2014-07-07 23:37:30 +02:00

I don't understand why these must be written to disk. Textures are loaded into RAM anyway, are they not?

Patrick Rosendahl commented

2014-07-08 00:39:40 +02:00

The process is a bit more complicated. They are loaded into RAM when the scene is constructed. Until then they are just a reference to a file.

There is a mechanism to preload textures as "builtin". But that involves callbacks for parameters and the actual pixels. So it was easier to dump them to disk.

As said above, the render file is monolithic. But once loaded into Cycles, it dumps out the texture files into the same directory.
I find this procedure OK, but anyone can object to this.

The process is a bit more complicated. They are loaded into RAM when the scene is constructed. Until then they are just a reference to a file. There is a mechanism to preload textures as "builtin". But that involves callbacks for parameters and the actual pixels. So it was easier to dump them to disk. As said above, _the render file is monolithic_. But once loaded into Cycles, it dumps out the texture files into the same directory. I find this procedure OK, but anyone can object to this.

Sergey Sharybin commented

2014-07-09 09:20:37 +02:00

Adding vertex normals sounds fine, but it still needs some cleanup:

Follow the style used all over in Cycles, don't mix your own style in there.
Dead code is rather forbidden.

Embedded file support i'm really skeptical about. XML format used by Cycles was never meant to be used as an interchange container. If we want to do it, we need to go away from pure XML and do stuff more like .blend (why not simply to use .blend anyway?).

If others will be fine with such a thing, i'd still really suggest using the same stuff as used for embedded files and movies in blender_session.cpp. Would avoid creating files out of the control actually.

Adding vertex normals sounds fine, but it still needs some cleanup: - Follow the style used all over in Cycles, don't mix your own style in there. - Dead code is rather forbidden. Embedded file support i'm really skeptical about. XML format used by Cycles was never meant to be used as an interchange container. If we want to do it, we need to go away from pure XML and do stuff more like .blend (why not simply to use .blend anyway?). If others will be fine with such a thing, i'd still really suggest using the same stuff as used for embedded files and movies in blender_session.cpp. Would avoid creating files out of the control actually.

Patrick Rosendahl commented

2014-07-09 12:23:04 +02:00

OK, please close this task.

Sergey Sharybin commented

2014-07-10 21:39:13 +02:00

It seems there may be some misunderstanding, will ask about this offline.

Patrick Rosendahl commented

2014-07-10 21:50:01 +02:00

I'm trying to team up with @fabio-1 , he's working on the XML exporter that I did not know of before.
I think it makes sense to put everything together - no need for a plethora of separate patches.
Unfortunately there is no way to contact him via blender dev, so I sent him an invite to contact me on BA.
MAYBE you can create that contact.

About using .blend - think of 3rd party programs... There is no .blend-library.
XML is perfect for a quick-hack export (we did that for ZW3D). Contact me at BA and I send you a link of what we've archieved.

I'm trying to team up with @fabio-1 , he's working on the XML exporter that I did not know of before. I think it makes sense to put everything together - no need for a plethora of separate patches. Unfortunately there is no way to contact him via blender dev, so I sent him an invite to contact me on BA. _MAYBE_ you can create that contact. About using .blend - think of 3rd party programs... There is no .blend-library. XML is perfect for a quick-hack export (we did that for ZW3D). Contact me at BA and I send you a link of what we've archieved.

Sergey Sharybin commented

2014-07-10 21:57:53 +02:00

Here's the thing. Normals support is almost there, and could go to git real soon IMO. In this respect it kind of makes sense to separate the patches.

As for contacting @fabio-1, why not just start a ML discussion in bf-cycles mailing list to gather all interested people together. Perhaps he's also in that list.

EDIT: Eeh, forgot to mention. .blend was just one of the possible ideas. Just in practice binary formats works MUCH better than ASCII ones. Also, wouldn't mind if someone finally makes .blend file reader library :)

Here's the thing. Normals support is almost there, and could go to git real soon IMO. In this respect it kind of makes sense to separate the patches. As for contacting @fabio-1, why not just start a ML discussion in bf-cycles mailing list to gather all interested people together. Perhaps he's also in that list. EDIT: Eeh, forgot to mention. .blend was just one of the possible ideas. Just in practice binary formats works MUCH better than ASCII ones. Also, wouldn't mind if someone finally makes .blend file reader library :)

Patrick Rosendahl commented

2014-07-10 22:10:19 +02:00

Sure, if I had the time. Unfortunately not the case, but I am willing to help yall.

For completeness sake UV should be added as well but I didnt find any sample code that I could copy/paste (like for normals). That and meshes are somewhat complete. Anyone?

And I'd like to see XML export to clipboard instead of that "operator" thingy in the materials editor. That way, people can copy/paste stuff to/from text, and easily share materials. "Groups" (with custom in/output) are missing, but I have an vague idea how to embed that into XML.

Sure, if I had the time. Unfortunately not the case, but I am willing to help yall. For completeness sake UV should be added as well but I didnt find any sample code that I could copy/paste (like for normals). That and meshes are somewhat complete. _Anyone_? And I'd like to see XML export to clipboard instead of that "operator" thingy in the materials editor. That way, people can copy/paste stuff to/from text, and easily share materials. "Groups" (with custom in/output) are missing, but I have an vague idea how to embed that into XML.

Fábio Santos commented

2014-07-10 22:18:13 +02:00

I'm right here :) I'm new to the community so I don't know what's the usual method, but a task for this would be nice. I'm working on improving the exporter in github here: https://github.com/fabiosantoscode/cycles-xml-exporter . you can post issues there or pull request, and collaborate like that.

As to improving the format itself, I'm not so comfortable with c++ as I am with python but I can do small things like changing the syntax for node links (the current is pretty suboptimal).

I'm also on the blendercoders irc channel, at times.

I've contacted you on BA, @PRosendalhl, my user there is fabiodan.

I'm right here :) I'm new to the community so I don't know what's the usual method, but a task for this would be nice. I'm working on improving the exporter in github here: https://github.com/fabiosantoscode/cycles-xml-exporter . you can post issues there or pull request, and collaborate like that. As to improving the format itself, I'm not so comfortable with c++ as I am with python but I can do small things like changing the syntax for node links (the current <connect from="nodename socketname" to="nodename socketname"> is pretty suboptimal). I'm also on the blendercoders irc channel, at times. I've contacted you on BA, @PRosendalhl, my user there is fabiodan.

Aaron Carlisle commented

2015-09-10 15:57:17 +02:00

Added subscriber: @Blendify

Aaron Carlisle commented

2015-09-10 15:57:17 +02:00

whats the status on this?

Aaron Carlisle commented

2017-05-24 19:10:27 +02:00

Removed subscriber: @Blendify

Dalai Felinto commented

2019-12-23 18:43:55 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2019-12-23 18:43:55 +01:00

Changed status from 'Confirmed' to: 'Archived'

Dalai Felinto closed this issue

2019-12-23 18:43:55 +01:00

Dalai Felinto self-assigned this 2019-12-23 18:43:55 +01:00

Dalai Felinto commented

2019-12-23 18:43:55 +01:00

Hi, thanks for your patch.

We are undergoing a Tracker Curfew where we are automatically closing old patches.

If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.

Hi, thanks for your patch. We are undergoing a [Tracker Curfew ](https://code.blender.org/?p=3861) where we are automatically closing old patches. If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

mesh normals in cycles.xml and embedded (texture) files #40773