"copy to selected" doens't work for all attributes #41062
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#41062
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Windows 7
Blender Version
Blender 2.71
In video sequencer there are a few attributes that inexplicably have the option 'copy to selected' greyed out,even though they look like it should work. I don't know for sure if this ever worked,or if it's broken by design.
The attributes in question are 'image offset" and "image crop".
Also modifiers can't be copied,though this might not be a bug. But maybe it should be considered as well,as it would be a useful addition.
Copy to selected is an important function to make working in the sequencer less of a hassle ,and thus should work on every attribute that is not a global setting.
Tahnk you for looking into this.
Kind regards
Changed status to: 'Open'
Added subscriber: @Bollebib
extra info
The toggles of image crop and image offset DO work,but not their numerical settings. Maybe because having sub-options is the reason why this does not work.
Added subscriber: @mont29
Added subscriber: @Sergey
For me Image Offset and Image Crop works just fine. Please provide .blend which demonstrates the issue.
As for modifiers copy, it's just a missing feature, not considered a bug.
Savetoselected.blend
added the blend.
I do want to repeat: the TOGGLES of the offset and crop are fine,those do get copied,but their values ( X and Y,top ,left,bottom,right ) are not.
For the modifiers ,I kind of expected that,but it maybe should be considered.
(do I have to change priority to 'needs triage" again btw? not sure what the guidelines are)
So, was a bit more difficult than expected, but here is a patch that enables that feature for those settings:
P88: #41062
Main issue was, these properties are in a sub-RNA struct, not directly in RNA_Sequence one, and since sequences' ID is the scene itself, we could not use current 'from ID' fallback used for objects.
Now, we are looping back in structs’ hierarchy to try to find a RNA_Sequence one, and give a 'relative' path from those. Seems to work pretty well, just not sure about performances issues here…
Sergey, what do you think? Maybe ask Campbell's advice too?
Added subscriber: @ideasman42
Campbell, we need your advice on this one…
Great job, mont29
I hope this will get into the next release?
Or do you still need campbellbarton's feedback?
@mont29
This patch makes code more complex in way thats not easy for me to reason about, for example - there is a recursive loop on properties, but I cant validate it works right with any sequencer options...
Are you sure a loop is even needed here? - the property resolving functions will get a path back to the ID in one step, so AFAICS loops not needed.
So general feedback...
Theres a large block of code under:
Thats only used for sequencer props. 2x suggestions...
if (GS(id->name) == ID_SCE) {
So updated patch:
P117: T41062_02.diff
Third attempt, from discussion with Campbell on IRC (try to avoid as much string manipulation as possible):
P118: T41062_03.diff
Updated P120: Fork of P118 T41062_04.diff
RNA_PathElement
->PropertyElemRNA
: so it doesn't follow RNA_Struct naming conventions and look like a type.r_***
prefix for return args.This issue was referenced by
5336e68e11
Changed status from 'Open' to: 'Resolved'
Closed by commit
5336e68e11
.