Infinite Zoom #42506

New Issue

Aaron Carlisle · 2014-11-05T18:52:56+01:00

Aaron Carlisle commented

2014-11-05 18:52:56 +01:00

System Information
Windows 8.0 and intel graphics 4600

Blender Version
Broken: 2.72b (9e963ae)
Worked: (optional)

Short description of error
Within the sequencer in preview allows you to zoom forever
creating a very jagged result witch is not needed the super large pixels is more then good

Exact steps for others to reproduce the error

Place a image strip in the sequencer
Go to the preview and zoom in and keep zoom after you get the huge pixels

**System Information** Windows 8.0 and intel graphics 4600 **Blender Version** Broken: 2.72b (9e963ae) Worked: (optional) **Short description of error** Within the sequencer in preview allows you to zoom forever creating a very jagged result witch is not needed the super large pixels is more then good **Exact steps for others to reproduce the error** 1. Place a image strip in the sequencer 2. Go to the preview and zoom in and keep zoom after you get the huge pixels

Aaron Carlisle commented

2014-11-05 18:52:56 +01:00

Changed status to: 'Open'

Aaron Carlisle commented

2014-11-05 18:52:56 +01:00

Added subscriber: @Blendify

Aaron Carlisle commented

2014-11-05 19:23:49 +01:00

Removed subscriber: @Blendify

Aaron Carlisle commented

2014-11-05 19:23:57 +01:00

Added subscriber: @Blendify

Jonata Bolzan was assigned by Aaron Carlisle

2014-11-05 19:25:14 +01:00

Aaron Carlisle commented

2014-11-05 21:03:07 +01:00

Here Is a image of what will happen

and you can zoom in more then that

Here Is a image of what will happen ![Capture.JPG](https://archive.blender.org/developer/F122138/Capture.JPG) and you can zoom in more then that

Jonata Bolzan was unassigned by Aaron Carlisle

2014-11-05 21:14:13 +01:00

Ton Roosendaal was assigned by Aaron Carlisle

2014-11-05 21:14:13 +01:00

Aaron Carlisle commented

2014-11-05 21:14:13 +01:00

Added subscriber: @jonata

Ton Roosendaal was unassigned by Aaron Carlisle

2014-11-05 21:15:24 +01:00

Jonata Bolzan was assigned by Aaron Carlisle

2014-11-05 21:15:24 +01:00

Aaron Carlisle commented

2014-11-05 21:15:24 +01:00

Added subscriber: @Ton

Julian Eisel commented

2014-11-06 00:46:55 +01:00

Changed status from 'Open' to: 'Archived'

Julian Eisel closed this issue

2014-11-06 00:46:55 +01:00

Julian Eisel commented

2014-11-06 00:46:55 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2014-11-06 00:46:55 +01:00

Hey @Blendify,
I don't see a need for a fix here. Having no limits isn't a bad thing mostly ;).

Furthermore, I'd like to adress a couple of things in this report:

If you don't really know the active Blender developers and who's responsible for which part of Blender, don't assign bugs by yourself. Especially, you shouldn't assign bugs to Ton, as he currently isn't able to code for Blender or fix Bugs at all, there are other people doing this. I'm also not sure why you reassigned it to jonata, who doesn't seem to be an active Developer fixing Bugs (if you've talked to him previously and he offered himself to look into this it's okay, though)
You shouldn't add projects on your own (also, as long as you don't really know what you're doing).
Just follow the guide here and let us do the rest. "You do your half of the work, then we do our half!", that's the deal.
That's already it. so, please make sure to don't do the things stated above the next time.

But nevertheless, thanks for the report @Blendify, but no real bug here :)

Hey @Blendify, I don't see a need for a fix here. Having no limits isn't a bad thing mostly ;). Furthermore, I'd like to adress a couple of things in this report: * If you don't really know the active Blender developers and who's responsible for which part of Blender, don't assign bugs by yourself. Especially, you shouldn't assign bugs to Ton, as he currently isn't able to code for Blender or fix Bugs at all, there are other people doing this. I'm also not sure why you reassigned it to jonata, who doesn't seem to be an active Developer fixing Bugs (if you've talked to him previously and he offered himself to look into this it's okay, though) * You shouldn't add projects on your own (also, as long as you don't really know what you're doing). Just follow the guide [here ](https://developer.blender.org/maniphest/task/create/?project=2&type=Bug) and let us do the rest. "You do your half of the work, then we do our half!", that's the deal. That's already it. so, please make sure to don't do the things stated above the next time. But nevertheless, thanks for the report @Blendify, but no real bug here :)

Jonata Bolzan commented

2014-11-06 01:25:00 +01:00

Hello. I am not an active developer, I am just a user who sends bugs and bothers the developers a bit :D

Aaron Carlisle commented

2014-11-06 04:10:13 +01:00

hey sorry this is my first bug report
a couple of things one the bug
it only happened in the sequencer, not in the image editor, and you can zoom in for hour then spend the same time amount of time undoing it. i did not confirm this however it will turn to the color of the background.

hey sorry this is my first bug report a couple of things one the bug it only happened in the sequencer, not in the image editor, and you can zoom in for hour then spend the same time amount of time undoing it. i did not confirm this however it will turn to the color of the background.

Aaron Carlisle commented

2014-11-06 04:10:41 +01:00

Changed status from 'Archived' to: 'Open'

Aaron Carlisle reopened this issue

2014-11-06 04:10:41 +01:00

Campbell Barton commented

2014-11-06 09:32:05 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2014-11-06 09:32:05 +01:00

Note: seems that sequencer limits aren't enforced:

This change however only applies to newly created spaces, needs a do-versions too to update existing files.

P159: possible fix for #42506

diff --git a/source/blender/editors/space_sequencer/space_sequencer.c b/source/blender/editors/space_sequencer/space_sequencer.c
index c0cfaed..f97344f 100644
--- a/source/blender/editors/space_sequencer/space_sequencer.c
+++ b/source/blender/editors/space_sequencer/space_sequencer.c
@@ -144,7 +144,7 @@ static SpaceLink *sequencer_new(const bContext *C)
 	ar->alignment = RGN_ALIGN_TOP;
 	ar->flag |= RGN_FLAG_HIDDEN;
 	/* for now, aspect ratio should be maintained, and zoom is clamped within sane default limits */
-	ar->v2d.keepzoom = V2D_KEEPASPECT | V2D_KEEPZOOM;
+	ar->v2d.keepzoom = V2D_KEEPASPECT | V2D_KEEPZOOM | V2D_LIMITZOOM;
 	ar->v2d.minzoom = 0.00001f;
 	ar->v2d.maxzoom = 100000.0f;
 	ar->v2d.tot.xmin = -960.0f; /* 1920 width centered */

Note: seems that sequencer limits aren't enforced: This change however only applies to newly created spaces, needs a do-versions too to update existing files. [P159: possible fix for #42506](https://archive.blender.org/developer/P159.txt) ```diff diff --git a/source/blender/editors/space_sequencer/space_sequencer.c b/source/blender/editors/space_sequencer/space_sequencer.c index c0cfaed..f97344f 100644 --- a/source/blender/editors/space_sequencer/space_sequencer.c +++ b/source/blender/editors/space_sequencer/space_sequencer.c @@ -144,7 +144,7 @@ static SpaceLink *sequencer_new(const bContext *C) ar->alignment = RGN_ALIGN_TOP; ar->flag |= RGN_FLAG_HIDDEN; /* for now, aspect ratio should be maintained, and zoom is clamped within sane default limits */ - ar->v2d.keepzoom = V2D_KEEPASPECT | V2D_KEEPZOOM; + ar->v2d.keepzoom = V2D_KEEPASPECT | V2D_KEEPZOOM | V2D_LIMITZOOM; ar->v2d.minzoom = 0.00001f; ar->v2d.maxzoom = 100000.0f; ar->v2d.tot.xmin = -960.0f; /* 1920 width centered */ ```

Jonata Bolzan was unassigned by Julian Eisel

2014-11-06 10:04:14 +01:00

Julian Eisel self-assigned this 2014-11-06 10:04:14 +01:00

Julian Eisel commented

2014-11-06 10:04:14 +01:00

Okay, should be an easy fix. Can have a look at it later.

Campbell Barton commented

2014-11-06 11:36:31 +01:00

This could be set as todo, its not really much of a problem

be sure to check this fix works for split-screen preview too.

This could be set as todo, its not really much of a problem be sure to check this fix works for split-screen preview too.

Aaron Carlisle commented

2014-11-06 20:52:37 +01:00

I don't no exactly how this "bit" of code works but make sure that it will apply itself to the other previews such as the Vetro-Scope waveform and histogram.

Campbell Barton commented

2014-11-10 17:31:14 +01:00

Setting as todo, this isn't really preventing anyone from using the zoom operator.

Julian Eisel removed their assignment 2014-11-11 23:32:16 +01:00

Campbell Barton commented

2014-11-14 14:26:31 +01:00

Don't think this is a quick hack, its a very small change but needs to be done carefully and test with file versioning.

Campbell Barton commented

2014-11-14 14:27:02 +01:00

Removed subscriber: @Ton

Antonis Ryakiotakis was assigned by Aaron Carlisle

2015-02-06 17:23:09 +01:00

Aaron Carlisle commented

2015-02-06 17:23:09 +01:00

May be gooseberry can fix this

blender-admin commented

2015-02-26 14:27:33 +01:00

This issue was referenced by 13c275ce84

This issue was referenced by 13c275ce8477c94d53b3799c28b48011b59db2fb

Antonis Ryakiotakis commented

2015-02-26 14:28:09 +01:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2015-02-26 14:28:09 +01:00

Antonis Ryakiotakis commented

2015-02-26 14:28:09 +01:00

Closed by commit 13c275ce84.

Closed by commit 13c275ce84.

Aaron Carlisle commented

2015-03-04 20:16:37 +01:00

Changed status from 'Resolved' to: 'Open'

Aaron Carlisle reopened this issue

2015-03-04 20:16:37 +01:00

Aaron Carlisle commented

2015-03-04 20:16:37 +01:00

This is fixed 25%

see picture

(Nota Bene: This Picture is of two pixels next to each other zoomed to really far)

The zoom limits should be somewhere like that of the image editor

This is fixed 25% see picture ![screen.png](https://archive.blender.org/developer/F147301/screen.png) (Nota Bene: This Picture is of two pixels next to each other zoomed to really far) The zoom limits should be somewhere like that of the image editor

Antonis Ryakiotakis commented

2015-03-05 19:06:31 +01:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2015-03-05 19:06:31 +01:00

Antonis Ryakiotakis commented

2015-03-05 19:06:31 +01:00

Limits should be more sane now.