Hiding/unhiding NLA strip doesn't update the 3D viewport [PATCH INCLUDED] #42697

New Issue

inactive account · 2014-11-23T12:02:17+01:00

inactive account commented

2014-11-23 12:02:17 +01:00

System Information
Ubuntu Linux 14.10, GeForce GTX 970

Blender Version
Broken: 2.72b, also tested on b9d9df9810

Short description of error
Hiding or unhiding an NLA strip doesn't update the 3D viewport.

Exact steps for others to reproduce the error

Open the attached blend file nla_aligning.blend
Place mouse cursor in the NLA editor
Press [H]
See that the armature in the 3D view doesn't change position.
Move the scene one frame forward and back again to update the 3D viewport.
See that the armature is now in a different position than in step 4.

The attached patch 0002-NLA-Fix-Hiding-unhiding-NLA-strip-doesn-t-update-the.patch sends a notification that the scene has been updated, fixing this issue.

**System Information** Ubuntu Linux 14.10, GeForce GTX 970 **Blender Version** Broken: 2.72b, also tested on b9d9df9810c6b66584b36186876e9da08709c84a **Short description of error** Hiding or unhiding an NLA strip doesn't update the 3D viewport. **Exact steps for others to reproduce the error** 1. Open the attached blend file [nla_aligning.blend](https://archive.blender.org/developer/F125517/nla_aligning.blend) 2. Place mouse cursor in the NLA editor 3. Press [H] 4. See that the armature in the 3D view doesn't change position. 5. Move the scene one frame forward and back again to update the 3D viewport. 6. See that the armature is now in a different position than in step 4. The attached patch [0002-NLA-Fix-Hiding-unhiding-NLA-strip-doesn-t-update-the.patch](https://archive.blender.org/developer/F125518/0002-NLA-Fix-Hiding-unhiding-NLA-strip-doesn-t-update-the.patch) sends a notification that the scene has been updated, fixing this issue.

inactive account commented

2014-11-23 12:02:17 +01:00

Changed status to: 'Open'

inactive account commented

2014-11-23 12:02:17 +01:00

Added subscriber: @sybrenstuvel

inactive account commented

2014-11-23 12:08:33 +01:00

PS: Another way to solve this would be to let the 3D viewport listen to the NC_ANIMATION | ND_NLA | NA_EDITED notifications that are already being sent out. If that is preferred, please let me know and I'll send in another patch that does this.

PS: Another way to solve this would be to let the 3D viewport listen to the `NC_ANIMATION | ND_NLA | NA_EDITED` notifications that are already being sent out. If that is preferred, please let me know and I'll send in another patch that does this.

inactive account commented

2014-11-23 13:50:16 +01:00

Note that, because of this code in wm_event_system.c function wm_event_do_notifiers around line 290:

		if (note->window == win ||
		    (note->window == NULL && (note->reference == NULL || note->reference == win->screen->scene)))
		{
			if (note->category == NC_SCENE) {
				if (note->data == ND_FRAME)
					do_anim = true;
			}
		}

we need to send NC_SCENE | ND_FRAME; without it, animation data isn't updated properly. We could also update wm_event_do_notifiers to set do_anim=true in other cases, for example when the category is NC_ANIMATION. That would actually be my preferred solution, but I don't know what would break/horribly slow down as a result.

Note that, because of this code in wm_event_system.c function `wm_event_do_notifiers` around line 290: if (note->window == win || (note->window == NULL && (note->reference == NULL || note->reference == win->screen->scene))) { if (note->category == NC_SCENE) { if (note->data == ND_FRAME) do_anim = true; } } we need to send `NC_SCENE | ND_FRAME`; without it, animation data isn't updated properly. We could also update `wm_event_do_notifiers` to set `do_anim=true` in other cases, for example when the category is `NC_ANIMATION`. That would actually be my preferred solution, but I don't know what would break/horribly slow down as a result.

Julian Eisel commented

2014-11-24 19:00:58 +01:00

Added subscribers: @ideasman42, @JulianEisel

Julian Eisel commented

2014-11-24 19:00:58 +01:00

Hey @sybrenstuvel,
thanks for the report, the patch and the research. The patch works fine for me.

@ideasman42, would you mind checking the patch?

Hey @sybrenstuvel, thanks for the report, the patch and the research. The patch works fine for me. @ideasman42, would you mind checking the patch?

Joshua Leung was assigned by Sergey Sharybin

2014-11-25 14:32:54 +01:00

Sergey Sharybin commented

2014-11-25 14:32:54 +01:00

Added subscribers: @JoshuaLeung, @Sergey

Sergey Sharybin commented

2014-11-25 14:32:54 +01:00

NLA is more @JoshuaLeung's area.

The patch doesn't seems to be correct tho, you're forcing all the animation to be evaluated. Think you need to tag the particular animation to be evaluated instead. @JoshuaLeung, am i right here?

NLA is more @JoshuaLeung's area. The patch doesn't seems to be correct tho, you're forcing all the animation to be evaluated. Think you need to tag the particular animation to be evaluated instead. @JoshuaLeung, am i right here?

inactive account commented

2014-11-25 16:20:47 +01:00

@Sergey: The NC_ANIMATION notification was already in the Blender source. If I should change the NULL in that line to something else, that's fine, but it's a different issue than what I intended to fix with this patch.

@Sergey: The `NC_ANIMATION` notification was already in the Blender source. If I should change the `NULL` in that line to something else, that's fine, but it's a different issue than what I intended to fix with this patch.

Sergey Sharybin commented

2014-11-25 18:41:20 +01:00

You shouldn't send NC_SCENE | ND_FRAME notifier unless the frame actually changes.

You shouldn't send `NC_SCENE | ND_FRAME` notifier unless the frame actually changes.

inactive account commented

2014-11-25 18:45:41 +01:00

Good point, I'll update the patch to check that the (un)hidden NLA strip contains the current frame.

inactive account commented

2014-11-25 20:04:07 +01:00

Updated patch: 0003-NLA-Fix-Hiding-unhiding-NLA-strip-doesn-t-update-the.patch

Updated patch: [0003-NLA-Fix-Hiding-unhiding-NLA-strip-doesn-t-update-the.patch](https://archive.blender.org/developer/F126606/0003-NLA-Fix-Hiding-unhiding-NLA-strip-doesn-t-update-the.patch)

blender-admin commented

2014-12-05 02:14:50 +01:00

This issue was referenced by e93990dfc5

This issue was referenced by e93990dfc5a8482c7e0b9b1c4d64ec8ec8095f65

Joshua Leung commented

2014-12-05 02:16:16 +01:00

Changed status from 'Open' to: 'Resolved'

Joshua Leung closed this issue

2014-12-05 02:16:16 +01:00

Joshua Leung commented

2014-12-05 02:16:16 +01:00

Closed by commit e93990dfc5.

Closed by commit e93990dfc5.

Joshua Leung commented

2014-12-05 02:22:06 +01:00

I've just committed an alternative fix to master. As mentioned by Sergey, NC_SCENE | ND_FRAME should only be sent when the frame actually changes (i.e. when your operator changes the current frame). For animation channels, we have another mechanism (albeit only around for about 2-3 releases) which is better to use for such cases.

Anyways, thanks for your efforts in tracking down and providing a patch for this, even if we didn't ultimately use it :)

I've just committed an alternative fix to master. As mentioned by Sergey, `NC_SCENE | ND_FRAME` should only be sent when the frame actually changes (i.e. when your operator changes the current frame). For animation channels, we have another mechanism (albeit only around for about 2-3 releases) which is better to use for such cases. Anyways, thanks for your efforts in tracking down and providing a patch for this, even if we didn't ultimately use it :)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Hiding/unhiding NLA strip doesn't update the 3D viewport [PATCH INCLUDED] #42697