Sampling differences between Path and Branched integrators #42815

Closed
opened 2014-12-06 08:05:28 +01:00 by Matt Heimlich · 8 comments

System Information
Win7 64-bit

Blender Version
Broken: c8995ec

Short description of error
Branched tracing and normal tracing give different results for the same number of samples taken

Exact steps for others to reproduce the error
Open file, switch between integrators. The difference is visible after only a single sample.

branchedDifferences.blend

**System Information** Win7 64-bit **Blender Version** Broken: c8995ec **Short description of error** Branched tracing and normal tracing give different results for the same number of samples taken **Exact steps for others to reproduce the error** Open file, switch between integrators. The difference is visible after only a single sample. [branchedDifferences.blend](https://archive.blender.org/developer/F129740/branchedDifferences.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @MatthewHeimlich

Added subscriber: @MatthewHeimlich

Added subscriber: @FloridaJo

Added subscriber: @FloridaJo

The devs can probably speak more to this, but
if they were the same I would think we wouldn't need to
include two separate algorithms for rendering.
I would expect they're going to give two different results.

The devs can probably speak more to this, but if they were the same I would think we wouldn't need to include two separate algorithms for rendering. I would expect they're going to give two different results.
Member

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Julian Eisel self-assigned this 2014-12-06 15:43:33 +01:00
Member

Of course two different algorithms means two different results. So everything works as expexcted.

Thanks for the report @MatthewHeimlich, but (luckily) no bug here :)

Of course two different algorithms means two different results. So everything works as expexcted. Thanks for the report @MatthewHeimlich, but (luckily) no bug here :)
Author

I'm going to argue against that. In theory (as I understand it) the branched tracer taking one sample of all ray types should provide the same exact result as the regular path tracer taking a single sample. Changes should only occur (again, at least in theory) when more samples are given to individual ray types. As you can see, a single sample in the BPT does not equal a single sample in the standard tracer, and is in fact apparently much more efficient, which would imply that there are some improvements to be done to the sampling in the progressive sampler. I'm happy to be corrected by someone familiar with the actual cause though.

I'm going to argue against that. In theory (as I understand it) the branched tracer taking one sample of all ray types should provide the same exact result as the regular path tracer taking a single sample. Changes should only occur (again, at least in theory) when more samples are given to individual ray types. As you can see, a single sample in the BPT does not equal a single sample in the standard tracer, and is in fact apparently much more efficient, which would imply that there are some improvements to be done to the sampling in the progressive sampler. I'm happy to be corrected by someone familiar with the actual cause though.
Author

I found where the disconnect is. The standard path tracer cannot sample all lights per sample, which causes the discontinuity in the results. So I guess this falls more into a feature request than a bug. Sorry for the confusion!

I found where the disconnect is. The standard path tracer cannot sample all lights per sample, which causes the discontinuity in the results. So I guess this falls more into a feature request than a bug. Sorry for the confusion!
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#42815
No description provided.