Group objects disappear after appending #43337

New Issue

Karja Krähwald · 2015-01-21T04:14:26+01:00

Karja Krähwald commented

2015-01-21 04:14:26 +01:00

System Information
Windows 7 64, GTX 980

Blender Version
Broken: 2.6 (unsure), 2.70 - b4d8fb5 (2.73 release), a1f4821

Short description of error
Group objects who are used as a Custom Bone Shape 2 or more times
will disappear after appending their group to a new file, regardless of any other usage.

Exact steps for others to reproduce the error
GroupAppendBug.blend

Steps:

Add a Cube.
Add an Armature.
- Create 2 Bones.
- Use Cube as Custom Bone Shape for both Bones.
Assign all objects to a Group.
Open a new file and append this Group

Problem: Cube (object) isnt appended correctly and dont show up in your new file - only mesh data is appended.

All objects that have used Cube for any purpose (mirror-target/constraints/etc) will now refer to a hidden object.
And of course Cubes individual settings like constraints or modifiers are lost as well.

**System Information** Windows 7 64, GTX 980 **Blender Version** Broken: 2.6 (unsure), 2.70 - b4d8fb5 (2.73 release), a1f4821 **Short description of error** Group objects who are used as a Custom Bone Shape 2 or more times will disappear after appending their group to a new file, regardless of any other usage. **Exact steps for others to reproduce the error** [GroupAppendBug.blend](https://archive.blender.org/developer/F138503/GroupAppendBug.blend) >Steps: - Add a Cube. - Add an Armature. - Create 2 Bones. - Use Cube as Custom Bone Shape for both Bones. - Assign all objects to a Group. - Open a new file and append this Group >Problem: Cube (object) isnt appended correctly and dont show up in your new file - only mesh data is appended. All objects that have used Cube for any purpose (mirror-target/constraints/etc) will now refer to a hidden object. And of course Cubes individual settings like constraints or modifiers are lost as well.

Karja Krähwald commented

2015-01-21 04:14:27 +01:00

Changed status to: 'Open'

Karja Krähwald commented

2015-01-21 04:14:27 +01:00

Added subscriber: @karja

Campbell Barton was assigned by Lukas Tönne

2015-01-21 11:24:31 +01:00

Lukas Tönne commented

2015-01-21 11:24:31 +01:00

Added subscriber: @LukasTonne

Lukas Tönne commented

2015-01-21 11:24:31 +01:00

Problem seems to be this conditional when creating bases for appended objects in give_base_to_objects :

				...
				else if (idcode==ID_GR) {
					if (ob->id.us == 1 && is_link == false && ob->id.lib == lib) {
						if ((ob->flag & OB_FROMGROUP) && object_in_any_scene(mainvar, ob)==0) {
							do_it = true;
						}
					}
				}
				...

When there is only one bone shape the ob->id.us == 1 part is true and the Suzanne object gets a base, but with 2 bone shapes it fails and no other condition succeeds to give it a base.

Problem seems to be this conditional when creating bases for appended objects in [give_base_to_objects ](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/readfile.c;47bf0934f5743d14024ef693b2bfe4510c2c666a$9017): ``` ... else if (idcode==ID_GR) { if (ob->id.us == 1 && is_link == false && ob->id.lib == lib) { if ((ob->flag & OB_FROMGROUP) && object_in_any_scene(mainvar, ob)==0) { do_it = true; } } } ... ``` When there is only one bone shape the `ob->id.us == 1` part is true and the Suzanne object gets a base, but with 2 bone shapes it fails and no other condition succeeds to give it a base.

Campbell Barton commented

2015-01-22 06:47:16 +01:00

Looks like it could be changed to: ob->id.us >= 1. would be a reasonable fix.

Looks like it could be changed to: `ob->id.us >= 1`. would be a reasonable fix.

blender-admin commented

2015-03-09 04:33:27 +01:00

This issue was referenced by ec18021867

This issue was referenced by ec180218678be5704d31532fff8c20d2356b8f02

Campbell Barton commented

2015-03-09 04:35:41 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue