Compilation issue VS2013 #44507

Closed
opened 2015-04-24 13:15:22 +02:00 by Ulysse Martin · 9 comments

System Information
Windows 8.1 64 bits GTX 660

Blender Version
Broken: Last Blender 64 bits version 24/04/2015
Worked: 2.74

Short description of error

Errors during compilations in VS 2013:

Erreur 120 error C2057: expression constante attendue D:\Compilation\Blender\blender\source\gameengine\Expressions\KX_PythonCallBack.cpp (line 87) 1 ge_logic_expressions
Erreur 121 error C2466: impossible d'allouer un tableau de taille constante 0 D:\Compilation\Blender\blender\source\gameengine\Expressions\KX_PythonCallBack.cpp (line 87) 1 ge_logic_expressions
Erreur 122 error C2133: 'argTuples' : taille inconnue D:\Compilation\Blender\blender\source\gameengine\Expressions\KX_PythonCallBack.cpp (line 87) 1 ge_logic_expressions

Hi! I think this is this patch: dbb2b29bea..bf6bde232d:/source/gameengine/Expressions/KX_PythonCallBack.cpp

that causes the errors in MSVC compiler.

Thanks!

**System Information** Windows 8.1 64 bits GTX 660 **Blender Version** Broken: Last Blender 64 bits version 24/04/2015 Worked: 2.74 **Short description of error** Errors during compilations in VS 2013: Erreur 120 error C2057: expression constante attendue D:\Compilation\Blender\blender\source\gameengine\Expressions\KX_PythonCallBack.cpp (line 87) 1 ge_logic_expressions Erreur 121 error C2466: impossible d'allouer un tableau de taille constante 0 D:\Compilation\Blender\blender\source\gameengine\Expressions\KX_PythonCallBack.cpp (line 87) 1 ge_logic_expressions Erreur 122 error C2133: 'argTuples' : taille inconnue D:\Compilation\Blender\blender\source\gameengine\Expressions\KX_PythonCallBack.cpp (line 87) 1 ge_logic_expressions Hi! I think this is this patch: https://git.blender.org/gitweb/gitweb.cgi/blender.git/blobdiff/dbb2b29beab46a81c1ea95521a2afe39145717c5..bf6bde232d42c3e1a41a3841292150fae3d214cc:/source/gameengine/Expressions/KX_PythonCallBack.cpp that causes the errors in MSVC compiler. Thanks!
Author

Changed status to: 'Open'

Changed status to: 'Open'
Campbell Barton was assigned by Ulysse Martin 2015-04-24 13:15:22 +02:00
Author

Added subscriber: @you.le

Added subscriber: @you.le
Author

Weird. I just took a look at my updated sources and the patch I mentionned had not been applied... I try another compilation with sources modified with your commit.

Weird. I just took a look at my updated sources and the patch I mentionned had not been applied... I try another compilation with sources modified with your commit.
Author

No same errors. It seems that there is a problem with blender\source\gameengine\Expressions\KX_PythonCallBack.cpp

No same errors. It seems that there is a problem with blender\source\gameengine\Expressions\KX_PythonCallBack.cpp

Added subscriber: @mont29

Added subscriber: @mont29

Yes, stupid MSVC does not supports expressions in array size define… But this has been fixed since then (current code is:

  PyObject **argTuples = (PyObject**)BLI_array_alloca(argTuples, maxargcount - minargcount + 1);
  memset(argTuples, 0, sizeof(PyObject *) * (maxargcount - minargcount + 1));

… does it still fails for you? Even with a complete clean rebuild?

Yes, stupid MSVC does not supports expressions in array size define… But this has been fixed since then (current code is: ``` PyObject **argTuples = (PyObject**)BLI_array_alloca(argTuples, maxargcount - minargcount + 1); memset(argTuples, 0, sizeof(PyObject *) * (maxargcount - minargcount + 1)); ``` … does it still fails for you? Even with a complete clean rebuild?
Author

Hi mont29! Sorry, I forgot to make a git bisect reset. I think it will be ok now. I make a compilation and confirm. Sorry for my mistake.

Hi mont29! Sorry, I forgot to make a git bisect reset. I think it will be ok now. I make a compilation and confirm. Sorry for my mistake.
Author

That' ok! Sorry for wasting your time...

That' ok! Sorry for wasting your time...
Author

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#44507
No description provided.