Freestyle gives no visual output when the Save Buffers option is enabled #44662
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#44662
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Windows 7 64-bit, NVIDiA Quadro 1000M
Blender Version
Broken:
d5f1b9c222
and laterWorked: 2.74 release, and up to
74df307ca4
Short description of error
Freestyle line rendering gives no output lines when the Save Buffers option enabled.
Exact steps for others to reproduce the error
The documented combination of Freestyle and Save Buffers options initially resulted in a fatal crash, which was partly addressed in
8c1b805f87
. Still the Save Buffers option does not work as expected with Freestyle.Acknowledgement: tksg8086 on Twitter for initial problem report.
Changed status to: 'Open'
Added subscriber: @kjym3
Added subscriber: @dfelinto
@dfelinto, I would appreciate it if you could take a look at the reported issue and help me address it.
Added subscriber: @mont29
Added subscriber: @zeauro
When Full Sample is enabled, there is no problem.
Freestyle lines are saved as a separate .exr file in temp directory.
But it seems that combinaison of freestyle lines buffer and regular render buffer is not done when Full Sample option is not enabled.
I don't know if it's related, but simply turning Views on and rendering with Freestyle gives me a crash:
I could reproduce the error on my side (Windows 7 64-bit, VS 2013).
No crash happens if one view is rendered, although Freestyle lines appear in a wrong place (all lines are shifted a bit in the positive X direction). Will look into it as well. We might have to file a separate issue for the documented problems.
Added subscriber: @sindra1961
The build version of blender-2.74-dc95ca9-win32 crashed.
The build version of blender-2.74-9e2e85a-win32 does not crash.
For the records, this (the reported bug, not the crashes) happens only with Blender Internal, which makes me suspect it is related to #44682 (which also only affects Blender Internal)
line of frestyle is drawn normally in _FRS1_Scene_RenderLayer_exr output by a temporary folder.
The problem is
dest = RE_RenderLayerGetPass(rl, SCE_PASS_COMBINED, re->viewname);
being NULL (inFRS_composite_result()
).The issue is related to the changes multiview introduced into pipeline.c.
Basically at the moment we only read back the rendered data when we run
main_render_result_end()
But the call to freestyle is happening before that.
We should do as we do for multisampling (see:
composite_freestyle_renders()
). Basically, render the freestyle as we do now (indo_render_3d()
), but we run FRS_composite_result() only after everything is rendered.@kjym3 how does that sound?
Added subscriber: @Sergey
Added subscriber: @ThomasDinges
This is still marked as "High". Any news here? ;)
Added subscriber: @Blendify
The Patch needs review still D1325
Committed modified workaround for the issue. Think we can stop considering the report a stopper for 2.75. But it needs a real solution still!
Added subscriber: @brecht
Changed status from 'Open' to: 'Resolved'
This was solved in
50731ff
.