Option not to select with un-hide #45230

New Issue

Campbell Barton · 2015-06-29T05:37:18+02:00

Campbell Barton commented

2015-06-29 05:37:18 +02:00

Currently un-hide will always select previously hidden data.

While this is a good default, there are cases when you may not want this (so it can be changed via the redo options or in the keymap)

While a fairly straightforward tasks, this involves going over all unhide operators and adding this option.
(Adding a boolean option to each operator, much the same way many selection operators have an extend option)

Hint, you can find all the operators associated with unhide by searching "\bHKEY\b.*\bKM_ALT\b" using regular expressions.

Currently un-hide will always select previously hidden data. While this is a good default, there are cases when you may not want this *(so it can be changed via the redo options or in the keymap)* While a fairly straightforward tasks, this involves going over all unhide operators and adding this option. *(Adding a boolean option to each operator, much the same way many selection operators have an **extend** option)* ---- Hint, you can find all the operators associated with unhide by searching "`\bHKEY\b.*\bKM_ALT\b`" using regular expressions.

Campbell Barton commented

2015-06-29 05:37:18 +02:00

Changed status to: 'Open'

Campbell Barton commented

2015-06-29 05:37:18 +02:00

Added subscriber: @ideasman42

John Roper self-assigned this 2015-07-11 23:16:38 +02:00

John Roper removed their assignment 2015-08-05 19:00:24 +02:00

John Roper commented

2015-08-05 19:00:24 +02:00

Added subscriber: @JohnRoper

John Roper commented

2015-08-05 19:00:24 +02:00

I don't have time to do any more coding right now, I hope that my work will help someone else get started.

Matthew Abigail self-assigned this 2015-09-07 18:03:02 +02:00

Matthew Abigail commented

2015-09-11 20:52:10 +02:00

I've added an initial patch for this:

So far it adds a select option to the reveal / unhide operators for the following editors:
Armature, Pose, Curve, Mask, Mesh, Object, Paint, Particles, Graph, UVEdit

These changes actively select or unselect the objects being unhidden.

Most of the hide operators actively deselect when hiding objects. However, there are some exceptions:

Hidden metaballs can still be selected / unselected and manipulated in the same way as unhidden ones.
Muting strips in the video sequence editor works the same way.
Hiding tracking markers in the movie clip editor prevents manipulation, but does not change selection.

It might be worth adding the select option to these editors, but with an additional setting ("no change" (?) - do not change the current selection) as the default. If this sounds like a good idea, is this something that should be added here?

Sculpt mode hide / show doesn't have anything to do with selection, so I haven't touched it.

Other issues:

The paint reveal operator had an unused "unselected" variable. This has been replaced with the select option.
The paint reveal operator was also unsetting the hidden flag incorrectly (using -= FOO instead of &= ~FOO). This has been changed in this patch.
Although the select unhidden feature works correctly in vertex paint and weight paint mode, it doesn't work in texture paint mode. It seems that changing the option in the redo panel doesn't properly redo the action (the same can be seen with the hide operator). I'm inclined to report this as a bug (if it's not known already).
When a mask operator is called in Mask mode in the uv/image edit window, the operator is shown in the redo panel in the 3dview window's toolbar. However none of the additional settings are presented (e.g. new mask should have a name property, hide / unhide should have unselected / select options etc.). These options can still be accessed with F6, they just aren't shown in the redo panel. This also seems like a bug. The same issue exists in the graph editor (at least with hiding / unhiding).
Redo also doesn't work properly in particle edit mode (try select random, then H key to hide, then pick the unselected option in the redo panel -> everything gets hidden instead of just the unselected items). Select less / select more don't seem to work at all. I guess this is another bug?

Please let me know if anything needs changing or if you have any other comments.

Thanks!

I've added an initial patch for this: So far it adds a select option to the reveal / unhide operators for the following editors: Armature, Pose, Curve, Mask, Mesh, Object, Paint, Particles, Graph, UVEdit These changes actively select or unselect the objects being unhidden. Most of the hide operators actively deselect when hiding objects. However, there are some exceptions: - Hidden metaballs can still be selected / unselected and manipulated in the same way as unhidden ones. - Muting strips in the video sequence editor works the same way. - Hiding tracking markers in the movie clip editor prevents manipulation, but does not change selection. It might be worth adding the select option to these editors, but with an additional setting ("no change" (?) - do not change the current selection) as the default. If this sounds like a good idea, is this something that should be added here? Sculpt mode hide / show doesn't have anything to do with selection, so I haven't touched it. Other issues: - The paint reveal operator had an unused "unselected" variable. This has been replaced with the select option. - The paint reveal operator was also unsetting the hidden flag incorrectly (using -= FOO instead of &= ~FOO). This has been changed in this patch. - Although the select unhidden feature works correctly in vertex paint and weight paint mode, it doesn't work in texture paint mode. It seems that changing the option in the redo panel doesn't properly redo the action (the same can be seen with the hide operator). I'm inclined to report this as a bug (if it's not known already). - When a mask operator is called in Mask mode in the uv/image edit window, the operator is shown in the redo panel in the 3dview window's toolbar. However none of the additional settings are presented (e.g. new mask should have a name property, hide / unhide should have unselected / select options etc.). These options can still be accessed with F6, they just aren't shown in the redo panel. This also seems like a bug. The same issue exists in the graph editor (at least with hiding / unhiding). - Redo also doesn't work properly in particle edit mode (try select random, then H key to hide, then pick the unselected option in the redo panel -> everything gets hidden instead of just the unselected items). Select less / select more don't seem to work at all. I guess this is another bug? Please let me know if anything needs changing or if you have any other comments. Thanks!

Matthew Abigail was unassigned by John Roper

2015-11-21 21:44:31 +01:00

John Roper self-assigned this 2015-11-21 21:44:31 +01:00

John Roper commented

2015-11-21 21:44:31 +01:00

Added subscriber: @mba105

John Roper commented

2015-11-21 21:48:39 +01:00

Mainly updates on D1518: Select option for reveal operators but I have to re-work the uv edit section because the code has been changed since D1518 was submitted.

Mainly updates on [D1518](https://archive.blender.org/developer/D1518): Select option for reveal operators but I have to re-work the uv edit section because the code has been changed since [D1518](https://archive.blender.org/developer/D1518) was submitted.

John Roper was unassigned by Julian Eisel

2015-11-26 21:23:06 +01:00

Matthew Abigail was assigned by Julian Eisel

2015-11-26 21:23:06 +01:00

Julian Eisel commented

2015-11-26 21:23:06 +01:00

Added subscriber: @JulianEisel

Matthew Abigail was unassigned by Campbell Barton

2017-03-03 15:06:38 +01:00

Campbell Barton commented

2017-11-19 16:28:29 +01:00

Changed status from 'Open' to: 'Resolved'