Sculpt tiling seems to break some brushes #45577

New Issue

Sanc Tuary · 2015-07-27T17:24:58+02:00

Sanc Tuary commented

2015-07-27 17:24:58 +02:00

System Information
win32

Blender Version
Broken: cmake win32 hash : cdf2dbe

Short description of error
flatten and scrape brush misbehave with tiling enabled

Exact steps for others to reproduce the error
Load that blend :
testtilebug.blend

with "Load UI" enabled so you can easily see the problem, use the already selected brush on the zone i am pointing on the screenshot (Dyntopo is enabled)
http://i.imgur.com/rg8GX9i.jpg

The brush is the Scrape brush with locked "Area Plane" in order to use the brush to polish nicely like that :
http://blenderartists.org/forum/showthread.php?370903-Advice-on-sculpting-brushes-is-needed&p=2868828&viewfull=1#post2868828

You should obtain some horrible thing like that :
http://i.imgur.com/iMLqTiu.jpg

Now go disable the X/Y/Z tiling and redo the brush stroke, you should obtain the expected (and desired) :
http://i.imgur.com/DJWsGBF.jpg

I observed the same problem happening with the flatten brush.

**System Information** win32 **Blender Version** Broken: cmake win32 hash : cdf2dbe **Short description of error** flatten and scrape brush misbehave with tiling enabled **Exact steps for others to reproduce the error** Load that blend : [testtilebug.blend](https://archive.blender.org/developer/F213208/testtilebug.blend) with "Load UI" enabled so you can easily see the problem, use the already selected brush on the zone i am pointing on the screenshot (Dyntopo is enabled) http://i.imgur.com/rg8GX9i.jpg The brush is the Scrape brush with locked "Area Plane" in order to use the brush to polish nicely like that : http://blenderartists.org/forum/showthread.php?370903-Advice-on-sculpting-brushes-is-needed&p=2868828&viewfull=1#post2868828 You should obtain some horrible thing like that : http://i.imgur.com/iMLqTiu.jpg Now go disable the X/Y/Z tiling and redo the brush stroke, you should obtain the expected (and desired) : http://i.imgur.com/DJWsGBF.jpg I observed the same problem happening with the flatten brush.

Sanc Tuary commented

2015-07-27 17:24:58 +02:00

Changed status to: 'Open'

Sanc Tuary commented

2015-07-27 17:24:58 +02:00

Added subscriber: @sanctuary

Antonis Ryakiotakis was assigned by Sergey Sharybin

2015-07-28 11:22:22 +02:00

Sergey Sharybin commented

2015-07-28 11:22:22 +02:00

Added subscriber: @Sergey

Tilman Blumhagen commented

2015-07-30 12:07:12 +02:00

Added subscriber: @sternmull

Tilman Blumhagen commented

2015-07-30 12:07:12 +02:00

calc_sculpt_plane() is used by do_scrape_brush() to calculate its reference-plane. I think at the moment it returns the same plane for all tiled strokes. To work correctly it should update the planes origin. For symmetry this function updates the plane by flipping or rotating its normal and origin by using mirror_symmetry_pass and symm_rot_mat. When using tiling it should also move the plane around (Maybe by using an offset that gets updated in do_tiled()).

While looking at this I found there is also an issue with the initial calculation of the plane (and other stuff) when painting starts: When tiling is enabled the first stroke is not issued at the original painting position. Instead it starts at the tiled stroke with the minimum coordinates. At this position the brush is usually partially outside of the mesh and will probably calculate some unexpected normals and other stuff on initialization.

calc_sculpt_plane() is used by do_scrape_brush() to calculate its reference-plane. I think at the moment it returns the same plane for all tiled strokes. To work correctly it should update the planes origin. For symmetry this function updates the plane by flipping or rotating its normal and origin by using mirror_symmetry_pass and symm_rot_mat. When using tiling it should also move the plane around (Maybe by using an offset that gets updated in do_tiled()). While looking at this I found there is also an issue with the initial calculation of the plane (and other stuff) when painting starts: When tiling is enabled the first stroke is not issued at the original painting position. Instead it starts at the tiled stroke with the minimum coordinates. At this position the brush is usually partially outside of the mesh and will probably calculate some unexpected normals and other stuff on initialization.

blender-admin commented

2015-07-30 14:10:54 +02:00

This issue was referenced by 2ae67de944

This issue was referenced by 2ae67de94437162a9d429850b04a295fa393d971

Antonis Ryakiotakis commented

2015-07-30 14:11:37 +02:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2015-07-30 14:11:37 +02:00

Antonis Ryakiotakis commented

2015-07-30 14:12:49 +02:00

Committed the quick and dirty solution - recalculate the sculpt plane always in tiled sculpting.

Sanc Tuary commented

2015-07-31 17:34:58 +02:00

I do not know if it's because of the "dirty" solution or if it is what you mean by "TODO" in the fix.
But in case you aren't already aware, while the brushes after that fix do not horribly destroy the meshes where you stroke fortunately, even with the fix they are still not working correctly with "Area Plane" locked when you use tiling, in fact they work as the user had not locked the "Area Plane".

( using blender-2.75-6b7313b-win32.zip , today's buildbot)

They work correctly only if i disable X/Y/Z tiling in sculpt.

I do not know if it's because of the "dirty" solution or if it is what you mean by "TODO" in the fix. But in case you aren't already aware, while the brushes after that fix do not horribly destroy the meshes where you stroke fortunately, even with the fix they are still not working correctly with "Area Plane" locked when you use tiling, in fact they work as the user had not locked the "Area Plane". ( using blender-2.75-6b7313b-win32.zip , today's buildbot) They work correctly only if i disable X/Y/Z tiling in sculpt.

Tilman Blumhagen commented

2015-07-31 17:39:11 +02:00

You are right, the commit of this task effectively disables the locked "Area Plane". Yesterday I submitted a patch that corrects this behaviour: D1438

You are right, the commit of this task effectively disables the locked "Area Plane". Yesterday I submitted a patch that corrects this behaviour: [D1438](https://archive.blender.org/developer/D1438)

Sanc Tuary commented

2015-08-02 15:50:51 +02:00

Hello,

I do not know if your patch fixing the problem has been included in Blender since you submitted it , but i tried today's buildbot ( blender-2.75-3b4a8f1-win32.zip ) and unfortunately the problem is still present, the locked planes are ignored if sculpt tiling is enabled.

Hello, I do not know if your patch fixing the problem has been included in Blender since you submitted it , but i tried today's buildbot ( blender-2.75-3b4a8f1-win32.zip ) and unfortunately the problem is still present, the locked planes are ignored if sculpt tiling is enabled.

Antonis Ryakiotakis commented

2015-08-02 15:57:09 +02:00

No it's not, I will be committing the fix tomorrow, unless someone else does so first.

Sanc Tuary commented

2015-08-02 17:42:00 +02:00

Thank you

Sanc Tuary commented

2015-08-04 13:53:24 +02:00

Just reporting that i tested on today's buildbot ( blender-2.75-23f5407-win32.zip ) and i confirm that it's now working greatly.

Thank you very much for the patch and the commit.

Just reporting that i tested on today's buildbot ( blender-2.75-23f5407-win32.zip ) and i confirm that it's now working greatly. Thank you very much for the patch and the commit.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Sculpt tiling seems to break some brushes #45577