Expand Voronoi node functionality in Cycles #45797

New Issue

Michel Anders · 2015-08-14T13:36:47+02:00

Michel Anders commented

2015-08-14 13:36:47 +02:00

This minor functional patch expands the functionality of the Voronoi textture input node in Cycles on two fronts:

it adds a second output socket "F2" which provides the distance to the second nearest neighbour
it adds a drop down selection to the node with a choice of distance metrics.

Addition of the F2 node makes it possible for texture designers to obtain the F2 - F1 (aka Voronoi crackle) pattern by chaining it to a subtract node. The distance metrics added allow for a greater variety of patterns. I have implemented the Manhattan, Chebychev and Distance metrics (besides the default Distance squared)

Care has been taken to keep the node fully backward compatible with the existing Voronoi node: the default distance metric is "Distance Squared" an the old 'Fac' output socket is retained although it might have been slightly more logical to rename it to F1 but this would break existing noodles.

It is a deliberate choice to add an F2 socket and not a F2F1 socket as this opens up more possibilities for the end user (and reduces the computational overhead by a single subtract although adding a subtract node in a noodle might actually be more expensive). Also I have left out the Minkowsky metrics as there are less commonly used and would clutter the node interface with a bunch of extra parameters. We could always introduce that later if there would be a huge demand for it.

As indicated in the comments in svm_voronoi.h, there is some room for performance improvement in the code, both in the SSE2 branch and in the non SSE2 branch but this would further complicate the code for a small and uncertain gain.

The code is tested both on a GPU (a GTX970 but I actually used sm50 not sm52) and a CPU (intel core 7) both on existing textures with a voronoi node as well as with nodes with new functionality, but only on Ubuntu (15.04)

                                                      - diff -------------------------

voronoi.diff

This minor functional patch expands the functionality of the Voronoi textture input node in Cycles on two fronts: - it adds a second output socket "F2" which provides the distance to the second nearest neighbour - it adds a drop down selection to the node with a choice of distance metrics. Addition of the F2 node makes it possible for texture designers to obtain the F2 - F1 (aka Voronoi crackle) pattern by chaining it to a subtract node. The distance metrics added allow for a greater variety of patterns. I have implemented the Manhattan, Chebychev and Distance metrics (besides the default Distance squared) Care has been taken to keep the node fully backward compatible with the existing Voronoi node: the default distance metric is "Distance Squared" an the old 'Fac' output socket is retained although it might have been slightly more logical to rename it to F1 but this would break existing noodles. It is a deliberate choice to add an F2 socket and not a F2F1 socket as this opens up more possibilities for the end user (and reduces the computational overhead by a single subtract although adding a subtract node in a noodle might actually be more expensive). Also I have left out the Minkowsky metrics as there are less commonly used and would clutter the node interface with a bunch of extra parameters. We could always introduce that later if there would be a huge demand for it. As indicated in the comments in svm_voronoi.h, there is some room for performance improvement in the code, both in the SSE2 branch and in the non SSE2 branch but this would further complicate the code for a small and uncertain gain. The code is tested both on a GPU (a GTX970 but I actually used sm50 not sm52) and a CPU (intel core 7) both on existing textures with a voronoi node as well as with nodes with new functionality, but only on Ubuntu (15.04) - diff ------------------------- [voronoi.diff](https://archive.blender.org/developer/F224323/voronoi.diff)

Michel Anders commented

2015-08-14 13:36:47 +02:00

Changed status to: 'Open'

Michel Anders commented

2015-08-14 13:36:47 +02:00

Added subscriber: @MichelAnders

Aaron Carlisle commented

2015-08-14 14:42:20 +02:00

Added subscriber: @Blendify

Julian Eisel commented

2015-08-14 17:44:55 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2015-08-14 17:44:55 +02:00

@MichelAnders, thanks for the patch. Could you upload it to our differential review tool?

@MichelAnders, thanks for the patch. Could you upload it to our [differential ](https://developer.blender.org/differential/) review tool?

Michel Anders commented

2015-08-14 20:02:51 +02:00

Added subscriber: @julian-8

Michel Anders commented

2015-08-14 20:02:51 +02:00

@julian-8 Eisel: sure, it's on https://developer.blender.org/differential/diff/4860/

I referenced this task in the comments but did nt assign reviewers (I am not sure I am supposed to do that anyway, so I hope someone is interested :-)

@julian-8 Eisel: sure, it's on https://developer.blender.org/differential/diff/4860/ I referenced this task in the comments but did nt assign reviewers (I am not sure I am supposed to do that anyway, so I hope someone is interested :-)

Julian Eisel commented

2015-08-14 20:22:35 +02:00

Changed status from 'Open' to: 'Resolved'

Julian Eisel closed this issue

2015-08-14 20:22:35 +02:00

Julian Eisel self-assigned this 2015-08-14 20:22:35 +02:00

Julian Eisel commented

2015-08-14 20:22:35 +02:00

Thanks, added reviewers. It doesn't seem like we need a diff and a patch task for this, so closing task.

Bartosz Moniewski commented

2015-08-18 18:28:03 +02:00

Added subscriber: @BartekMoniewski

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Expand Voronoi node functionality in Cycles #45797