crash with generating DataBlockPreviews #46626
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#46626
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
linux64, Titan
Blender Version
Broken:
b0bce65d67
Worked:
f375028a25
Short description of error
crash with generating DataBlockPreviews in the default scene
Exact steps for others to reproduce the error
in default startup file [might have to start blender with --factory], goto
File > Data Previews > Refresh DataBlock Previews
should crash
Caused by a broken(freed?) "toggle_brush" pointer on the "SculptDraw" brush.
So you will only get the crash if the "SculptDraw" brush is selected in sculptmode (which I think it is in the default startup scene)
If any other brush is selected, crash wont happen.
this will prevent the crash
backtrace
valgrind
Changed status to: 'Open'
Added subscriber: @lichtwerk
Added subscribers: @mont29, @Sergey
@mont29, it is possible that
brush->toggle_brush
pointer is becoming invalid. For example, you toggle brush then you remove original one. Also, not really sure you really want to go into toggle brush itself in the walker, so leaving it up to you.Added subscriber: @afdave14
I do not see how we can accept an invalid pointer here? It may crash in many other cases I guess? Even worse in default startup, this should be fixed in factory .blend…
And the walker shall return all ID pointers, with no exceptions - otherwise you'll end up with even more 'invalid pointers' like that in the future.
Think this is a good demo of how bad our 'remove ID' code is currently :|
That said, will have a look around to try to understand how toggle_brush can become invalid - and tease Campbell to fix startup file.
Added subscriber: @ideasman42
Removed subscriber: @afdave14
This issue was referenced by
7b7aba31f2
Changed status from 'Open' to: 'Resolved'