FileBrowser - get rid of useless operators like FILE_OT_hidedot. #46918

New Issue

Reiner Prokein · 2015-12-03T10:53:03+01:00

Reiner Prokein commented

2015-12-03 10:53:03 +01:00

System Information
Operating system and graphics card

Windows 7 home 64 Bit
Nvidia 760 gtx

Blender Version
Broken: (example: 2.69.7 4b206af, see splash screen)
Worked: (optional)

Short description of error

Not sure if this is a bug or a UI work in progress issue. I cannot change the hotkeys for the icon buttons in the top row of the file browser. The rmb menu doesn't contain a change or add shortcut menu item.

Exact steps for others to reproduce the error
Based on a (as simple as possible) attached .blend file with minimum amount of steps

Open Blender, go to the file browser. Right click at one of the buttons at the top. I have chosen the hide dot files button here. It has no rmb menu to add or to change the shortcut.

What we have though is shortcuts in the Input manager for some of them. But they use a completely different menu code from what i can see. And provides different tooltips. And when you add the buttons with using the Identifier from the Input nodes, then you can add a button that displays the tooltip, and has a rmb menu where you can change the hotkey.

Wouldn't it be better when the buttons would display the hotkey the tooltip? And would have the rmb menu to change the hotkey?

I have in the second image added such a button with the identifier from the input manager to the space_filebrowser.py file to show what i mean.

**System Information** Operating system and graphics card Windows 7 home 64 Bit Nvidia 760 gtx **Blender Version** Broken: (example: 2.69.7 4b206af, see splash screen) Worked: (optional) **Short description of error** Not sure if this is a bug or a UI work in progress issue. I cannot change the hotkeys for the icon buttons in the top row of the file browser. The rmb menu doesn't contain a change or add shortcut menu item. **Exact steps for others to reproduce the error** Based on a (as simple as possible) attached .blend file with minimum amount of steps Open Blender, go to the file browser. Right click at one of the buttons at the top. I have chosen the hide dot files button here. It has no rmb menu to add or to change the shortcut. What we have though is shortcuts in the Input manager for some of them. But they use a completely different menu code from what i can see. And provides different tooltips. And when you add the buttons with using the Identifier from the Input nodes, then you can add a button that displays the tooltip, and has a rmb menu where you can change the hotkey. Wouldn't it be better when the buttons would display the hotkey the tooltip? And would have the rmb menu to change the hotkey? I have in the second image added such a button with the identifier from the input manager to the space_filebrowser.py file to show what i mean. ![filebrowserbuttons1.jpg](https://archive.blender.org/developer/F262049/filebrowserbuttons1.jpg) ![filebrowserbuttons2.jpg](https://archive.blender.org/developer/F262051/filebrowserbuttons2.jpg)

Reiner Prokein commented

2015-12-03 10:53:03 +01:00

Changed status to: 'Open'

Reiner Prokein commented

2015-12-03 10:53:03 +01:00

Added subscriber: @tiles

Reiner Prokein commented

2015-12-03 11:15:55 +01:00

Okay, seems that i have catched with the show/hide dot files the one button of the row that has this behaviour ^^

The other buttons either have already the right code, or no shortcut at all. So it's just about the show/hide tot files button at the moment. It would nevertheless be nice to have the rmb menu with add and change hotkeys at the rest of the buttons too.

Okay, seems that i have catched with the show/hide dot files the one button of the row that has this behaviour ^^ The other buttons either have already the right code, or no shortcut at all. So it's just about the show/hide tot files button at the moment. It would nevertheless be nice to have the rmb menu with add and change hotkeys at the rest of the buttons too.

Bastien Montagne commented

2015-12-03 11:59:19 +01:00

Added subscriber: @mont29

Bastien Montagne self-assigned this 2015-12-03 11:59:19 +01:00

Bastien Montagne commented

2015-12-03 11:59:19 +01:00

Eeek! Having an operator for that is total overkill, this has to be replaced by generic WM_OT_context_toggle one!

Looks like filebrowser has quite a bunch of those, will clean that up.

That said, it won't solve the shortcut issue itself - for that we need a way to match generic WM_OT_context_foo operators with buttons that do direct access to RNA prop, this is more a TODO than a bug really.

Eeek! Having an operator for that is total overkill, this has to be replaced by generic `WM_OT_context_toggle` one! Looks like filebrowser has quite a bunch of those, will clean that up. That said, it won't solve the shortcut issue itself - for that we need a way to match generic WM_OT_context_foo operators with buttons that do direct access to RNA prop, this is more a TODO than a bug really.

Bastien Montagne changed title from ~~Can't display the shortcut in the tooltip and can't change hotkey at the icon buttons in the file browser~~ to FileBrowser - get rid of useless operators like FILE_OT_hidedot.

2015-12-03 12:00:46 +01:00

blender-admin commented

2015-12-03 12:21:57 +01:00

This issue was referenced by a7dbc0704f

This issue was referenced by a7dbc0704f217a827900bdc959db49da80632f23

Bastien Montagne commented

2015-12-03 12:24:09 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2015-12-03 12:24:09 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

FileBrowser - get rid of useless operators like FILE_OT_hidedot. #46918