Some OpenSubdiv compute modes not available for translation #47371

New Issue

They all should be available, they all are the same RNA property. My guess here is that it's .pot generator was run on a system which did not support this modes or was run in the background mode. Not sure how to easily solve this, can just hardcode GPU dependent enums in the generator perhaps.

Alternatively, you can just manually add them to the .po file, just similar to CPU and OpenMP and it should work.

@mont29, can you verify my guess about .pot generator? Not really familiar how it works now. Thanks!

They all should be available, they all are the same RNA property. My guess here is that it's .pot generator was run on a system which did not support this modes or was run in the background mode. Not sure how to easily solve this, can just hardcode GPU dependent enums in the generator perhaps. Alternatively, you can just manually add them to the .po file, just similar to CPU and OpenMP and it should work. @mont29, can you verify my guess about .pot generator? Not really familiar how it works now. Thanks!

Bastien Montagne commented

2016-02-09 10:50:02 +01:00

@Sergey yes, i18n script runs a background blender to extract messages - but even without that, we would not get all options (I typically do not run Blender on my real GPU). Same goes for (cycles) compute device option btw.

We can fix this in three ways:

Remove the 'no context' flag on those properties (this does not change anything in 'usual' situation, but allows to get the full set of items when calling prop.enum_items from python (which is what i18n script does), since in that case rna cannot call its enum items function (because it does not have a context, precisely ;) ).
Add manual 'translate' tags around all label & tips of those enum items.
Add another accessor to RNA's enum props (e.g. enum_items_raw), that would never call the callback itemf func at all.

So main question: did you set that 'no context' flags on those enums for a real reason, or just because you did not need it?

@Sergey yes, i18n script runs a background blender to extract messages - but even without that, we would not get all options (I typically do not run Blender on my real GPU). Same goes for (cycles) compute device option btw. We can fix this in three ways: * Remove the 'no context' flag on those properties (this does not change anything in 'usual' situation, but allows to get the full set of items when calling `prop.enum_items` from python (which is what i18n script does), since in that case rna cannot call its enum items function (because it does not have a context, precisely ;) ). * Add manual 'translate' tags around all label & tips of those enum items. * Add another accessor to RNA's enum props (e.g. `enum_items_raw`), that would never call the callback itemf func at all. So main question: did you set that 'no context' flags on those enums for a real reason, or just because you did not need it?

Sergey Sharybin commented

2016-02-09 11:03:22 +01:00

@mont29, it just mimmics Cycles's compyte device type. Guess we can remove the flag, but it's weird, because callback is actually does not depend on the context....

blender-admin commented

2016-02-09 12:51:07 +01:00

This issue was referenced by 337b718695

This issue was referenced by 337b718695c8b31dadc22438b9f1af40d225e0ad

Bastien Montagne commented

2016-02-09 12:51:27 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2016-02-09 12:51:27 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Some OpenSubdiv compute modes not available for translation #47371