Deleting keyframe in node group makes a zombie action data block when the node had an action #47428

New Issue

Satoshi Yamasaki · 2016-02-16T05:39:50+01:00

Satoshi Yamasaki commented

2016-02-16 05:39:50 +01:00

System Information
Windows 8.1 Pro 64bit, GeForce GTX660

Blender Version
Broken: 2.76, 2.77Testbuild1

Short description of error
Deleting keyframe in node group makes a zombie action data block when the node had an action.

Exact steps for others to reproduce the error

Add a node (e.g. Material node)
Insert a keyframe for a parameter of the node
(In this operation, "Shader NodetreeAction" is added)
Make a group include the node
(In this operation, "Shader NodetreeAction.001" is added)
Delete the keyframe in the group

Then go Outliner and select Datablock view, you will see two action datablocks, "Shader NodetreeAction" and "Shader NodetreeAction.001". Latter has no users (so it will be deleted when save the file), but former has one user that can't be delete.
Why the original action remains and can we delete it?

Thanks,

**System Information** Windows 8.1 Pro 64bit, GeForce GTX660 **Blender Version** Broken: 2.76, 2.77Testbuild1 **Short description of error** Deleting keyframe in node group makes a zombie action data block when the node had an action. **Exact steps for others to reproduce the error** 1) Add a node (e.g. Material node) 2) Insert a keyframe for a parameter of the node (In this operation, "Shader NodetreeAction" is added) 3) Make a group include the node (In this operation, "Shader NodetreeAction.001" is added) 4) Delete the keyframe in the group Then go Outliner and select Datablock view, you will see two action datablocks, "Shader NodetreeAction" and "Shader NodetreeAction.001". Latter has no users (so it will be deleted when save the file), but former has one user that can't be delete. Why the original action remains and can we delete it? Thanks,

Satoshi Yamasaki commented

2016-02-16 05:39:50 +01:00

Changed status to: 'Open'

Satoshi Yamasaki commented

2016-02-16 05:39:50 +01:00

Added subscriber: @SatoshiYamasaki

Bastien Montagne commented

2016-02-20 13:06:35 +01:00

Added subscribers: @JoshuaLeung, @mont29

Bastien Montagne commented

2016-02-20 13:06:35 +01:00

This is kinda corner case… What happens is that when you group, you create a new NodeTree ID, which gets a new action. Old action remains attached to original NodeTree, so it technically still has one user. I guess we could (should) check whether original action is empty after grouping, and detach it in this case?

Actually, even worse, in debug build we get a nice crash when ungrouping some animated nodes… yuck.

@JoshuaLeung you may be interested by that one too?

This is kinda corner case… What happens is that when you group, you create a new NodeTree ID, which gets a new action. Old action remains attached to original NodeTree, so it technically still has one user. I guess we could (should) check whether original action is empty after grouping, and detach it in this case? Actually, even worse, in debug build we get a nice crash when ungrouping some animated nodes… yuck. @JoshuaLeung you may be interested by that one too?

Bastien Montagne commented

2016-02-20 13:19:01 +01:00

Ok, fixed hard crash in 8132553553.

This still leaves a mess in usercount, but would be tempted to consider this a TODO for now - and check in id-remap how it works, this branch is supposed to have much better ID handling than our current master (which fails in many corner cases on this topic).

Ok, fixed hard crash in 8132553553. This still leaves a mess in usercount, but would be tempted to consider this a TODO for now - and check in id-remap how it works, this branch is supposed to have much better ID handling than our current master (which fails in many corner cases on this topic).

Satoshi Yamasaki commented

2016-02-25 00:24:51 +01:00

Thank you Bastien for your hard work. :)
I think it would be nice that Outliner has the ability to delete such zombie datablocks like orphans too.

Thank you Bastien for your hard work. :) I think it would be nice that Outliner has the ability to delete such zombie datablocks like orphans too.

Sergey Sharybin commented

2016-05-03 11:16:29 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2016-05-03 11:16:29 +02:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2016-05-03 11:16:29 +02:00

Sergey Sharybin self-assigned this 2016-05-03 11:16:29 +02:00

Sergey Sharybin commented

2016-05-03 11:16:29 +02:00

Would really consider it a TODO since it's something what never worked really correct and there's ongoing project on improving related areas.

Thanks for the report anyway!

Would really consider it a TODO since it's something what never worked really correct and there's ongoing project on improving related areas. Thanks for the report anyway!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Deleting keyframe in node group makes a zombie action data block when the node had an action #47428