'Select Similar' for the UV Editor #47437

New Issue

Campbell Barton · 2016-02-16T16:26:20+01:00

Campbell Barton commented

2016-02-16 16:26:20 +01:00

Benefits: Artists can more easily isolate parts of the UV map to operate on, using a selection method they will already be families with from other parts of Blender.

Description: With this option you could select UV's based on characteristics of the mesh, eg:

Material
Face Area
UV Area
Polygon Sides
Pinned State
... possibly other options too, note that a subset of these can be accepted for the initial patch.

See mesh edit-mode, Select Grouped (Shift-G).

Challenges: adding key binding, operator and evaluating/comparing mesh data.

**Benefits:** Artists can more easily isolate parts of the UV map to operate on, using a selection method they will already be families with from other parts of Blender. **Description:** With this option you could select UV's based on characteristics of the mesh, eg: - Material - Face Area - UV Area - Polygon Sides - Pinned State *... possibly other options too, note that a subset of these can be accepted for the initial patch.* See mesh edit-mode, Select Grouped (Shift-G). **Challenges:** adding key binding, operator and evaluating/comparing mesh data.

Campbell Barton commented

2016-02-16 16:26:20 +01:00

Changed status to: 'Open'

Campbell Barton commented

2016-02-16 16:26:20 +01:00

Added subscriber: @ideasman42

Campbell Barton changed title from ~~Select similar for the UV Editor~~ to 'Select Similar' for the UV Editor

2016-02-16 19:55:04 +01:00

michael knubben commented

2016-02-22 13:05:38 +01:00

Added subscriber: @michaelknubben

Michał Ziobro self-assigned this 2016-06-24 14:47:05 +02:00

Tom Corwine commented

2016-11-01 21:41:45 +01:00

Added subscriber: @tcorwine

Karthikeyan Iyer commented

2016-11-14 17:58:23 +01:00

Added subscriber: @karthik24iyer

Karthikeyan Iyer commented

2016-11-14 17:59:21 +01:00

Removed subscriber: @karthik24iyer

Neel Kelkar commented

2016-12-24 20:56:41 +01:00

Added subscriber: @Nilkel

sai shobith commented

2017-02-12 00:12:45 +01:00

Added subscriber: @shobit30

sai shobith commented

2017-02-12 00:12:45 +01:00

Is this task completed?
I would like to try this.

Is this task completed? I would like to try this.

Michał Ziobro was unassigned by Campbell Barton

2017-03-03 15:04:49 +01:00

Campbell Barton commented

2017-03-03 15:04:49 +01:00

Added subscriber: @Muchomor

David Sandberg commented

2017-04-06 07:09:55 +02:00

Added subscriber: @DavidSandberg

Jeff Knox commented

2017-06-20 00:32:31 +02:00

Added subscriber: @knox

Carlos Rafael de Oliveira Carneiro commented

2017-06-22 03:00:41 +02:00

Added subscriber: @CarlosRafaeldeOliveiraCarneiro

Jeff Knox self-assigned this 2017-07-09 06:58:20 +02:00

Matthew commented

2019-01-25 20:35:36 +01:00

Added subscriber: @Loading_M

matc commented

2019-03-04 23:49:43 +01:00

Added subscriber: @matc

Kalyan commented

2019-05-01 23:20:04 +02:00

Added subscriber: @KalyanS

Kalyan commented

2019-05-01 23:20:05 +02:00

What's the status on this? Can I try it?

Campbell Barton commented

2019-05-02 00:45:52 +02:00

Yes (no need to ask, any open quick-hack is a candidate to try).

Kalyan commented

2019-05-03 03:16:08 +02:00

Cool, thanks! I have used blender for a while and know C++, but I am new to blender development - any pointers on how to do this? Mostly I am having trouble navigating the rather large codebase, so any advice would be greatly appreciated.

Campbell Barton commented

2019-05-03 03:17:44 +02:00

See https://wiki.blender.org/wiki/Developer_Intro/Advice

matc commented

2019-05-03 18:32:14 +02:00

I had worked on this a couple of weeks ago. I updated my version to current master (D4792).

@ideasman42 Could you have a look at D4792 to determine whether this approach could serve @KalyanS as a basis?

I had worked on this a couple of weeks ago. I updated my version to current master ([D4792](https://archive.blender.org/developer/D4792)). @ideasman42 Could you have a look at [D4792](https://archive.blender.org/developer/D4792) to determine whether this approach could serve @KalyanS as a basis?

Kalyan commented

2019-05-06 21:00:55 +02:00

@matc Thanks for the diff, I'll take a look at it when I have time and try to implement this task.

Quick question - where does the 2.8 codebase store keymaps? I've looked at some old diffs but they seem to be outdated. There's some code regarding window managers and keymaps, but where can I define custom keymaps for a space/editor?

@matc Thanks for the diff, I'll take a look at it when I have time and try to implement this task. Quick question - where does the 2.8 codebase store keymaps? I've looked at some old diffs but they seem to be outdated. There's some code regarding window managers and keymaps, but where can I define custom keymaps for a space/editor?

matc commented

2019-05-07 23:43:10 +02:00

Keymaps appear to be in release/scripts/presets/keyconfig/keymap_data/.

I don't think you do have to change any key bindings. I usually just use the operator search menu (Space or F3) to run an operator.

Keymaps appear to be in `release/scripts/presets/keyconfig/keymap_data/`. I don't think you do have to change any key bindings. I usually just use the operator search menu (Space or F3) to run an operator.

Kalyan commented

2019-06-14 14:57:50 +02:00

Ahh finally I have some time to work on this! I've implemented @matc's patch (D4792) as well as adding the Shift-G keybind for consistency (turned out to be very simple once I figured out how the keymaps worked). Unfortunately, I don't have enough Blender internal/general knowledge to know the inner workings of kdtrees, gsets, etc... does anyone have any pointers on how to extend D4792 to edge and vertex select?

I don't like asking for step by step guidance like this - I'm sure others have work to do, but I really have no idea how to go about anything in this multi-million line codebase.

Ahh finally I have some time to work on this! I've implemented @matc's patch ([D4792](https://archive.blender.org/developer/D4792)) as well as adding the Shift-G keybind for consistency (turned out to be very simple once I figured out how the keymaps worked). Unfortunately, I don't have enough Blender internal/general knowledge to know the inner workings of kdtrees, gsets, etc... does anyone have any pointers on how to extend [D4792](https://archive.blender.org/developer/D4792) to edge and vertex select? I don't like asking for step by step guidance like this - I'm sure others have work to do, but I really have no idea how to go about anything in this multi-million line codebase.

matc commented

2019-06-17 12:00:15 +02:00

Gset is just the equivalent to a set in C++ or Java. You can find the implementation in BLI_ghash.c by looking for the BLI_gset_ prefix.

From wikipedia: "In computer science, a k-d tree (short for k-dimensional tree) is a space-partitioning data structure for organizing points in a k-dimensional space."
The implementation of kdtree is in kdtree_impl.h.

I don't think you have to worry all that much about those. In each case you will just be using for example the length of an edge measured in uv space instead of mesh space. The collections should not need to be changed.

Essentially all functions in D4792 exist for vertices and edges too. Their names should be the same with "face" replaced by "vert" or "edge".

As a start I suggest to modify similar_edge_select_exec to optionally make the selection in uv editor instead of the viewport.
Basically make the following code work with edges.

        if (select) {
          if (selection_mode == SIM_DATA_MODE_MESH) {
            BM_face_select_set(bm, face, true);
          }
          else {
            uvedit_face_select_enable(scene, em, face, true, cd_loop_uv_offset);
          }
          changed = true;
        }

Gset is just the equivalent to a set in C++ or Java. You can find the implementation in BLI_ghash.c by looking for the BLI_gset_ prefix. From wikipedia: "In computer science, a [k-d tree](https://en.wikipedia.org/wiki/Kdtree) (short for k-dimensional tree) is a space-partitioning data structure for organizing points in a k-dimensional space." The implementation of kdtree is in kdtree_impl.h. I don't think you have to worry all that much about those. In each case you will just be using for example the length of an edge measured in uv space instead of mesh space. The collections should not need to be changed. Essentially all functions in [D4792](https://archive.blender.org/developer/D4792) exist for vertices and edges too. Their names should be the same with "face" replaced by "vert" or "edge". As a start I suggest to modify similar_edge_select_exec to optionally make the selection in uv editor instead of the viewport. Basically make the following code work with edges. ``` if (select) { if (selection_mode == SIM_DATA_MODE_MESH) { BM_face_select_set(bm, face, true); } else { uvedit_face_select_enable(scene, em, face, true, cd_loop_uv_offset); } changed = true; } ```

Kalyan commented

2019-06-21 05:27:07 +02:00

Ok I have a preliminary diff working on edge direction and length select (see D5108). It adds on to @matc's D4792. I would love to get feedback on this diff!

Ok I have a preliminary diff working on edge direction and length select (see [D5108](https://archive.blender.org/developer/D5108)). It adds on to @matc's [D4792](https://archive.blender.org/developer/D4792). I would love to get feedback on this diff!

Ashwin Ginoria commented

2020-02-27 20:25:59 +01:00

Added subscriber: @Ashwin_Ginoria

Ashwin Ginoria commented

2020-02-27 20:25:59 +01:00

Hello, I'm Ashwin Ginoria a Student of B.Tech (2nd year) Computer Science Engineering, IIT Mandi, India. I'm new to open source Development and would love to join the comunity and I'd like to work on this task so ...
Is this task Completed ?
Also is it a beginner friendly task ?
It would be my first contribution to blender.

Hello, I'm Ashwin Ginoria a Student of B.Tech (2nd year) Computer Science Engineering, IIT Mandi, India. I'm new to open source Development and would love to join the comunity and I'd like to work on this task so ... Is this task Completed ? Also is it a beginner friendly task ? It would be my first contribution to blender.

Scott Wilson commented

2020-05-14 03:09:37 +02:00

Added subscriber: @propersquid

Julia Maliauka commented

2020-08-05 20:31:07 +02:00

Added subscriber: @yulia_maliauka

Tony Huang commented

2020-08-15 21:41:10 +02:00

Added subscriber: @tonyhuang19

Pierre Risch commented

2022-03-03 00:02:16 +01:00

Added subscriber: @PierreRisch

Chris Blackbourn commented

2022-06-10 06:33:35 +02:00

Added subscriber: @Chris_Blackbourn

Jeff Knox was unassigned by Chris Blackbourn

2022-06-10 06:33:35 +02:00

Chris Blackbourn self-assigned this 2022-06-10 06:33:35 +02:00

Chris Blackbourn commented

2022-06-10 06:33:35 +02:00

Fix pending review : D15164

Fix pending review : [D15164](https://archive.blender.org/developer/D15164)

blender-admin commented

2022-06-21 07:31:59 +02:00

This issue was referenced by 1154b45526

This issue was referenced by 1154b45526797d6f5999d1be18f92124baf8107f

Chris Blackbourn commented

2022-06-21 07:35:46 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Chris Blackbourn closed this issue

2022-06-21 07:35:46 +02:00

Daniel Bystedt commented

2022-07-27 01:03:29 +02:00

Added subscriber: @DanielBystedt

Daniel Bystedt commented

2022-07-27 01:03:29 +02:00

@Chris_Blackbourn asked me to give feedback on this task via blender.chat.

One more useful addition to "select similar" in the uv editor would be the same as "select similar - face regions" in the 3d view. Based on a current uv island selection, the operator would select any other uv island with the same vertex/face count. You can have a look at my image example below.

One could argue that it could be interesting to add checks for rotation etc and compare uv islands in a more complex way, but I feel that just counting the faces per uv island will work just fine in most cases.

@Chris_Blackbourn asked me to give feedback on this task via blender.chat. One more useful addition to "select similar" in the uv editor would be the same as "select similar - face regions" in the 3d view. Based on a current uv island selection, the operator would select any other uv island with the same vertex/face count. You can have a look at my image example below. ![image.png](https://archive.blender.org/developer/F13320345/image.png) One could argue that it could be interesting to add checks for rotation etc and compare uv islands in a more complex way, but I feel that just counting the faces per uv island will work just fine in most cases.

blender-admin commented

2022-07-30 13:20:13 +02:00

This issue was referenced by a581460728

This issue was referenced by a5814607289a7e01d4844ee5ef724e6388cf044e

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

'Select Similar' for the UV Editor #47437