VSE patch affects scaling of CbCr planes #47766

Closed
opened 2016-03-11 22:09:59 +01:00 by Paul R · 8 comments

System Information
SUSE Linux Leap 42.1
NVidia GTX 560ti (official drivers)

Blender Version
Broken: 2.77 606f6b79ea
Worked:

Short description of error
The patch for #47724 now causes the video chroma planes to be scaled differently to the Y channel.

Colours look aligned on the left, but get progressively shifted towards the right. Especially noticeable on the green bars (bottom of the three images):
blender_vse_colour_scaling_vertical_rgb_bars_alignment.png

^ This happens even if the src video and project dimensions are divisible by 16, eg 720x480.

*As a side issue, the CbCr channels are now upscaled with interpolation instead of nearest neighbour. Interpolation obviously looks more pleasing for previewing (and might make green-screen keying easier), but might not be wanted for simple 'pass through' work like editing/grading as it will end up softening the image a bit.

Exact steps for others to reproduce the error

The test video can be created from scratch using:854x480_vertical_rgb_grid2.png
with:
ffmpeg -loop 1 -i 854x480_vertical_rgb_grid2.png -pix_fmt yuv420p -crf 20 -t 4 854x480_vertical_rgb_grid2.mp4

**System Information** SUSE Linux Leap 42.1 NVidia GTX 560ti (official drivers) **Blender Version** Broken: 2.77 606f6b79ea Worked: **Short description of error** The patch for #47724 now causes the video chroma planes to be scaled differently to the Y channel. Colours look aligned on the left, but get progressively shifted towards the right. Especially noticeable on the green bars (bottom of the three images): ![blender_vse_colour_scaling_vertical_rgb_bars_alignment.png](https://archive.blender.org/developer/F289531/blender_vse_colour_scaling_vertical_rgb_bars_alignment.png) ^ This happens even if the src video and project dimensions are divisible by 16, eg 720x480. *As a side issue, the CbCr channels are now upscaled with interpolation instead of nearest neighbour. Interpolation obviously looks more pleasing for previewing (and might make green-screen keying easier), but might not be wanted for simple 'pass through' work like editing/grading as it will end up softening the image a bit. **Exact steps for others to reproduce the error** - open [F289048](https://archive.blender.org/developer/F289048/vse_video_resolution_crop.blend) .blend - load [854x480_vertical_rgb_grid2.mp4](https://archive.blender.org/developer/F289533/854x480_vertical_rgb_grid2.mp4) - video is 854x480, h.264, 25fps, 4:2:0 (encoded with ffmpeg 2.8.4) The test video can be created from scratch using:![854x480_vertical_rgb_grid2.png](https://archive.blender.org/developer/F289535/854x480_vertical_rgb_grid2.png) with: ffmpeg -loop 1 -i 854x480_vertical_rgb_grid2.png -pix_fmt yuv420p -crf 20 -t 4 854x480_vertical_rgb_grid2.mp4
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @intracube

Added subscriber: @intracube

Added subscriber: @Sergey

Added subscriber: @Sergey
Sergey Sharybin self-assigned this 2016-03-14 10:55:35 +01:00

Will check later, but perhaps only real fix is to implement alignment form Blender side make damn FFmpeg happy..

Will check later, but perhaps only real fix is to implement alignment form Blender side make damn FFmpeg happy..
Author

After running through some test charts at various sizes, it looks like the horizontal resolution needs to be divisible by 32 to avoid any colour shift.

So common HD resolutions (1920 and 1280) are OK.

For other resolutions, this is going to cause some headaches for people colour keying and wondering why their mattes don't line up properly :/

After running through some test charts at various sizes, it looks like the horizontal resolution needs to be divisible by 32 to avoid any colour shift. So common HD resolutions (1920 and 1280) are OK. For other resolutions, this is going to cause some headaches for people colour keying and wondering why their mattes don't line up properly :/

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

This issue should now be fixed in Git. Thanks for the report!

This issue should now be fixed in Git. Thanks for the report!
Author

Can confirm it's now working. Thanks for the fix :)

Can confirm it's now working. Thanks for the fix :)
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#47766
No description provided.