Install Deps OSL 1.7.1 and clang-3.5 #47939

New Issue

Stefan Büttner · 2016-03-25T21:13:38+01:00

Stefan Büttner commented

2016-03-25 21:13:38 +01:00

Hey there,

the default version for llvm/clang used in the install_deps.sh script is 3.4. Since I didn't find clang-3.4 for my distribution, I tried 3.5 and 3.6. However, both of them faild building OSL 1.7.1.
Clang-3.5 requires OSL_BUILD_CPP11 to be set whereas OSL 1.7.1 does apparently not build with Clang-3.6 at all (https://github.com/imageworks/OpenShadingLanguage/issues/480).

So this patch should fix the Clang-3.5 problem and issue an error in case using a newer Clang version.

Cheers,
Stefan

osl-clang-3.5.patch

Hey there, the default version for llvm/clang used in the install_deps.sh script is 3.4. Since I didn't find clang-3.4 for my distribution, I tried 3.5 and 3.6. However, both of them faild building OSL 1.7.1. Clang-3.5 requires OSL_BUILD_CPP11 to be set whereas OSL 1.7.1 does apparently not build with Clang-3.6 at all (https://github.com/imageworks/OpenShadingLanguage/issues/480). So this patch should fix the Clang-3.5 problem and issue an error in case using a newer Clang version. Cheers, Stefan [osl-clang-3.5.patch](https://archive.blender.org/developer/F298295/osl-clang-3.5.patch)

Stefan Büttner commented

2016-03-25 21:13:38 +01:00

Changed status to: 'Open'

Stefan Büttner commented

2016-03-25 21:13:38 +01:00

Added subscriber: @StefanButtner

Stefan Büttner commented

2016-03-25 23:46:58 +01:00

Well, better use this patch >.<

osl-clang-3.5.patch

Well, better use this patch >.< [osl-clang-3.5.patch](https://archive.blender.org/developer/F298305/osl-clang-3.5.patch)

Bastien Montagne commented

2016-03-26 00:30:53 +01:00

Added subscriber: @mont29

Bastien Montagne self-assigned this 2016-03-26 00:30:53 +01:00

Bastien Montagne commented

2016-03-26 00:30:53 +01:00

Thanks for the patch, but it’s not only an issue for llvm/osl, it’s also an issue in Blender itself then, where you need to enable cpp11 etc.

So for now let’s keep install_deps as is, it’s already complicated enough, and let’s stick to officially supported version of llvm (3.4). Will update the script to only accept 3.4 packages (will build own llvm/clang otherwise).

Thanks for the patch, but it’s not only an issue for llvm/osl, it’s also an issue in Blender itself then, where you need to enable cpp11 etc. So for now let’s keep install_deps as is, it’s already complicated enough, and let’s stick to officially supported version of llvm (3.4). Will update the script to only accept 3.4 packages (will build own llvm/clang otherwise).

blender-admin commented

2016-03-26 00:31:41 +01:00

This issue was referenced by eac770a33a

This issue was referenced by eac770a33ad0bc0f00fc82f579fde7c62aa48a87

Bastien Montagne commented

2016-03-26 00:32:47 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2016-03-26 00:32:47 +01:00

Stefan Büttner commented

2016-03-26 16:48:33 +01:00

Okay. Yet this it still fails on my system because the scripts assumes that if llvm-3.4-dev is available, also clang-3.4 is available. However, this is not the case (although I'm not sure if that's a problem of my system due to misconfiguration, though). But apt-cache show llvm-3.4-dev shows no dependencies to clang. So the script should also check if clang is available, shouldn't it?

What about something like this?
llvm-clang.patch

Okay. Yet this it still fails on my system because the scripts assumes that if *llvm-3.4-dev* is available, also *clang-3.4* is available. However, this is not the case (although I'm not sure if that's a problem of my system due to misconfiguration, though). But *apt-cache show llvm-3.4-dev* shows no dependencies to clang. So the script should also check if clang is available, shouldn't it? What about something like this? [llvm-clang.patch](https://archive.blender.org/developer/F298348/llvm-clang.patch)

Bastien Montagne commented

2016-03-26 20:57:04 +01:00

Good point. In fact, it’s clang which depends on llvm (same version), so should be enough to check on clang package version.

blender-admin commented

2016-03-26 21:07:04 +01:00

This issue was referenced by 9317f9c055

This issue was referenced by 9317f9c05562671aaa0ac8e4d28aa1bb5e688a0b

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Install Deps OSL 1.7.1 and clang-3.5 #47939