New GGX breaks OpenCL kernel #48732
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#48732
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
R9 280X, Catalyst 16.3 on win 7 x64
Blender Version
Broken:
823ab66
Short description of error
broken kernel
Exact steps for others to reproduce the error
Hit F12 on default scene with cycles and GPU/OpenCL enabled:
Changed status to: 'Open'
Added subscriber: @bliblubli
This issue was referenced by blender/cycles@fb9833c20f
This issue was referenced by
99088f8b55
Changed status from 'Open' to: 'Resolved'
Hi,
it still broken:
Changed status from 'Resolved' to: 'Open'
Added subscribers: @LukasStockner, @ThomasDinges
Tested on nvidia opencl, don't have a AMD card to test here. @LukasStockner any idea?
@ThomasDinges, apparently I forgot the OpenCL-compliant syntax (ccl_fetch(), the addr_space keywords etc.) - I'll fix it as soon as possible.
This issue was referenced by blender/cycles@ace4aab253
This issue was referenced by
2a69b09b62
Changed status from 'Open' to: 'Resolved'
Changed status from 'Resolved' to: 'Open'
Maybe the foundation could invest 90€ in an AMD GPU for you Lukas ? With all what you do for cycles, it would help you a lot to test. In the meantime, I can report each step:
Well, I suppose I could try to install the AMD CPU runtime as well...
Anyways, instead of committing tons of additional "fixes", I think it would be best if you tried them out first :)
Could you remove the "ccl_addr_space" in kernel_random.h, line 235 (
ccl_device uint lcg_step_uint(ccl_addr_space uint *rng)
toccl_device uint lcg_step_uint(uint *rng)
) and see if it works that way?The file is in intern/cycles/kernel/ if you build from the source yourself, and in 2.77/scripts/addons/cycles/kernel/ if you use the buildbot builds.
As you wish, I can report back errors on every step or you can install the compiler. Latest proposed change done, new error is:
Okay, next step: In kernel_shader.h, line 830 (same folder as before), add ccl_addr_space in front of RNG (
ccl_device void shader_eval_surface(KernelGlobals *kg, ShaderData *sd, RNG *rng,
toccl_device void shader_eval_surface(KernelGlobals *kg, ShaderData *sd, ccl_addr_space RNG *rng,
).This issue was referenced by blender/cycles@6e89e10d7a
This issue was referenced by
23cc453975
Changed status from 'Open' to: 'Resolved'