autosave doesn't save like normal save #48929

New Issue

mathieu menuet · 2016-07-22T21:10:10+02:00

mathieu menuet commented

2016-07-22 21:10:10 +02:00

System Information
Win7 x64

Blender Version
Broken: 08e1bba

Short description of error
Auto saves don't save the edit mode changes unlike the normal save.

Exact steps for others to reproduce the error
Can't provide file. Set autosave to 1 min, save the default cube somewhere to activate autosave. Rotate or scale the cube in edit mode, validate and do nothing else but wait that the autosave file appear in your temp folder. Save the file again and load the autosave in Blender: Edit mode changes are not saved. Load the manually saved file, changes are saved there.

**System Information** Win7 x64 **Blender Version** Broken: 08e1bba **Short description of error** Auto saves don't save the edit mode changes unlike the normal save. **Exact steps for others to reproduce the error** Can't provide file. Set autosave to 1 min, save the default cube somewhere to activate autosave. Rotate or scale the cube in edit mode, validate and do nothing else but wait that the autosave file appear in your temp folder. Save the file again and load the autosave in Blender: Edit mode changes are not saved. Load the manually saved file, changes are saved there.

mathieu menuet commented

2016-07-22 21:10:10 +02:00

Changed status to: 'Open'

mathieu menuet commented

2016-07-22 21:10:10 +02:00

Added subscriber: @bliblubli

Bastien Montagne commented

2016-07-22 23:24:16 +02:00

Added subscribers: @ideasman42, @mont29

Bastien Montagne commented

2016-07-22 23:24:16 +02:00

Easy to confirm, caused by the fact we use global undo buffer to speed autosave - but this cannot work in Edit (or sculpt) modes, which have their own undo system.

Patch below seems to do the job, @ideasman42 what do you think?

P378: #48929.diff

diff --git a/source/blender/windowmanager/intern/wm_files.c b/source/blender/windowmanager/intern/wm_files.c
index fe257cc..89da7f2 100644
--- a/source/blender/windowmanager/intern/wm_files.c
+++ b/source/blender/windowmanager/intern/wm_files.c
@@ -1136,6 +1136,7 @@ void wm_autosave_timer(const bContext *C, wmWindowManager *wm, wmTimer *UNUSED(w
 	wmWindow *win;
 	wmEventHandler *handler;
 	char filepath[FILE_MAX];
+	bool use_undobuffer = (U.uiflag & USER_GLOBALUNDO) != 0;
 	
 	WM_event_remove_timer(wm, NULL, wm->autosavetimer);
 
@@ -1151,8 +1152,19 @@ void wm_autosave_timer(const bContext *C, wmWindowManager *wm, wmTimer *UNUSED(w
 
 	wm_autosave_location(filepath);
 
-	if (U.uiflag & USER_GLOBALUNDO) {
-		/* fast save of last undobuffer, now with UI */
+	if (use_undobuffer) {
+		/* fast save of last undobuffer, now with UI - does not work in case some object is in Edit (or Sculpt) mode */
+		Main *bmain = CTX_data_main(C);
+
+		for (Object *ob = bmain->object.first; ob; ob = ob->id.next) {
+			if (ob->mode & (OB_MODE_SCULPT | OB_MODE_EDIT)) {
+			    use_undobuffer = false;
+				break;
+			}
+		}
+	}
+
+	if (use_undobuffer) {
 		BKE_undo_save_file(filepath);
 	}
 	else {

Easy to confirm, caused by the fact we use **global** undo buffer to speed autosave - but this cannot work in Edit (or sculpt) modes, which have their own undo system. Patch below seems to do the job, @ideasman42 what do you think? [P378: #48929.diff](https://archive.blender.org/developer/P378.txt) ``` diff --git a/source/blender/windowmanager/intern/wm_files.c b/source/blender/windowmanager/intern/wm_files.c index fe257cc..89da7f2 100644 --- a/source/blender/windowmanager/intern/wm_files.c +++ b/source/blender/windowmanager/intern/wm_files.c @@ -1136,6 +1136,7 @@ void wm_autosave_timer(const bContext *C, wmWindowManager *wm, wmTimer *UNUSED(w wmWindow *win; wmEventHandler *handler; char filepath[FILE_MAX]; + bool use_undobuffer = (U.uiflag & USER_GLOBALUNDO) != 0; WM_event_remove_timer(wm, NULL, wm->autosavetimer); @@ -1151,8 +1152,19 @@ void wm_autosave_timer(const bContext *C, wmWindowManager *wm, wmTimer *UNUSED(w wm_autosave_location(filepath); - if (U.uiflag & USER_GLOBALUNDO) { - /* fast save of last undobuffer, now with UI */ + if (use_undobuffer) { + /* fast save of last undobuffer, now with UI - does not work in case some object is in Edit (or Sculpt) mode */ + Main *bmain = CTX_data_main(C); + + for (Object *ob = bmain->object.first; ob; ob = ob->id.next) { + if (ob->mode & (OB_MODE_SCULPT | OB_MODE_EDIT)) { + use_undobuffer = false; + break; + } + } + } + + if (use_undobuffer) { BKE_undo_save_file(filepath); } else { ```

Sergey Sharybin commented

2016-07-26 17:35:38 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2016-07-26 17:35:38 +02:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2016-07-26 17:35:38 +02:00

Sergey Sharybin self-assigned this 2016-07-26 17:35:38 +02:00

Sergey Sharybin commented

2016-07-26 17:35:38 +02:00

This is an intention of autosave to ignore sculpting, since trying to support that would cause really measurable hiccups during sculpt. See #32209 for more related changes and discussion.

Will consider this a TODO since it's something which is currently designed to work this way. Improvements arr possible, but are to be handled outside of the bug tracker. Thanks for the report anyway.

This is an intention of autosave to ignore sculpting, since trying to support that would cause really measurable hiccups during sculpt. See #32209 for more related changes and discussion. Will consider this a TODO since it's something which is currently designed to work this way. Improvements arr possible, but are to be handled outside of the bug tracker. Thanks for the report anyway.

mathieu menuet commented

2016-07-28 19:57:16 +02:00

Trying new versions in production greatly help to find bugs fast in complex, real world use cases. It would help a lot if you could add an option to make our work easier and give us an option for the auto save (with or without edit changes). It would:

Help us quickly get a version of the blend file just before the crash, making it easier to reproduce the bug.
Save a nice amount of work, allowing us to work pretty efficiently while helping the community to get a well tested blender.

Trying new versions in production greatly help to find bugs fast in complex, real world use cases. It would help a lot if you could add an option to make our work easier and give us an option for the auto save (with or without edit changes). It would: 1. Help us quickly get a version of the blend file just before the crash, making it easier to reproduce the bug. 2. Save a nice amount of work, allowing us to work pretty efficiently while helping the community to get a well tested blender.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

autosave doesn't save like normal save #48929