stdosl.h is not included anymore in some cycle shaders #49071

New Issue

T Reepleks · 2016-08-10T23:31:20+02:00

T Reepleks commented

2016-08-10 23:31:20 +02:00

I have an OSL compilation error on

blender/intern/cycles/kernel/shaders/node_rgb_curves.osl

It looks like the refactoring in commit ea2ebf7a00 (Cycles: constant folding for RGB/Vector Curves and Color Ramp) replaced the inclusion of "stdosl.h" by the new "node_ramp_util.h" but this new include file relies on the "clamp" function and does not include "stdosl.h" that defines it.

Likely solution: #include "stdosl.h" in "node_ramp_util.h".

Strangely, when I do this, oslc still complains wqith a warning

blender/intern/cycles/kernel/shaders/node_rgb_curves.osl:0: warning: Unable to find "stdosl.h"

but the compilation succeeds (for this file and for blender overall).

Could it be possible I have a bad "oslc" ?
Sorry if this is the case.

I have an OSL compilation error on ``` blender/intern/cycles/kernel/shaders/node_rgb_curves.osl ``` It looks like the refactoring in commit ea2ebf7a00f9adef9c14aaa24b79532b44043eba (Cycles: constant folding for RGB/Vector Curves and Color Ramp) replaced the inclusion of "stdosl.h" by the new "node_ramp_util.h" but this new include file relies on the "clamp" function and does not include "stdosl.h" that defines it. Likely solution: #include "stdosl.h" in "node_ramp_util.h". Strangely, when I do this, oslc still complains wqith a warning ``` blender/intern/cycles/kernel/shaders/node_rgb_curves.osl:0: warning: Unable to find "stdosl.h" ``` but the compilation succeeds (for this file and for blender overall). Could it be possible I have a bad "oslc" ? Sorry if this is the case.

Alexander Gavrilov was assigned by T Reepleks

2016-08-10 23:31:20 +02:00

T Reepleks commented

2016-08-10 23:31:20 +02:00

Changed status to: 'Open'

T Reepleks commented

2016-08-10 23:31:20 +02:00

Added subscriber: @treepleks

Aaron Carlisle commented

2016-08-11 00:41:13 +02:00

Added subscribers: @Sergey, @brecht

Alexander Gavrilov was unassigned by Brecht Van Lommel

2016-08-11 01:25:19 +02:00

Brecht Van Lommel self-assigned this 2016-08-11 01:25:19 +02:00

Brecht Van Lommel commented

2016-08-11 01:25:19 +02:00

Added subscriber: @angavrilov

Brecht Van Lommel commented

2016-08-11 01:25:19 +02:00

Which platform are you building on? Did you svn update the lib/ directory to the latest version?

The buildbot seems to be building ok on all platforms.

Ideally we shouldn't be including stdosl.h at all, we originally did it to solve some path issues. Maybe now it's possible to remove such includes entirely but will need to check.

Which platform are you building on? Did you svn update the lib/ directory to the latest version? The buildbot seems to be building ok on all platforms. Ideally we shouldn't be including stdosl.h at all, we originally did it to solve some path issues. Maybe now it's possible to remove such includes entirely but will need to check.

Campbell Barton commented

2016-08-11 05:54:31 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2016-08-11 05:54:31 +02:00

I ran into this some days ago (possibly the same bug?)

Using Arch Linux
For some reason oslc 1.7.2 wasn't finding its own include path.

For a temporary workaround, making this symlink resolved the issue.

  ln -s /usr/share/OSL /usr/lib/osl/include

Of course it should be resolved upstream.

Using prefix the oslc command with strace to see search paths which are searched.

I ran into this some days ago (possibly the same bug?) Using Arch Linux For some reason `oslc` 1.7.2 wasn't finding its own include path. For a temporary workaround, making this symlink resolved the issue. ``` ln -s /usr/share/OSL /usr/lib/osl/include ``` Of course it should be resolved upstream. Using prefix the `oslc` command with `strace` to see search paths which are searched.

T Reepleks commented

2016-08-11 20:15:27 +02:00

I'm the person that maintains the main Ubuntu PPA for blender (during week-ends - have a full time job otherwise).

This new compilation issue shows up on all distribs from Vivid to Xenial (so Debian too probably).

The strace shows that oslc does not search in the suitable paths:

stat("/usr/lib/osl/include", 0x7ffd67d4f6d0) = -1 ENOENT (No such file or directory)
stat("/usr/shaders", 0x7ffd67d4f6d0) = -1 ENOENT (No such file or directory)

since stdosl.h is either in pwd or in /usr/share/OSL-1.7.

I'm also providing OSL in my PPA, so it may be a compilation option I'm lacking when compiling OSL. I'm using OSL 1.7.1 for now.

The strace shows that "ln -s /usr/share/OSL-1.7 /usr/lib/osl/include" would work. I used a quilt patch that includes stdosl.h explicitely for now.

Thanks for the quick feedback and sorry for the disturbance.

I'm the person that maintains the main Ubuntu PPA for blender (during week-ends - have a full time job otherwise). This new compilation issue shows up on all distribs from Vivid to Xenial (so Debian too probably). The strace shows that oslc does not search in the suitable paths: stat("/usr/lib/osl/include", 0x7ffd67d4f6d0) = -1 ENOENT (No such file or directory) stat("/usr/shaders", 0x7ffd67d4f6d0) = -1 ENOENT (No such file or directory) since stdosl.h is either in `pwd` or in /usr/share/OSL-1.7. I'm also providing OSL in my PPA, so it may be a compilation option I'm lacking when compiling OSL. I'm using OSL 1.7.1 for now. The strace shows that "ln -s /usr/share/OSL-1.7 /usr/lib/osl/include" would work. I used a quilt patch that includes stdosl.h explicitely for now. Thanks for the quick feedback and sorry for the disturbance.

Brecht Van Lommel commented

2016-08-11 20:55:46 +02:00

Ok, it seems like the deeper issue is that OSL doesn't support having the include directory where Linux distributions like to place it. That shouldn't be too hard to fix but needs to be done upstream in OSL.

If building Blender worked before then I should be able to make that work again though.

Ok, it seems like the deeper issue is that OSL doesn't support having the include directory where Linux distributions like to place it. That shouldn't be too hard to fix but needs to be done upstream in OSL. If building Blender worked before then I should be able to make that work again though.

blender-admin commented

2016-08-12 01:01:09 +02:00

This issue was referenced by blender/cycles@6784e249d7

This issue was referenced by blender/cycles@6784e249d70bb300cf58345d86aa46de07921f9f

blender-admin commented

2016-08-12 01:01:09 +02:00

This issue was referenced by f3bff6a1a1

This issue was referenced by f3bff6a1a1cb05bcc6a540461f7a282da7bb3dae

Brecht Van Lommel commented

2016-08-12 01:03:13 +02:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue