Editing driver's expression eliminates "Zero" number #50063

New Issue

Serge Lyatin · 2016-11-17T18:33:36+01:00

Serge Lyatin commented

2016-11-17 18:33:36 +01:00

System Information
Win7 32bit

Blender Version
Broken: 2.78a

Exact steps for others to reproduce the error
Driver expression has got "zero" number at the end of line. Now click left mouse button into the violet "X Location" menu and zero somehow gone away.

Driver_zero.blend

**System Information** Win7 32bit **Blender Version** Broken: 2.78a **Exact steps for others to reproduce the error** Driver expression has got "zero" number at the end of line. Now click left mouse button into the violet "X Location" menu and zero somehow gone away. ![Driver_zero.jpg](https://archive.blender.org/developer/F402634/Driver_zero.jpg) [Driver_zero.blend](https://archive.blender.org/developer/F402636/Driver_zero.blend)

Serge Lyatin commented

2016-11-17 18:33:36 +01:00

Changed status to: 'Open'

Serge Lyatin commented

2016-11-17 18:33:36 +01:00

Added subscriber: @SergeL

Joshua Leung commented

2016-11-18 00:38:05 +01:00

Added subscribers: @JulianEisel, @mont29, @JoshuaLeung

Joshua Leung commented

2016-11-18 00:38:05 +01:00

Confirmed.

Hmm... this looks suspiciously like a bug in the UI code related to the way that it trims off excess zeros off the end of numbers. Some observations:

Once it has removed the zero, it doesn't remove any more digits/characters in subsequent editing cycles
If we replace the 0 with a 1 (or add a 1 after it), no truncation occurs.

@mont29 / @JulianEisel - Sounds like something for you guys to look into?

Confirmed. Hmm... this looks suspiciously like a bug in the UI code related to the way that it trims off excess zeros off the end of numbers. Some observations: * Once it has removed the zero, it doesn't remove any more digits/characters in subsequent editing cycles * If we replace the 0 with a 1 (or add a 1 after it), no truncation occurs. @mont29 / @JulianEisel - Sounds like something for you guys to look into?

Julian Eisel self-assigned this 2016-11-18 02:14:36 +01:00

Julian Eisel commented

2016-11-18 02:14:36 +01:00

Would propose this as fix: P425: Possible fix for #50063

diff --git a/source/blender/editors/interface/interface_anim.c b/source/blender/editors/interface/interface_anim.c
index 991cd54..5b2da6c 100644
--- a/source/blender/editors/interface/interface_anim.c
+++ b/source/blender/editors/interface/interface_anim.c
@@ -99,6 +99,10 @@ void ui_but_anim_flag(uiBut *but, float cfra)
        }
 }
 
+/**
+ * \a str can be NULL to only perform check if \a but has expression at all.
+ * \return if button has an expression.
+ */
 bool ui_but_anim_expression_get(uiBut *but, char *str, size_t maxlen)
 {
        FCurve *fcu;
@@ -111,7 +115,9 @@ bool ui_but_anim_expression_get(uiBut *but, char *str, size_t maxlen)
                driver = fcu->driver;
 
                if (driver && driver->type == DRIVER_TYPE_PYTHON) {
-                       BLI_strncpy(str, driver->expression, maxlen);
+                       if (str) {
+                               BLI_strncpy(str, driver->expression, maxlen);
+                       }
                        return true;
                }
        }
diff --git a/source/blender/editors/interface/interface_handlers.c b/source/blender/editors/interface/interface_handlers.c
index f3eeadb..fc511d6 100644
--- a/source/blender/editors/interface/interface_handlers.c
+++ b/source/blender/editors/interface/interface_handlers.c
@@ -3067,7 +3067,7 @@ static void ui_textedit_begin(bContext *C, uiBut *but, uiHandleButtonData *data)
                data->str = ui_but_string_get_dynamic(but, &data->maxlen);
        }
 
-       if (ui_but_is_float(but) && !ui_but_is_unit(but)) {
+       if (ui_but_is_float(but) && !ui_but_is_unit(but) && !ui_but_anim_expression_get(but, NULL, 0)) {
                BLI_str_rstrip_float_zero(data->str, '\0');
        }

It disables trimming of trailing zeros in case the button contains an expression.

Would propose this as fix: [P425: Possible fix for #50063](https://archive.blender.org/developer/P425.txt) ``` diff --git a/source/blender/editors/interface/interface_anim.c b/source/blender/editors/interface/interface_anim.c index 991cd54..5b2da6c 100644 --- a/source/blender/editors/interface/interface_anim.c +++ b/source/blender/editors/interface/interface_anim.c @@ -99,6 +99,10 @@ void ui_but_anim_flag(uiBut *but, float cfra) } } +/** + * \a str can be NULL to only perform check if \a but has expression at all. + * \return if button has an expression. + */ bool ui_but_anim_expression_get(uiBut *but, char *str, size_t maxlen) { FCurve *fcu; @@ -111,7 +115,9 @@ bool ui_but_anim_expression_get(uiBut *but, char *str, size_t maxlen) driver = fcu->driver; if (driver && driver->type == DRIVER_TYPE_PYTHON) { - BLI_strncpy(str, driver->expression, maxlen); + if (str) { + BLI_strncpy(str, driver->expression, maxlen); + } return true; } } diff --git a/source/blender/editors/interface/interface_handlers.c b/source/blender/editors/interface/interface_handlers.c index f3eeadb..fc511d6 100644 --- a/source/blender/editors/interface/interface_handlers.c +++ b/source/blender/editors/interface/interface_handlers.c @@ -3067,7 +3067,7 @@ static void ui_textedit_begin(bContext *C, uiBut *but, uiHandleButtonData *data) data->str = ui_but_string_get_dynamic(but, &data->maxlen); } - if (ui_but_is_float(but) && !ui_but_is_unit(but)) { + if (ui_but_is_float(but) && !ui_but_is_unit(but) && !ui_but_anim_expression_get(but, NULL, 0)) { BLI_str_rstrip_float_zero(data->str, '\0'); } ``` It disables trimming of trailing zeros in case the button contains an expression.

Bastien Montagne commented

2016-11-18 12:19:43 +01:00

@JulianEisel fix LGTM.