"Light path"-"is Singular Ray" node Affects material visibility trough a glass material different way in two Blender versions #50805

Closed
opened 2017-02-27 20:19:05 +01:00 by Ximo Blanes · 7 comments

System Information
OS: Windows10 (x64)
CPU: Intel(R) Core(TN) i7-4790 CPU 3.60GHz
RAM: 16GB
GPU: NVIDIA Quadro K2000
Drivers: (NVIDIA) 376.84

Blender Version
Broken: 2.78c e9f235283
Worked: 2.78a e8299c8

Short description of error
There is a plane with an image that is not possible to view trough a glass object in version 2.78c but is viewable with 2.78.a version of Blender using the same file for rendering.

Exact steps for others to reproduce the error
There is a "Light path" node in the image material setted as "is Singular Ray" and connected in the "factor" input of a "Mix node" where are mixed the image with a "Diffuse BSDF". When the "Filter Glossy" option (into the "Render"/"Light paths") menu has any value (minimal or maximal 0.0001 or 10) the image is visible trough the Glass material object when rendering in 2.78a version but in the same condition it isn't visible when rendering in 2.78c version.
There is the same issue when I try doing the same in another PC with different CPU and GPU.
I'm not sure if it's a bug but there is a difference, then I tell you. It is quick to see it in a render in the screen preview.Transp-Glass Shader issue_x.blend

**System Information** OS: Windows10 (x64) CPU: Intel(R) Core(TN) i7-4790 CPU 3.60GHz RAM: 16GB GPU: NVIDIA Quadro K2000 Drivers: (NVIDIA) 376.84 **Blender Version** Broken: 2.78c e9f235283 Worked: 2.78a e8299c8 **Short description of error** There is a plane with an image that is not possible to view trough a glass object in version 2.78c but is viewable with 2.78.a version of Blender using the same file for rendering. **Exact steps for others to reproduce the error** There is a "Light path" node in the image material setted as "is Singular Ray" and connected in the "factor" input of a "Mix node" where are mixed the image with a "Diffuse BSDF". When the "Filter Glossy" option (into the "Render"/"Light paths") menu has any value (minimal or maximal 0.0001 or 10) the image is visible trough the Glass material object when rendering in 2.78a version but in the same condition it isn't visible when rendering in 2.78c version. There is the same issue when I try doing the same in another PC with different CPU and GPU. I'm not sure if it's a bug but there is a difference, then I tell you. It is quick to see it in a render in the screen preview.[Transp-Glass Shader issue_x.blend](https://archive.blender.org/developer/F498118/Transp-Glass_Shader_issue_x.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @ximobl

Added subscriber: @ximobl
Member

Added subscribers: @Sergey, @LazyDodo

Added subscribers: @Sergey, @LazyDodo
Member

@Sergey mind taking a peek here? can confirm 2.78a works, but 2.78c and master don't.

@Sergey mind taking a peek here? can confirm 2.78a works, but 2.78c and master don't.
Author

Version 2.78a works fine with the nodes configuration as i said. Is the version 2.78c with the same config not working.
The 2.78c version was downloaded in http://download.blender.org/release/Blender2.78/
These are the two versions I've tested with the file I uploaded

Version 2.78a works fine with the nodes configuration as i said. Is the version 2.78c with the same config not working. The 2.78c version was downloaded in http://download.blender.org/release/Blender2.78/ These are the two versions I've tested with the file I uploaded

Short reply:

Think the real issue here is a lack of explicit mention of this change in the logs, which i did do now: https://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.78/Performance_update#Cycles

Full version:

This was a deliberate change in c4d6fd3. The reasoning here goes as:

  1. Mathematically speaking, GGX/Beckmann with 0 roughness is a singular ray, since there is no distortion happening for the normal.

  2. Some parts of Cycles were replacing GGX/Beckmann with Sharp distribution, when filter glossy was not used. This was causing different behavior of scenes after tweaking filter glossy or changing distribution. Such a change in behavior is really tricky to nail down in a real production movie shot scene.

  3. We were preparing for further changes, such as D2416 which required unification of ray visibility across closures as much as possible.

I would really prefer to keep behavior of Sharp and GGX/Beckmann unified so we can apply various optimization techniques both on Cycles and scene and yet keep things more consistent for artists.

So this is something we would live with. You can quite easily work that around by setting GGX distribution to a low non-zero value like 0.001.

Thanks for the report, closing it now.

Short reply: Think the real issue here is a lack of explicit mention of this change in the logs, which i did do now: https://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.78/Performance_update#Cycles Full version: This was a deliberate change in c4d6fd3. The reasoning here goes as: 1. Mathematically speaking, GGX/Beckmann with 0 roughness is a singular ray, since there is no distortion happening for the normal. 2. Some parts of Cycles were replacing GGX/Beckmann with Sharp distribution, when filter glossy was not used. This was causing different behavior of scenes after tweaking filter glossy or changing distribution. Such a change in behavior is really tricky to nail down in a real production movie shot scene. 3. We were preparing for further changes, such as [D2416](https://archive.blender.org/developer/D2416) which required unification of ray visibility across closures as much as possible. I would really prefer to keep behavior of Sharp and GGX/Beckmann unified so we can apply various optimization techniques both on Cycles and scene and yet keep things more consistent for artists. So this is something we would live with. You can quite easily work that around by setting GGX distribution to a low non-zero value like 0.001. Thanks for the report, closing it now.

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Sergey Sharybin self-assigned this 2017-02-28 09:55:03 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#50805
No description provided.