Deprecated OpenGL Migration, the home stretch! #51164

New Issue

Campbell Barton · 2017-04-10T10:45:48+02:00

Campbell Barton commented

2017-04-10 10:45:48 +02:00

This is add-hoc task to help manage

Catch errors/deprecated calls at runtime, fix code. @MikeErwin
Update or remove all uses of GPU_basic_shader (contains deprecated use of: gl_Vertex, gl_Normal, gl_ClipVertex).

(currently empty)

Ignore:

Game Engine (see UPBGE)

Done:

~~Blender should not crash when running with core profile only - current crashes are because of basic_shader) @dfelinto @Sergey~~
~~Background sets in eevee and clay-engine @fclem~~
~~Manipulators in eevee and clay engine. @fclem~~
~~ForceField shapes. @fclem~~
~~Remove usage of PRIM_QUADS_XXX primitives @mont29~~
~~Lattice drawing in eevee and clay engine @ideasman42~~
~~Use the new Matrix API everywhere @MikeErwin~~
~~Manipulator drawing @mont29~~
~~Fix UI blocky glitch in core profile for Linux @Sergey~~
~~Draw Manager: Basic curve drawing (wire only, since displist is being removed) @ideasman42~~
~~Remove BGL deprecated calls @dfelinto~~
~~Get core profile working on Mac @MikeErwin~~
~~Better context creation on Windows @MikeErwin~~
~~Object-mode selection drawing (use new draw manager). @ideasman42~~
~~Line stipple update @mont29~~

Notes:

To build with core profile:
WITH_GL_PROFILE_CORE=ON WITH_GL_PROFILE_COMPAT=OFF
WITH_LEGACY_OPENGL=OFF WITH_GAMEENGINE=OFF (not yet supported)
** WITH_PLAYER=OFF (needs BGE)
Draw Manager Tasks have been moved to: #51202

This is add-hoc task to help manage * Catch errors/deprecated calls at runtime, fix code. @MikeErwin * Update or remove all uses of `GPU_basic_shader` (contains deprecated use of: `gl_Vertex`, `gl_Normal`, `gl_ClipVertex`). <insert name here> ``` (currently empty) ``` ---- **Ignore:** * Game Engine (see UPBGE) --- **Done:** * ~~Blender should not crash when running with core profile only - current crashes are because of basic_shader) @dfelinto @Sergey~~ * ~~Background sets in eevee and clay-engine @fclem~~ * ~~Manipulators in eevee and clay engine. @fclem~~ * ~~ForceField shapes. @fclem~~ * ~~Remove usage of PRIM_QUADS_XXX primitives @mont29~~ * ~~Lattice drawing in eevee and clay engine @ideasman42~~ * ~~Use the new Matrix API everywhere @MikeErwin~~ * ~~Manipulator drawing @mont29~~ * ~~Fix UI blocky glitch in core profile for Linux @Sergey~~ * ~~Draw Manager: Basic curve drawing (wire only, since displist is being removed) @ideasman42~~ * ~~Remove BGL deprecated calls @dfelinto~~ * ~~Get core profile working on Mac @MikeErwin~~ * ~~Better context creation on Windows @MikeErwin~~ * ~~Object-mode selection drawing (use new draw manager). @ideasman42~~ * ~~Line stipple update @mont29~~ ---- **Notes:** * To build with core profile: **WITH_GL_PROFILE_CORE=ON** WITH_GL_PROFILE_COMPAT=OFF **WITH_LEGACY_OPENGL=OFF** WITH_GAMEENGINE=OFF (not yet supported) ** WITH_PLAYER=OFF (needs BGE) * Draw Manager Tasks have been moved to: #51202

Campbell Barton commented

2017-04-10 10:45:48 +02:00

Changed status to: 'Open'

Campbell Barton commented

2017-04-10 10:45:48 +02:00

Added subscribers: @ideasman42, @mont29, @dfelinto, @Sergey, @LucaRood-3

Campbell Barton changed title from ~~Deprecated OpenGL Migration, the final stretch!~~ to Deprecated OpenGL Migration, the home stretch!

2017-04-10 10:55:57 +02:00

Campbell Barton commented

2017-04-10 10:55:57 +02:00

Added subscriber: @fclem

Dalai Felinto commented

2017-04-10 11:03:52 +02:00

Added subscriber: @MikeErwin

blender-admin commented

2017-04-10 15:16:59 +02:00

This issue was referenced by 9fd3435a93

This issue was referenced by 9fd3435a93b45b80237419b1b218afdce72d4b9d

Dalai Felinto commented

2017-04-10 18:23:21 +02:00

Note on "icon_draw_rect: icons are" (assert on interface_icons.c when building WITH_GL_CORE). The problem seems to be with the window matrices. For example block->aspect should be 1.0, but instead it is 0.001. I believe the same happens for other values of the block->struct.

Sample file: clay-ui.blend

Note on "icon_draw_rect: icons are" (assert on interface_icons.c when building WITH_GL_CORE). The problem seems to be with the window matrices. For example block->aspect should be 1.0, but instead it is 0.001. I believe the same happens for other values of the block->struct. Sample file: [clay-ui.blend](https://archive.blender.org/developer/F541605/clay-ui.blend)

blender-admin commented

2017-04-10 22:22:37 +02:00

This issue was referenced by 4f063dc4dd

This issue was referenced by 4f063dc4dd127c9945b345dff7f316645a2470a4

blender-admin commented

2017-04-11 16:11:45 +02:00

This issue was referenced by 181c8f8ccd

This issue was referenced by 181c8f8ccd9f2ec102d3b78a18a809e320467aa2

Dalai Felinto commented

2017-04-18 10:28:59 +02:00

Added subscriber: @MartijnBerger

Dalai Felinto commented

2017-04-20 22:43:26 +02:00

@MikeErwin about the runtime problem with OSX. I had to update the extern glew to 2.0. Blender has a build option to use either the system glew or Blender's. So make sure you use Blender's glew for your tests!

Mike Erwin commented

2017-04-23 16:59:41 +02:00

In #51164#429546, @dfelinto wrote:
@MikeErwin about the runtime problem with OSX. I had to update the extern glew to 2.0. Blender has a build option to use either the system glew or Blender's. So make sure you use Blender's glew for your tests!

Turned out the problem was earlier in context setup. It wasn't even reaching glewInit! Once that was fixed I had no problem with GLEW on Mac.

> In #51164#429546, @dfelinto wrote: > @MikeErwin about the runtime problem with OSX. I had to update the extern glew to 2.0. Blender has a build option to use either the system glew or Blender's. So make sure you use Blender's glew for your tests! Turned out the problem was earlier in context setup. It wasn't even reaching glewInit! Once that was fixed I had no problem with GLEW on Mac.

Ulysse Martin commented

2017-05-22 12:35:43 +02:00

Added subscriber: @you.le