Wire line-width in draw manager ignores UI scale. #51206

Closed
opened 2017-04-14 16:19:47 +02:00 by Campbell Barton · 13 comments

All lines should be scaled by UI-scale, where 2x scale should give a 2-pixel width line.

Examples include:

  • edit-mode edge drawing.
  • transform constraint lines.
  • lasso, circle & border select.
  • wire for object mode lattice, curve speaker, camera, empties... etc.
All lines should be scaled by UI-scale, where 2x scale should give a 2-pixel width line. Examples include: - edit-mode edge drawing. - transform constraint lines. - lasso, circle & border select. - wire for object mode lattice, curve speaker, camera, empties... etc.
Author
Owner

Changed status to: 'Open'

Changed status to: 'Open'
Author
Owner

Added subscriber: @ideasman42

Added subscriber: @ideasman42

Added subscriber: @dfelinto

Added subscriber: @dfelinto

Note about glLineWidth from official glspec33.core.pdf:
"Wide lines - LineWidth values greater than 1.0 will generate an INVALID_VALUE error."

I haven't ran into issues with this, even in a system with Mesa. But we shouldn't rely on that.

Note about **glLineWidth** from official glspec33.core.pdf: *"Wide lines - LineWidth values greater than 1.0 will generate an INVALID_VALUE error."* I haven't ran into issues with this, even in a system with Mesa. But we shouldn't rely on that.
Member

Added subscriber: @MikeErwin

Added subscriber: @MikeErwin
Member

I've gotten mixed results with wide lines on core profile.

On Intel/Windows they work fine.

On Mac (Intel & NV) lines are drawn 1px and an error is logged.

Haven't checked this on other OS/GPU combos but we could survey them all to get a better idea of what is supported.

I've gotten mixed results with wide lines on core profile. On Intel/Windows they work fine. On Mac (Intel & NV) lines are drawn 1px and an error is logged. Haven't checked this on other OS/GPU combos but we could survey them all to get a better idea of what is supported.
Member

Added subscriber: @fclem

Added subscriber: @fclem
Member

Edit mode edge drawing uses a different technique though. It can be updated to respect UI scale. Similar for round points with outlines.

Edit mode edge drawing uses a different technique though. It can be updated to respect UI scale. Similar for round points with outlines.

Added subscriber: @antoniov

Added subscriber: @antoniov

@MikeErwin For grease pencil I had to create a geometry shader because widths greater than 1px are not supported in all opengl implementation, only 1px is mandatory, so with the new geom shader now I can draw thick lines with n pixels width.

@MikeErwin For grease pencil I had to create a geometry shader because widths greater than 1px are not supported in all opengl implementation, only 1px is mandatory, so with the new geom shader now I can draw thick lines with n pixels width.

Added subscriber: @brecht

Added subscriber: @brecht

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Brecht Van Lommel self-assigned this 2018-09-28 16:51:26 +02:00

I'm not sure if this was fixed, but edges appear to be drawn with a good size on high DPI screens now, making them thicker would not look good.

I'm not sure if this was fixed, but edges appear to be drawn with a good size on high DPI screens now, making them thicker would not look good.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#51206
No description provided.