Use A Higher Hair Segment Limit #51297

New Issue

Leon Cheung · 2017-04-23T14:17:37+02:00

Leon Cheung commented

2017-04-23 14:17:37 +02:00

I'm always wondering why the hair segment cannot be set to 50+. Is that for performance conern?

Normally, segments up to 50 can be quite enough for most cases. However, when dealing with things like braids, the current limit can sometimes be quite a pain.

If there has to be a limit here for some reason, then a higher limit (like 100 to 120) will be more convenient imho.

I'm always wondering why the hair segment cannot be set to 50+. Is that for performance conern? ![seg.png](https://archive.blender.org/developer/F570330/seg.png) Normally, segments up to 50 can be quite enough for most cases. However, when dealing with things like braids, the current limit can sometimes be quite a pain. If there has to be a limit here for some reason, then a higher limit (like 100 to 120) will be more convenient imho.

Leon Cheung commented

2017-04-23 14:17:37 +02:00

Changed status to: 'Open'

Leon Cheung commented

2017-04-23 14:17:37 +02:00

Added subscriber: @ZhangYu

ronan ducluzeau commented

2017-04-23 16:12:45 +02:00

Added subscriber: @zeauro

ronan ducluzeau commented

2017-04-23 16:12:45 +02:00

As you said, it is enough for most cases.
This setting is here to set up basic settings of particle system.
When you encounter a particular case, you are free to increase to 120 segments in particle edit mode with the Rekey operator.

Of course, such amount of segments have a consequence on performance.
It is better to avoïd a too high limit for such setting.
It is better to keep it with a limit for newbies and to inform advanced user that they can go further in particle edit mode.

As you said, it is enough for most cases. This setting is here to set up basic settings of particle system. When you encounter a particular case, you are free to increase to 120 segments in particle edit mode with the Rekey operator. Of course, such amount of segments have a consequence on performance. It is better to avoïd a too high limit for such setting. It is better to keep it with a limit for newbies and to inform advanced user that they can go further in particle edit mode.

Aaron Carlisle self-assigned this 2017-04-23 16:26:34 +02:00

Aaron Carlisle commented

2017-04-23 20:07:26 +02:00

Here is a patch, I can commit if we agree that we should increase this limit.

P468: Fix #51297

diff --git a/source/blender/makesrna/intern/rna_particle.c b/source/blender/makesrna/intern/rna_particle.c
index 95dab13..3024ace 100644
--- a/source/blender/makesrna/intern/rna_particle.c
+++ b/source/blender/makesrna/intern/rna_particle.c
@@ -2363,7 +2363,7 @@ static void rna_def_particle_settings(BlenderRNA *brna)
        RNA_def_property_ui_text(prop, "Render", "How many steps paths are rendered with (power of 2)");
 
        prop = RNA_def_property(srna, "hair_step", PROP_INT, PROP_NONE);
-       RNA_def_property_range(prop, 2, 50);
+       RNA_def_property_range(prop, 2, 128);
        RNA_def_property_ui_text(prop, "Segments", "Number of hair segments");
        RNA_def_property_update(prop, 0, "rna_Particle_reset");

Here is a patch, I can commit if we agree that we should increase this limit. [P468: Fix #51297](https://archive.blender.org/developer/P468.txt) ``` diff --git a/source/blender/makesrna/intern/rna_particle.c b/source/blender/makesrna/intern/rna_particle.c index 95dab13..3024ace 100644 --- a/source/blender/makesrna/intern/rna_particle.c +++ b/source/blender/makesrna/intern/rna_particle.c @@ -2363,7 +2363,7 @@ static void rna_def_particle_settings(BlenderRNA *brna) RNA_def_property_ui_text(prop, "Render", "How many steps paths are rendered with (power of 2)"); prop = RNA_def_property(srna, "hair_step", PROP_INT, PROP_NONE); - RNA_def_property_range(prop, 2, 50); + RNA_def_property_range(prop, 2, 128); RNA_def_property_ui_text(prop, "Segments", "Number of hair segments"); RNA_def_property_update(prop, 0, "rna_Particle_reset"); ```

Aaron Carlisle commented

2017-04-23 20:08:11 +02:00

Added subscriber: @LucaRood-3

Luca Rood commented

2017-04-24 00:32:45 +02:00

I really don't think this is the way to go about this. There is no point in slightly increasing the limit, as you can just as well find the new limit to be too low at some point in the future. I would be for keeping the 50 limit, but replacing it with a soft limit, that way, new users don't accidentally freeze their sims, but you are free to increase the the segments to whatever you want.

Leon Cheung commented

2017-04-24 15:17:28 +02:00

+1 for soft limit.

Aaron Carlisle commented

2017-05-10 04:53:35 +02:00

Here is a fix which uses a soft limit of 50 and a hard limit of 128:

P477: Fix #51297

diff --git a/source/blender/makesrna/intern/rna_particle.c b/source/blender/makesrna/intern/rna_particle.c
index 127c66a..ed1792c 100644
--- a/source/blender/makesrna/intern/rna_particle.c
+++ b/source/blender/makesrna/intern/rna_particle.c
@@ -2363,7 +2363,8 @@ static void rna_def_particle_settings(BlenderRNA *brna)
        RNA_def_property_ui_text(prop, "Render", "How many steps paths are rendered with (power of 2)");

        prop = RNA_def_property(srna, "hair_step", PROP_INT, PROP_NONE);
-       RNA_def_property_range(prop, 2, 50);
+       RNA_def_property_range(prop, 2, INT_MAX);
+       RNA_def_property_ui_range(prop, 2, 50, 1, -1);
        RNA_def_property_ui_text(prop, "Segments", "Number of hair segments");
        RNA_def_property_update(prop, 0, "rna_Particle_reset");

Here is a fix which uses a soft limit of 50 and a hard limit of 128: [P477: Fix #51297](https://archive.blender.org/developer/P477.txt) ``` diff --git a/source/blender/makesrna/intern/rna_particle.c b/source/blender/makesrna/intern/rna_particle.c index 127c66a..ed1792c 100644 --- a/source/blender/makesrna/intern/rna_particle.c +++ b/source/blender/makesrna/intern/rna_particle.c @@ -2363,7 +2363,8 @@ static void rna_def_particle_settings(BlenderRNA *brna) RNA_def_property_ui_text(prop, "Render", "How many steps paths are rendered with (power of 2)"); prop = RNA_def_property(srna, "hair_step", PROP_INT, PROP_NONE); - RNA_def_property_range(prop, 2, 50); + RNA_def_property_range(prop, 2, INT_MAX); + RNA_def_property_ui_range(prop, 2, 50, 1, -1); RNA_def_property_ui_text(prop, "Segments", "Number of hair segments"); RNA_def_property_update(prop, 0, "rna_Particle_reset"); ```

Leon Cheung commented

2017-05-10 04:59:35 +02:00

Very nice solution, Aaron! ❤

blender-admin commented

2017-05-15 20:29:59 +02:00

This issue was referenced by 4621583612

This issue was referenced by 4621583612fa40d90fa89dfc32686d39dc596714

Aaron Carlisle commented

2017-05-15 20:30:17 +02:00

Changed status from 'Open' to: 'Resolved'

Aaron Carlisle closed this issue

2017-05-15 20:30:17 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Use A Higher Hair Segment Limit #51297