Armature: Bone Draw Type: Wire #51365

New Issue

Campbell Barton · 2017-05-01T09:21:08+02:00

Campbell Barton commented

2017-05-01 09:21:08 +02:00

Note: this also draws bendy-bone segments.

Campbell Barton commented

2017-05-01 09:21:08 +02:00

Changed status to: 'Open'

Campbell Barton commented

2017-05-01 09:21:08 +02:00

Added subscriber: @ideasman42

Bastien Montagne self-assigned this 2017-05-02 09:12:08 +02:00

Bastien Montagne commented

2017-05-02 12:22:46 +02:00

Added subscribers: @fclem, @dfelinto

Bastien Montagne commented

2017-05-02 12:22:46 +02:00

Ok, so getting basics working here is trivial thanks to neighbor code ;) , but am hitting a problem which is each bbone segment needs its own matrix and… we have nowhere to store those (since batch drawing only copies pointers of data, not data itself, we need them to remain valid at least for the whole draw call).

So far I can think of three solutions:

Ditch instantiation of basic primitive (a mere line in this case) for each segment, and generate a complete bone with all its segments at once (but then we cannot reuse those, we have to generate a new VertexBuffer for every bendy bone).
Store BBone matrices in bones (as we already store there the disp_mat).

Store BBone matrices in global `g_data`.

I would go for solution 3, but thought I’d ask first in case you have a better idea, @ideasman42, @dfelinto, @fclem ?

Ok, so getting basics working here is trivial thanks to neighbor code ;) , but am hitting a problem which is each bbone segment needs its own matrix and… we have nowhere to store those (since batch drawing only copies pointers of data, not data itself, we need them to remain valid at least for the whole draw call). So far I can think of three solutions: - Ditch instantiation of basic primitive (a mere line in this case) for each segment, and generate a complete bone with all its segments at once (but then we cannot reuse those, we have to generate a new VertexBuffer for every bendy bone). - Store BBone matrices in bones (as we already store there the `disp_mat`). # Store BBone matrices in global `g_data`. I would go for solution 3, but thought I’d ask first in case you have a better idea, @ideasman42, @dfelinto, @fclem ?

Bastien Montagne commented

2017-05-02 14:37:35 +02:00

Correction, after quick testing, don't think we can use local static g_data here, works for drawing, but breaks selection (which I’d guess reuses same cached data but is drawn in complete separate call?)…

So new set of proposed solutions:

Ditch instantiation of basic primitive (a mere line in this case) for each segment, and generate a complete bone with all its segments at once (but then we cannot reuse those, we have to generate a new VertexBuffer for every bendy bone - and this would be true for BBone drawing itself too).
Store BBone matrices in bones (as we already store there the disp_mat).

Store BBone matrices in `OBJECT_PrivateData`… somehow?

Really dislike option 1, and I’d say option 2 is not acceptable (since it would be using data to store cache, we want to go away from doing that), so will dig around option 3 for now.

Correction, after quick testing, don't think we can use local static `g_data` here, works for drawing, but breaks selection (which I’d guess reuses same cached data but is drawn in complete separate call?)… So new set of proposed solutions: - Ditch instantiation of basic primitive (a mere line in this case) for each segment, and generate a complete bone with all its segments at once (but then we cannot reuse those, we have to generate a new VertexBuffer for every bendy bone - and this would be true for BBone drawing itself too). - Store BBone matrices in bones (as we already store there the disp_mat). # Store BBone matrices in `OBJECT_PrivateData`… somehow? Really dislike option 1, and I’d say option 2 is not acceptable (since it would be using data to store cache, we want to go away from doing that), so will dig around option 3 for now.

Bastien Montagne commented

2017-05-03 08:40:29 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2017-05-03 08:40:29 +02:00

Bastien Montagne commented

2017-05-03 08:40:29 +02:00

Done in d116932f3a.

(For the record, we decided to go with storage of the bbone segment matrices in allocated memory in bPoseChannel for now…).

Done in d116932f3a. (For the record, we decided to go with storage of the bbone segment matrices in allocated memory in bPoseChannel for now…).

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Armature: Bone Draw Type: Wire #51365

Store BBone matrices in global g_data.

Store BBone matrices in OBJECT_PrivateData… somehow?

Store BBone matrices in global `g_data`.

Store BBone matrices in `OBJECT_PrivateData`… somehow?