Crash unloading addon defining NodeCustomGroup while rendering #51676

New Issue

Corey Richardson · 2017-05-31T09:20:57+02:00

Corey Richardson commented

2017-05-31 09:20:57 +02:00

System Information

Arch Linux with AMD R9 285

Blender Version

Broken: 2.78 fb82948043

Short description of error

While rendering with a material using a NodeCustomGroup defined in an addon, unregistering the addon causes a crash.

Note that the attached "simplified" example (shader_test.py) works correctly! There's something going on with this complex shader that's causing a crash, and I unfortunately haven't been able to reduce it... Hopefully someone can do something with the crashlog.

Exact steps for others to reproduce the error

Load the attached ShaderNodeBsdfMetal.py, activate the "Conductive Fresnel Node" addon it defines, open the attached blend. Add a "Metal BSDF" node to the cube material, attach it to the output, then either hit F12 or shift-Z in the viewport. Deactivate "Conductive Fresnel Node" and witness the crash.

For the non-crash example, load the attached shader_test.py, activate the "Bug reproduction" addon it defines, replace the "Metal BSDF" node with a "Sample BSDF" (at the bottom of the list), attach it to the output, then hit F12 or shift-Z. Deactivate "Bug Reproduction" and witness the non-crash.

crash_repro.blend

ShaderNodeBsdfMetal.py

shader_test.py

crash_repro.crash.txt

**System Information** Arch Linux with AMD R9 285 **Blender Version** Broken: 2.78 fb82948043 **Short description of error** While rendering with a material using a NodeCustomGroup defined in an addon, unregistering the addon causes a crash. Note that the attached "simplified" example (shader_test.py) works correctly! There's something going on with this complex shader that's causing a crash, and I unfortunately haven't been able to reduce it... Hopefully someone can do something with the crashlog. **Exact steps for others to reproduce the error** Load the attached ShaderNodeBsdfMetal.py, activate the "Conductive Fresnel Node" addon it defines, open the attached blend. Add a "Metal BSDF" node to the cube material, attach it to the output, then either hit F12 or shift-Z in the viewport. Deactivate "Conductive Fresnel Node" and witness the crash. For the non-crash example, load the attached shader_test.py, activate the "Bug reproduction" addon it defines, replace the "Metal BSDF" node with a "Sample BSDF" (at the bottom of the list), attach it to the output, then hit F12 or shift-Z. Deactivate "Bug Reproduction" and witness the non-crash. [crash_repro.blend](https://archive.blender.org/developer/F613870/crash_repro.blend) [ShaderNodeBsdfMetal.py](https://archive.blender.org/developer/F613869/ShaderNodeBsdfMetal.py) [shader_test.py](https://archive.blender.org/developer/F613868/shader_test.py) [crash_repro.crash.txt](https://archive.blender.org/developer/F613871/crash_repro.crash.txt)

Corey Richardson commented

2017-05-31 09:20:57 +02:00

Changed status to: 'Open'

Corey Richardson commented

2017-05-31 09:20:57 +02:00

Added subscriber: @CoreyRichardson

Bastien Montagne commented

2017-05-31 09:53:43 +02:00

Added subscribers: @Sergey, @ideasman42, @mont29

Bastien Montagne commented

2017-05-31 09:53:43 +02:00

Would not consider this a bug really… It’s kind of obvious that if you remove some code/data parts defined in addon and used in render during a render, you expose yourself to issues… Just like you would if you tried to unregister an addon defining a given operator while running that operator. Later is not possible, can’t really see anyway to prevent the former though, except for making rendering fully blocking the UI.

Adding @Sergey & @ideasman42 for second advice on this, they might have ideas to prevent that kind of 'user bug' to happen, but…

Would not consider this a bug really… It’s kind of obvious that if you remove some code/data parts defined in addon and used in render during a render, you expose yourself to issues… Just like you would if you tried to unregister an addon defining a given operator while running that operator. Later is not possible, can’t really see anyway to prevent the former though, except for making rendering fully blocking the UI. Adding @Sergey & @ideasman42 for second advice on this, they might have ideas to prevent that kind of 'user bug' to happen, but…

Corey Richardson commented

2017-05-31 20:10:20 +02:00

While normally I'd agree, there's something funky happening with the "complex" example that is causing unregistering to crash that isn't happening with the simple example.

Sybren A. Stüvel commented

2020-01-31 10:20:33 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-01-31 10:20:33 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Sybren A. Stüvel commented

2020-01-31 10:20:33 +01:00

@CoreyRichardson I cannot reproduce this issue, the attached Python code produces this error:

Traceback (most recent call last):
  File "/home/sybren/workspace/blender-git/tracker/T51676-crash-unload-while-rendering/crash_repro.blend/ShaderNodeBsdfMetal.py", line 775, in <module>
  File "/home/sybren/workspace/blender-git/tracker/T51676-crash-unload-while-rendering/crash_repro.blend/ShaderNodeBsdfMetal.py", line 766, in register
  File "/home/sybren/workspace/blender-git/tracker/T51676-crash-unload-while-rendering/crash_repro.blend/ShaderNodeBsdfMetal.py", line 749, in register_MetalBSDF_menus
  File "/home/sybren/workspace/blender-git/tracker/T51676-crash-unload-while-rendering/crash_repro.blend/ShaderNodeBsdfMetal.py", line 721, in filtered_menu
NameError: name 'ShaderNewNodeCategory' is not defined
Error: Python script failed, check the message in the system console

Given that you have a simplified situation that is working, and a more complex situation that crashes, please take the time to remove bits and pieces of the complex example until it doesn't crash any more, then add back pieces until it does crash. Once you have the bit that is required to reproduce the crash, you can probably remove other bits around it. Keep going until you have the absolute bare minimum to reproduce the crash. This will give important information as to the underlying cause.

@CoreyRichardson I cannot reproduce this issue, the attached Python code produces this error: ``` Traceback (most recent call last): File "/home/sybren/workspace/blender-git/tracker/T51676-crash-unload-while-rendering/crash_repro.blend/ShaderNodeBsdfMetal.py", line 775, in <module> File "/home/sybren/workspace/blender-git/tracker/T51676-crash-unload-while-rendering/crash_repro.blend/ShaderNodeBsdfMetal.py", line 766, in register File "/home/sybren/workspace/blender-git/tracker/T51676-crash-unload-while-rendering/crash_repro.blend/ShaderNodeBsdfMetal.py", line 749, in register_MetalBSDF_menus File "/home/sybren/workspace/blender-git/tracker/T51676-crash-unload-while-rendering/crash_repro.blend/ShaderNodeBsdfMetal.py", line 721, in filtered_menu NameError: name 'ShaderNewNodeCategory' is not defined Error: Python script failed, check the message in the system console ``` Given that you have a simplified situation that is working, and a more complex situation that crashes, please take the time to remove bits and pieces of the complex example until it doesn't crash any more, then add back pieces until it does crash. Once you have the bit that is required to reproduce the crash, you can probably remove other bits around it. Keep going until you have the absolute bare minimum to reproduce the crash. This will give important information as to the underlying cause.

Aaron Carlisle commented

2020-02-10 17:32:33 +01:00

Added subscriber: @Blendify

Aaron Carlisle commented

2020-02-10 17:32:33 +01:00

Changed status from 'Needs User Info' to: 'Resolved'

Aaron Carlisle closed this issue

2020-02-10 17:32:33 +01:00

Aaron Carlisle self-assigned this 2020-02-10 17:32:33 +01:00

Aaron Carlisle commented

2020-02-10 17:32:33 +01:00

No activity for more than a week. As per the tracker policy we assume the issue is gone and can be closed.

Thanks again for the report. If the problem persists please open a new report with the required information.

No activity for more than a week. As per the tracker policy we assume the issue is gone and can be closed. Thanks again for the report. If the problem persists please open a new report with the required information.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash unloading addon defining NodeCustomGroup while rendering #51676