Grid is opaque and different scale on macOS #51813

New Issue

Andrei Nadin · 2017-06-15T08:34:09+02:00

Andrei Nadin commented

2017-06-15 08:34:09 +02:00

System Information
macOS 10.12.6 AMD Radeon R9 M390 2048 MB

Blender Version
Broken: blender-2.80.0-git20170615.f2d7a28a098-x86_64

Downloaded from https://builder.blender.org/download/

All working versions of 2.8 have shown this for me, on 10.12.5 and 10.12.6, In Evee and Clay the grid is an opaque 'floor' and appears to be very large.

Exact steps for others to reproduce the error
Just load the build and observe the cube in the default scene

Blender Render

Evee

**System Information** macOS 10.12.6 AMD Radeon R9 M390 2048 MB **Blender Version** Broken: blender-2.80.0-git20170615.f2d7a28a098-x86_64 Downloaded from https://builder.blender.org/download/ All working versions of 2.8 have shown this for me, on 10.12.5 and 10.12.6, In Evee and Clay the grid is an opaque 'floor' and appears to be very large. **Exact steps for others to reproduce the error** Just load the build and observe the cube in the default scene Blender Render ![BI Grid.png](https://archive.blender.org/developer/F631388/BI_Grid.png) Evee ![Evee Grid.png](https://archive.blender.org/developer/F631391/Evee_Grid.png)

Andrei Nadin commented

2017-06-15 08:34:10 +02:00

Changed status to: 'Open'

Andrei Nadin commented

2017-06-15 08:34:10 +02:00

Added subscriber: @AnadinX

Mike Erwin commented

2017-06-15 18:11:39 +02:00

Added subscriber: @MikeErwin

Mike Erwin commented

2017-06-15 18:11:39 +02:00

Exact same issue on Mac + NVIDIA.

However, Mac + Intel works as intended!

Exact same issue on Mac + NVIDIA. However, Mac + Intel works as intended!

Clément Foucault commented

2017-06-19 01:01:18 +02:00

Added subscriber: @fclem

Clément Foucault commented

2017-06-19 01:01:18 +02:00

I think this may come from derivative calculation. I use the GLSL function fwidth to compute line thickness and it requires local derivatives. So it may be a driver error or a faulty implementation of derivatives.

Adam Latchem commented

2018-05-26 13:35:08 +02:00

Added subscriber: @adamlatchem-2

Adam Latchem commented

2018-05-26 13:35:08 +02:00

581b021a1f
MacOS 10.13.4
NVIDIA GeForce GTX 775M 2048 MB graphics

The grid world positions lie (correctly in my view) in the plane Z=0. This makes the waves collapse to 0. I would think the fix below would also work on other platforms where presumably the grid world position is incorrectly in a plane with Z coordinate much larger than the x,y so has no effect on the clamping.

index baf508fd854..b6d764f3043 100644
    - a/source/blender/draw/modes/shaders/object_grid_frag.glsl
+++ b/source/blender/draw/modes/shaders/object_grid_frag.glsl
@@ -42,7 +42,7 @@ float get_grid(vec3 co, vec3 fwidthCos, float grid_size)

  grid_domain /= fwidthCos;

  /* collapse waves and normalize */

- grid_domain.x = min(grid_domain.x, min(grid_domain.y, grid_domain.z)) / grid_size;
+       grid_domain.x = min(grid_domain.x, grid_domain.y) / grid_size;

  return 1.0 - smoothstep(0.0, GRID_LINE_SMOOTH / grid_size, grid_domain.x);

 }```

With the above patch I see the following infinite grid rather than no grid and half occluded cube:

![Screen Shot 2018-05-26 at 12.29.36.png](https://archive.blender.org/developer/F3465995/Screen_Shot_2018-05-26_at_12.29.36.png)

581b021a1f1e987df66a659683cfc057f51dc204 MacOS 10.13.4 NVIDIA GeForce GTX 775M 2048 MB graphics The grid world positions lie (correctly in my view) in the plane Z=0. This makes the waves collapse to 0. I would think the fix below would also work on other platforms where presumably the grid world position is incorrectly in a plane with Z coordinate much larger than the x,y so has no effect on the clamping. ```diff --git a/source/blender/draw/modes/shaders/object_grid_frag.glsl b/source/blender/draw/modes/shaders/object_grid_frag.glsl index baf508fd854..b6d764f3043 100644 - a/source/blender/draw/modes/shaders/object_grid_frag.glsl +++ b/source/blender/draw/modes/shaders/object_grid_frag.glsl @@ -42,7 +42,7 @@ float get_grid(vec3 co, vec3 fwidthCos, float grid_size) ``` grid_domain /= fwidthCos; ``` ``` /* collapse waves and normalize */ ``` - grid_domain.x = min(grid_domain.x, min(grid_domain.y, grid_domain.z)) / grid_size; + grid_domain.x = min(grid_domain.x, grid_domain.y) / grid_size; ``` return 1.0 - smoothstep(0.0, GRID_LINE_SMOOTH / grid_size, grid_domain.x); ``` }``` With the above patch I see the following infinite grid rather than no grid and half occluded cube: ![Screen Shot 2018-05-26 at 12.29.36.png](https://archive.blender.org/developer/F3465995/Screen_Shot_2018-05-26_at_12.29.36.png)

Clément Foucault commented

2018-05-27 10:46:09 +02:00

Changed status from 'Open' to: 'Resolved'

Clément Foucault closed this issue

2018-05-27 10:46:09 +02:00

Clément Foucault commented

2018-05-27 10:48:18 +02:00

Thanks @adamlatchem-2 for finding the problem. I've commited a more general fix to this problem. Hopefully it should work on mac now.

blender-admin commented

2018-05-27 10:50:39 +02:00

This issue was referenced by 198be6f37b

This issue was referenced by 198be6f37b3ca8d65a026a7aeab7d8db4f3eb25e

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Grid is opaque and different scale on macOS #51813