Denoising passes; Variance pass output broken in recent builds #53109

Closed
opened 2017-10-19 23:43:13 +02:00 by Adam Friesen · 9 comments

System Information
Win64 bit, i7 3770 processor, 24 gigs RAM, AMD 7700 GPU

Blender Version
Broken: hash 9f8bb58 (October 2)
Worked: hash 83ce028 (October 7)

Short description of error
I'll let the image describe it
BrokenVariance.jpg

The variance denoise passes are broken, they are no longer calculating the actual variance (so now it's just like the regular versions of the pass with different color values).

Exact steps for others to reproduce the error
Render the scene in an older build, check the pass info. Render the scene in a newer build, check the pass info.

.blend
Brokenpasses.blend

**System Information** Win64 bit, i7 3770 processor, 24 gigs RAM, AMD 7700 GPU **Blender Version** Broken: hash 9f8bb58 (October 2) Worked: hash 83ce028 (October 7) **Short description of error** I'll let the image describe it ![BrokenVariance.jpg](https://archive.blender.org/developer/F1053113/BrokenVariance.jpg) The variance denoise passes are broken, they are no longer calculating the actual variance (so now it's just like the regular versions of the pass with different color values). **Exact steps for others to reproduce the error** Render the scene in an older build, check the pass info. Render the scene in a newer build, check the pass info. **.blend** [Brokenpasses.blend](https://archive.blender.org/developer/F1053131/Brokenpasses.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @Ace_Dragon

Added subscriber: @Ace_Dragon

Added subscriber: @Sergey

Added subscriber: @Sergey
Brecht Van Lommel was assigned by Sergey Sharybin 2017-10-20 10:58:11 +02:00

Caused by 12f4538. Worth adding a regression test for this i'd say.

Caused by 12f4538. Worth adding a regression test for this i'd say.

This issue was referenced by blender/cycles@ca8f3cce93

This issue was referenced by blender/cycles@ca8f3cce9315d86127c7a2f20eb21472f43cf820

This issue was referenced by 3df2e6d76b

This issue was referenced by 3df2e6d76bc7cbbee9e95330a3045cb2c02791be

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Added subscriber: @LukasStockner

Added subscriber: @LukasStockner

Note:

  • These are passes for debugging the denoiser, enabled with the experimental feature set.
  • The result for OpenCL renders was already like this.
  • The denoiser itself is working fine, the meaning of the passes just changed for CPU and CUDA.

Now it outputs the actual variance again since that's more useful to visualize for debugging.

Note: * These are passes for debugging the denoiser, enabled with the experimental feature set. * The result for OpenCL renders was already like this. * The denoiser itself is working fine, the meaning of the passes just changed for CPU and CUDA. Now it outputs the actual variance again since that's more useful to visualize for debugging.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#53109
No description provided.