Specials Menu (W) crashes with lamps if the Emission node is missing/ renamed in Cycles #53171

Closed
opened 2017-10-26 13:22:51 +02:00 by Vuk Gardašević · 6 comments

System Information
Win 7 64 bit, AMD X3 455, R7 360

Blender Version
Broken: current master 171c4e9, 2.79 and all the versions after the commit 6322f01783

Short description of error
The key value is hardcoded expecting a Emission called name for a node in the material tree. The problem arises if:

  • The Emission node is deleted or renamed
  • If a node of an another type is called Emission (as it expects a specific input)
  File "2.79\scripts\startup\bl_ui\space_view3d.py", line 1554, in draw
    value = lamp.node_tree.nodes["Emission"].inputs["Strength"].default_value
KeyError: 'bpy_prop_collection[key]: key "Emission" not found'

  File "2.79\scripts\startup\bl_ui\space_view3d.py", line 1554, in draw
    value = lamp.node_tree.nodes["Emission"].inputs["Strength"].default_value
KeyError: 'bpy_prop_collection[key]: key "Strength" not found'

Exact steps for others to reproduce the error
Default scene > switch to Cycles> Select a Lamp > Open the Node Editor > Enable nodes > Delete or rename the Emission node > In 3D View press W to bring the Specials menu.

**System Information** Win 7 64 bit, AMD X3 455, R7 360 **Blender Version** Broken: current master `171c4e9`, 2.79 and all the versions after the commit `6322f01783` **Short description of error** The key value is hardcoded expecting a Emission called name for a node in the material tree. The problem arises if: - The Emission node is deleted or renamed - If a node of an another type is called Emission (as it expects a specific input) ``` File "2.79\scripts\startup\bl_ui\space_view3d.py", line 1554, in draw value = lamp.node_tree.nodes["Emission"].inputs["Strength"].default_value KeyError: 'bpy_prop_collection[key]: key "Emission" not found' File "2.79\scripts\startup\bl_ui\space_view3d.py", line 1554, in draw value = lamp.node_tree.nodes["Emission"].inputs["Strength"].default_value KeyError: 'bpy_prop_collection[key]: key "Strength" not found' ``` **Exact steps for others to reproduce the error** Default scene > switch to Cycles> Select a Lamp > Open the Node Editor > Enable nodes > Delete or rename the Emission node > In 3D View press W to bring the Specials menu.
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscriber: @VukGardasevic

Added subscriber: @VukGardasevic

Added subscriber: @zeauro

Added subscriber: @zeauro

I confirm the issue with master and 2.79.
Specials Menu contains an item to modify strength of the lamp by dragging mouse in 3Dview.
But this strength is set by Emission node when nodes are enabled.

Of course, it does not work anymore if nodetree is modified and does not contain a node called "Emission".

Strength item in Specials menu for lamp is present only if nodes are enabled.

I confirm the issue with master and 2.79. Specials Menu contains an item to modify strength of the lamp by dragging mouse in 3Dview. But this strength is set by Emission node when nodes are enabled. Of course, it does not work anymore if nodetree is modified and does not contain a node called "Emission". Strength item in Specials menu for lamp is present only if nodes are enabled.

This issue was referenced by debd9f6ea1

This issue was referenced by debd9f6ea1286533d4d5c9262fa6724c862fe35e

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#53171
No description provided.