Keying Node fails with values above 1 #53371

New Issue

Sebastian Koenig · 2017-11-21T15:28:24+01:00

Sebastian Koenig commented

2017-11-21 15:28:24 +01:00

System Information
elementaryOS 0.4.1, GTX980ti

Blender Version
Broken: 2.79.1, 58a15b2

Short description of error
The Keying Node does not key colors with values above 1 correctly.
I noticed this behavior with badly lit greenscreen footage, which I had exported as EXR with Linear ACES colorspace. No matter what I try, all areas which are overexposed, with color values above 1, are not keyed at all.
Other keying nodes, such as the Chroma Key, work just fine.

Exact steps for others to reproduce the error
I have attached a file with a very simple example. There are 2 colors, one with green channel at 0.95, one with green channel at 1.05. The darker one keys just fine, but not matter how I set the key color or clip the blacks etc., the inner square simply doesn't key correctly. If you try with the Chroma Key or any other keying node it works just fine. I guess there is some internal clipping happening in the Keying Node. But since we are working in a linear color space this really should not be happening.
clipping_keyingnode.blend

**System Information** elementaryOS 0.4.1, GTX980ti **Blender Version** Broken: 2.79.1, 58a15b2 **Short description of error** The Keying Node does not key colors with values above 1 correctly. I noticed this behavior with badly lit greenscreen footage, which I had exported as EXR with Linear ACES colorspace. No matter what I try, all areas which are overexposed, with color values above 1, are not keyed at all. Other keying nodes, such as the Chroma Key, work just fine. **Exact steps for others to reproduce the error** I have attached a file with a very simple example. There are 2 colors, one with green channel at 0.95, one with green channel at 1.05. The darker one keys just fine, but not matter how I set the key color or clip the blacks etc., the inner square simply doesn't key correctly. If you try with the Chroma Key or any other keying node it works just fine. I guess there is some internal clipping happening in the Keying Node. But since we are working in a linear color space this really should not be happening. [clipping_keyingnode.blend](https://archive.blender.org/developer/F1167129/clipping_keyingnode.blend)

Sebastian Koenig commented

2017-11-21 15:28:24 +01:00

Changed status to: 'Open'

Sebastian Koenig commented

2017-11-21 15:28:24 +01:00

Added subscriber: @sebastian_k

Sergey Sharybin was assigned by Sebastian Koenig

2017-11-21 15:28:56 +01:00

Sebastian Koenig commented

2017-11-21 15:28:56 +01:00

Added subscriber: @SeanKennedy

Sergey Sharybin commented

2017-11-21 16:46:00 +01:00

This is currently expected behavior to consider all over-exposured areas as a non-screen because well, screen shouldn't be over-exposured. This was a big issue back to Trears of Steel with footage like tech. head with lamp.

However, we might try tweaking the condition here, so for example

P561: Patch for #53371

diff --git a/source/blender/compositor/operations/COM_KeyingOperation.cpp b/source/blender/compositor/operations/COM_KeyingOperation.cpp
index e2566d2f4f0..873a537efe3 100644
--- a/source/blender/compositor/operations/COM_KeyingOperation.cpp
+++ b/source/blender/compositor/operations/COM_KeyingOperation.cpp
@@ -74,8 +74,9 @@ void KeyingOperation::executePixelSampled(float output- [x], float x, float y, Pix
 	this->m_screenReader->readSampled(screenColor, x, y, sampler);
 
 	const int primary_channel = max_axis_v3(screenColor);
+	const float min_pixel_color = min_fff(pixelColor- [x], pixelColor- [x], pixelColor[2]);
 
-	if (pixelColor[primary_channel] > 1.0f) {
+	if (min_pixel_color > 1.0f) {
 		/* overexposure doesn't happen on screen itself and usually happens
 		 * on light sources in the shot, this need to be checked separately
 		 * because saturation and falloff calculation is based on the fact

might work good for you. Give it a try!

This is currently expected behavior to consider all over-exposured areas as a non-screen because well, screen shouldn't be over-exposured. This was a big issue back to Trears of Steel with footage like tech. head with lamp. However, we might try tweaking the condition here, so for example [P561: Patch for #53371](https://archive.blender.org/developer/P561.txt) ``` diff --git a/source/blender/compositor/operations/COM_KeyingOperation.cpp b/source/blender/compositor/operations/COM_KeyingOperation.cpp index e2566d2f4f0..873a537efe3 100644 --- a/source/blender/compositor/operations/COM_KeyingOperation.cpp +++ b/source/blender/compositor/operations/COM_KeyingOperation.cpp @@ -74,8 +74,9 @@ void KeyingOperation::executePixelSampled(float output- [x], float x, float y, Pix this->m_screenReader->readSampled(screenColor, x, y, sampler); const int primary_channel = max_axis_v3(screenColor); + const float min_pixel_color = min_fff(pixelColor- [x], pixelColor- [x], pixelColor[2]); - if (pixelColor[primary_channel] > 1.0f) { + if (min_pixel_color > 1.0f) { /* overexposure doesn't happen on screen itself and usually happens * on light sources in the shot, this need to be checked separately * because saturation and falloff calculation is based on the fact ``` might work good for you. Give it a try!

Sebastian Koenig commented

2017-11-21 17:12:48 +01:00

That patch works great, thanks a lot! :)
But man, the ToS footage was soo much better than the one I have to deal with right now...

That patch works great, thanks a lot! :) But man, the ToS footage was soo much better than the one I have to deal with right now...

blender-admin commented

2017-11-21 17:31:45 +01:00

This issue was referenced by 6785a2bd66

This issue was referenced by 6785a2bd66f7f1c55098e4c71baa68ce3cc2bbf9

Sergey Sharybin commented

2017-11-21 17:35:33 +01:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2017-11-21 17:35:33 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Keying Node fails with values above 1 #53371