Workspaces: Changing active view layer doesn't update viewport visibility #53636

New Issue

Dalai Felinto · 2017-12-26T13:27:22+01:00

Dalai Felinto commented

2017-12-26 13:27:22 +01:00

Blender Version
Broken: fe1e2c2f89

Short description of error
Disabled collections are "visible" when switch back and forth workspace viewlayers.

Exact steps for others to reproduce the error

Default Blender, disable Collection 1
Switch to "Viewport" view layer
Switch back to "RenderLayer" view layer

If we force depsgraph visibility to be re-evaluated (e.g., by changing the selectability of a collection) we get the "Viewport" to properly hide its objects.

I don't know if this is a depsgraph or workspaces bug to be honest.

**Blender Version** Broken: fe1e2c2f89 **Short description of error** Disabled collections are "visible" when switch back and forth workspace viewlayers. **Exact steps for others to reproduce the error** * Default Blender, disable Collection 1 * Switch to "Viewport" view layer * Switch back to "RenderLayer" view layer If we force depsgraph visibility to be re-evaluated (e.g., by changing the selectability of a collection) we get the "Viewport" to properly hide its objects. I don't know if this is a depsgraph or workspaces bug to be honest.

Sergey Sharybin was assigned by Dalai Felinto

2017-12-26 13:27:22 +01:00

Dalai Felinto commented

2017-12-26 13:27:22 +01:00

Added subscribers: @dfelinto, @JulianEisel

Dalai Felinto commented

2017-12-26 13:29:22 +01:00

We could simply ask depsgraph to re-evaluate the collections' visibility when changing workspace (DEG_id_tag_update(&scene->id, 0);). But I thought we already had a different depsgraph per viewlayer, so this shouldn't be necessary.

We could simply ask depsgraph to re-evaluate the collections' visibility when changing workspace (`DEG_id_tag_update(&scene->id, 0);`). But I thought we already had a different depsgraph per viewlayer, so this shouldn't be necessary.

Sergey Sharybin commented

2018-01-24 15:08:53 +01:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2018-01-24 15:08:53 +01:00

Sergey Sharybin commented

2018-01-24 15:08:53 +01:00

You definitely shouldn't be tagging SCENE for update when changing visible view layer. Also, now you should stop using flag 0 for updates, What you meant here perhaps is DEG_TAG_BASE_FLAGS_UPDATE.

Now, while we've got dependency graph per-view layer, the storage is still shared, unless you use copy on write. I've fixed missing updates for changing collections enabled flag in 9c493ca, so now this case works fine there.

Fixing this issue to work without CoW is a waste of time.

You definitely shouldn't be tagging SCENE for update when changing visible view layer. Also, now you should stop using flag 0 for updates, What you meant here perhaps is `DEG_TAG_BASE_FLAGS_UPDATE`. Now, while we've got dependency graph per-view layer, the storage is still shared, unless you use copy on write. I've fixed missing updates for changing collections enabled flag in 9c493ca, so now this case works fine there. Fixing this issue to work without CoW is a waste of time.

Dalai Felinto commented

2018-01-25 14:19:47 +01:00

Thanks for the explanation. It only occurred to me later that CoW was the missing piece here. I agree that it should be closed as invalid.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Workspaces: Changing active view layer doesn't update viewport visibility #53636