Proportional Size edit box and display/useage in viewport #53786

New Issue

Reiner Prokein · 2018-01-15T09:45:17+01:00

Reiner Prokein commented

2018-01-15 09:45:17 +01:00

System Information
Operating system and graphics card

Blender Version
Broken: (example: 2.69.7 4b206af, see splash screen)
Worked: (optional)

2.79(a), fresh from current Master

Short description of error
You can adjust the Proportional size in the Last operator. And the influence radius changes. But the proportional size radius in viewport still displays the old value, in both the header and the circle. And when you adjust the radius in the viewport, then the proportional size value in the Last operator snaps back to the value form the manipulation in the viewport instead of increasing from the value that you have typed in in the last operator Proportional Size edit box.

Exact steps for others to reproduce the error
Based on a (as simple as possible) attached .blend file with minimum amount of steps

Make a cube, enter edit mode. Enable Proportional Editing. Pull out a vertice. You will see the radius for proportional editing be displayed. And you can change it now by the scroll wheel for example.

The Proportional Size edit box updates the value.

Now change the value in the Edit box, and not by scroll wheel. The proportional influence changes. But the radius that displays the influence area stays still the same. And when you click at the transform widget, then the header shows the old value. We have now two different values for the same radius. Which i would classify as a bug.

Ideally the value in the viewport should update when you change the value in the edit box in the last operator panel.

**System Information** Operating system and graphics card **Blender Version** Broken: (example: 2.69.7 4b206af, see splash screen) Worked: (optional) 2.79(a), fresh from current Master **Short description of error** You can adjust the Proportional size in the Last operator. And the influence radius changes. But the proportional size radius in viewport still displays the old value, in both the header and the circle. And when you adjust the radius in the viewport, then the proportional size value in the Last operator snaps back to the value form the manipulation in the viewport instead of increasing from the value that you have typed in in the last operator Proportional Size edit box. **Exact steps for others to reproduce the error** Based on a (as simple as possible) attached .blend file with minimum amount of steps Make a cube, enter edit mode. Enable Proportional Editing. Pull out a vertice. You will see the radius for proportional editing be displayed. And you can change it now by the scroll wheel for example. The Proportional Size edit box updates the value. Now change the value in the Edit box, and not by scroll wheel. The proportional influence changes. But the radius that displays the influence area stays still the same. And when you click at the transform widget, then the header shows the old value. We have now two different values for the same radius. Which i would classify as a bug. Ideally the value in the viewport should update when you change the value in the edit box in the last operator panel. ![proportionalsizeproblem.jpg](https://archive.blender.org/developer/F1835752/proportionalsizeproblem.jpg)

Reiner Prokein commented

2018-01-15 09:45:17 +01:00

Added subscriber: @tiles

ronan ducluzeau commented

2018-01-15 14:54:39 +01:00

Added subscriber: @zeauro

ronan ducluzeau commented

2018-01-15 14:54:39 +01:00

I can not reproduce on linux. Master 75e2ae7 or official 2.79

Last operator panel displays last translation with enabled proportionnal editing only after a validation.
At that moment, there is no more setting available into header of 3DView.
I can redo a translation with enabled proportionnal editing to obtain something that looks like your screencapture.
But if it is the case, I can not edit last operator panel because it is refering to former translation.

If you have header of 3D View simplified to display operator values, last operator panel should be ignored and considered as previous operation and not current one.
It cannot be modified at same time.
If you have header of 3D View with all menus and buttons, last operator panel can be edited and its values modified.
You should not see a circle when tweaking proportionnal editing size into last operator panel. You should just see vertices moving.

So, I don't know if there is a really big bug under windows or if your are misunderstanding how last operator panel is intended to work.
Waiting a windows tester.

I can not reproduce on linux. Master 75e2ae7 or official 2.79 Last operator panel displays last translation with enabled proportionnal editing only after a validation. At that moment, there is no more setting available into header of 3DView. I can redo a translation with enabled proportionnal editing to obtain something that looks like your screencapture. But if it is the case, I can not edit last operator panel because it is refering to former translation. If you have header of 3D View simplified to display operator values, last operator panel should be ignored and considered as previous operation and not current one. It cannot be modified at same time. If you have header of 3D View with all menus and buttons, last operator panel can be edited and its values modified. You should not see a circle when tweaking proportionnal editing size into last operator panel. You should just see vertices moving. So, I don't know if there is a really big bug under windows or if your are misunderstanding how last operator panel is intended to work. Waiting a windows tester.

Reiner Prokein commented

2018-01-15 15:18:15 +01:00

Well, maybe it is really me understanding things wrong. But i have modified the size for proportional editing in two ways, and end in different results where it should end in the same result.

Let's say i have set the size to 2 with the scroll wheel. When i repeat the transformation, and adjust the size with the scroll wheel again, then it starts with the size from the former operation where i have already adjusted the size. 2. And scales bigger or smaller from this value.

Now let's say i set it with the scroll wheel to 2, and adjust the size to 5 in the last operator then. You will notice that the proportional editing changes to 5 under the hood. But now when i repeat the transformation, and adjust the size with the scroll wheel again, then it does not go on from 5, but from 2.

It is of course in both cases a fresh operation. And so we work with a fresh last operator panel in both cases. But as told with a different result.

Well, maybe it is really me understanding things wrong. But i have modified the size for proportional editing in two ways, and end in different results where it should end in the same result. Let's say i have set the size to 2 with the scroll wheel. When i repeat the transformation, and adjust the size with the scroll wheel again, then it starts with the size from the former operation where i have already adjusted the size. 2. And scales bigger or smaller from this value. Now let's say i set it with the scroll wheel to 2, and adjust the size to 5 in the last operator then. You will notice that the proportional editing changes to 5 under the hood. But now when i repeat the transformation, and adjust the size with the scroll wheel again, then it does not go on from 5, but from 2. It is of course in both cases a fresh operation. And so we work with a fresh last operator panel in both cases. But as told with a different result.

ronan ducluzeau commented

2018-01-16 12:10:49 +01:00

Thanks for this clarification.

Indeed, I can confim that change of proportional size through last operator panel is not kept at second call of the operator in master 45b5de9 or 2.79.
From a user perspective, the tool is often used with a succession of calls.
And the fact that value of the setting modified by mouse is kept proves that should behave the same when change is made by last operator region.

Thanks for this clarification. Indeed, I can confim that change of proportional size through last operator panel is not kept at second call of the operator in master 45b5de9 or 2.79. From a user perspective, the tool is often used with a succession of calls. And the fact that value of the setting modified by mouse is kept proves that should behave the same when change is made by last operator region.

Philipp Oeser commented

2018-01-17 16:26:43 +01:00

Added subscribers: @ideasman42, @lichtwerk

Campbell Barton was assigned by Philipp Oeser

2018-01-17 16:26:43 +01:00

Philipp Oeser commented

2018-01-17 16:26:43 +01:00

Reading blender/blender-addons#38367 (Operators no longer save / restore their last-used properties when invoked.) and related stackexchange or related commits it is still not clear to me if this is by design (or a bug)
There is a difference between the toolsetting and the last operator props (aka bpy.data.scenes['Scene'].tool_settings.proportional_size vs. bpy.data.window_managers['WinMan'].operators['TRANSFORM_OT_translate'].properties['proportional_size']).
Code in saveTransform() is explicitly only copying back to toolsettings in case of modal execution -- initTransform() will read back from toolsettings if modal.

I would kindly ask @ideasman42 to have a look here...

Reading blender/blender-addons#38367 (Operators no longer save / restore their last-used properties when invoked.) and related stackexchange or related commits it is still not clear to me if this is by design (or a bug) There is a difference between the toolsetting and the last operator props (aka `bpy.data.scenes['Scene'].tool_settings.proportional_size` vs. `bpy.data.window_managers['WinMan'].operators['TRANSFORM_OT_translate'].properties['proportional_size']`). Code in `saveTransform()` is explicitly only copying back to toolsettings in case of **modal** execution -- `initTransform()` will read back from toolsettings if **modal**. I would kindly ask @ideasman42 to have a look here...

Campbell Barton commented

2018-01-19 06:10:55 +01:00

Currently redo doesn't store values back to tool settings, since transform can run from Python we don't want to store the last used value in tool-settings in every instance, this patch allows operators to detect repeat execution: D3010

An alternate fix would be to always use the setting from the previous execution: P595
It's a much smaller change but has the down side that transform/rotate/scale etc - all have their own sizes.

Currently redo doesn't store values back to tool settings, since transform can run from Python we don't want to store the last used value in tool-settings in every instance, this patch allows operators to detect repeat execution: [D3010](https://archive.blender.org/developer/D3010) An alternate fix would be to always use the setting from the previous execution: [P595](https://archive.blender.org/developer/P595.txt) It's a much smaller change but has the down side that transform/rotate/scale etc - all have their own sizes.

Campbell Barton commented

2018-01-19 11:01:27 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2018-01-19 11:01:27 +01:00

blender-admin commented

2018-01-19 11:09:16 +01:00

This issue was referenced by 5a61c1de82

This issue was referenced by 5a61c1de8269c3398cc638f94141a30e3fbcf3cb

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Proportional Size edit box and display/useage in viewport #53786