Render crash with simple object only in debug build #54337

New Issue

Rob Hughes · 2018-03-16T18:22:18+01:00

Rob Hughes commented

2018-03-16 18:22:18 +01:00

System Information
5820K Windows10 GTX 970

Blender Version
Latest local build from master - date 16/03/2018

Short description of error
Render throws exception in debug build with very simple mesh - with adaptive subdivision

Problem appears to be in mesh_subdivsion.cpp
Line 193 int num_local_points = patch_table->GetNumLocalPoints();
returns zero
which means length of verts array is not increased and so
Line 207 patch_table->ComputeLocalPointValues(&verts- [x], &verts[num_refiner_verts]);
fails because num_refiner_verts is greater than length of array (last element is num_refiner_verts-1)

Hope that helps.

Exact steps for others to reproduce the error
Run debug version.
Load attached scene
Hit F12 to render

PatchT1.blend

**System Information** 5820K Windows10 GTX 970 **Blender Version** Latest local build from master - date 16/03/2018 **Short description of error** Render throws exception in debug build with very simple mesh - with adaptive subdivision Problem appears to be in mesh_subdivsion.cpp Line 193 int num_local_points = patch_table->GetNumLocalPoints(); returns zero which means length of verts array is not increased and so Line 207 patch_table->ComputeLocalPointValues(&verts- [x], &verts[num_refiner_verts]); fails because num_refiner_verts is greater than length of array (last element is num_refiner_verts-1) Hope that helps. **Exact steps for others to reproduce the error** Run debug version. Load attached scene Hit F12 to render [PatchT1.blend](https://archive.blender.org/developer/F2446322/PatchT1.blend)

Rob Hughes commented

2018-03-16 18:22:18 +01:00

Added subscriber: @RevDr

Ray molenkamp commented

2018-03-16 21:36:01 +01:00

Added subscribers: @MaiLavelle, @LazyDodo

Ray molenkamp commented

2018-03-16 21:36:01 +01:00

can confirm the issue, @MaiLavelle mind taking a peek here?

blender-admin commented

2018-04-04 05:36:35 +02:00

This issue was referenced by blender/cycles@4dd9298752

This issue was referenced by blender/cycles@4dd9298752ff0ba7db78dd7bd27320578e853461

blender-admin commented

2018-04-04 05:36:35 +02:00

This issue was referenced by fa01a1738b

This issue was referenced by fa01a1738bd1e3a6750ffbe523a282bc22de3991

Mai Lavelle self-assigned this 2018-04-04 05:38:41 +02:00

Mai Lavelle commented

2018-04-04 05:38:52 +02:00

Changed status from 'Open' to: 'Resolved'

Mai Lavelle closed this issue

2018-04-04 05:38:52 +02:00

Rob Hughes commented

2018-04-04 11:18:57 +02:00

Hi,

Thanks for the changes/ However, the basic test scene is still crashing for me in Debug,

Line 209

patch_table->ComputeLocalPointValues(&verts[0], &verts[num_refiner_verts]);

Problem is num_local_points is zero so length of array set in line 195..

verts.resize(num_refiner_verts + num_local_points);

..is equal to num_refiner_points

Therefore line 209 fails because &verts[num_refiner_verts] is outside bounds of array.

Hi, Thanks for the changes/ However, the basic test scene is still crashing for me in Debug, Line 209 ``` patch_table->ComputeLocalPointValues(&verts[0], &verts[num_refiner_verts]); ``` Problem is num_local_points is zero so length of array set in line 195.. ``` verts.resize(num_refiner_verts + num_local_points); ``` ..is equal to num_refiner_points Therefore line 209 fails because &verts[num_refiner_verts] is outside bounds of array.

Mai Lavelle commented

2018-04-04 12:30:23 +02:00

Oops, used the wrong variable, will commit a fix shortly.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Render crash with simple object only in debug build #54337