Sequencer Scene preivew Color Management is broken #54438

New Issue

Clément Foucault · 2018-03-27T15:36:43+02:00

Clément Foucault commented

2018-03-27 15:36:43 +02:00

Blender 2.8
Failling : dff7f55cd0
Working : unknown

Final display space is kind of broken for the scene preview strip.

Draw manager is outputing linear color into a byte buffer (could be float buffer if we want).
This byte buffer has the color management of the sequencer scene applied to it.

So maybe it would be a good idea to just output the byte buffer to the right display space? or keep a linear buffer and color manage in sequencer?
I don't know which color space should be use in this case, the scene that contains the sequencer or the scene of the strip?

This is tricky to debug because of this bug #54437

Blender 2.8 Failling : dff7f55cd069a15493db00aef8f28f4f3be24b8f Working : unknown [seq_eevee.blend](https://archive.blender.org/developer/F2516936/seq_eevee.blend) Final display space is kind of broken for the scene preview strip. Draw manager is outputing linear color into a byte buffer (could be float buffer if we want). This byte buffer has the color management of the sequencer scene applied to it. So maybe it would be a good idea to just output the byte buffer to the right display space? or keep a linear buffer and color manage in sequencer? I don't know which color space should be use in this case, the scene that contains the sequencer or the scene of the strip? This is tricky to debug because of this bug #54437

Sergey Sharybin was assigned by Clément Foucault

2018-03-27 15:36:43 +02:00

Clément Foucault commented

2018-03-27 15:36:44 +02:00

Added subscribers: @fclem, @dfelinto

Sergey Sharybin removed their assignment 2018-03-28 11:01:10 +02:00

Clément Foucault was assigned by Sergey Sharybin

2018-03-28 11:01:10 +02:00

Sergey Sharybin commented

2018-03-28 11:01:10 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2018-03-28 11:01:10 +02:00

Byte buffer is supposed to be in display space, which is sRGB for current OpenGL in master. If you want to output linear space, do so to the float buffer. If you want to keep using byte buffer, apply OCIO GLSL on it.

This is nothing i can fix here, you're violating the existing design.

Byte buffer is supposed to be in display space, which is sRGB for current OpenGL in master. If you want to output linear space, do so to the float buffer. If you want to keep using byte buffer, apply OCIO GLSL on it. This is nothing i can fix here, you're violating the existing design.

Clément Foucault was unassigned by Brecht Van Lommel

2019-06-06 17:29:31 +02:00

Jeroen Bakker was assigned by Brecht Van Lommel

2019-06-06 17:29:31 +02:00

Brecht Van Lommel commented

2019-06-06 17:30:02 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-06-06 17:30:02 +02:00

@Jeroen-Bakker, can you check if is fixed or needs additional work? This is quite an old report.

Jeroen Bakker commented

2019-06-07 08:52:34 +02:00

Changed status from 'Open' to: 'Resolved'

Jeroen Bakker closed this issue

2019-06-07 08:52:34 +02:00

Jeroen Bakker commented

2019-06-07 08:52:34 +02:00

Solved with recent changes.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Sequencer Scene preivew Color Management is broken #54438